Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp868346pxb; Fri, 22 Jan 2021 00:57:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyG2us5aVwz1AX24lQkgQClQzL43NnCv1dznfqhhC+1oNEtFXdJCN3JkA49A8sLtFAQJOy0 X-Received: by 2002:a05:6402:1648:: with SMTP id s8mr2440602edx.50.1611305840146; Fri, 22 Jan 2021 00:57:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611305840; cv=none; d=google.com; s=arc-20160816; b=pEvMxYRsTvm5JcLqMBNnldJVPwTEaY7QG82DDxEuo10GfAKhZWfT0J8MW+LZi6tZqs wUsGGQu7TNwglyVJUvt8+hkfQd+fuJRLwrFIGHMKbSigdttyfNgI2KXuC6jUsM79aK+s JSc3KDZW17Em5YND6y4ZWi+pISzWtrnQCHn3+bz1ucPoeQiYH4kCJ/wAwaA6GnyP0zxE XYSvGmu5AE+0uweZ5/tKSonqg1QMX3GXwmc9CgC60iHygTCGCv1ahT21uN/9EMBP6oCS 791e6C3jTQA6zk2uZ8RtV2X8ME1ibGY400+APfVrCvEf7KibMUR7+QlnZ5aw/OoHZdQk IJ2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Fz2SdsRmzyg/R2X1FlxG9bQZ+ajptlq0wR7ERPzwqDc=; b=wM/yfje4/MF5ISZjd9B/m+40UIJsqsjkgSF5rvVIY67Fjurep/hmkRFD+v77CImejh mogQxkR2QLJd2qOcWCEotxwkVtOb1LM077xYMGZjxwN19azrm2moMAJl7sH7u1dailfH h/9rzHX0AL6uXxEwQeBxm0OMIX/NbHRYzCzhVP5vXaO9Wmxf2hxMI4TZN/kOya842BW5 NVjIhp+oDqCa7bIvH9HmUrwIR5+PhXTHCaMzf23vXeJFs/VgnWnYHyp+5zq/QVgMZoo2 FVH/xcA9Hnt6F7pY6tFqaI6F4fHtsuQwtufuWX1mfPitN6BIgSV0Fp+hy6Swv/AdiqdS WoUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ddZNA3M6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a25si2781888ejd.541.2021.01.22.00.56.56; Fri, 22 Jan 2021 00:57:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ddZNA3M6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727249AbhAVIyz (ORCPT + 99 others); Fri, 22 Jan 2021 03:54:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:54954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727229AbhAVIyb (ORCPT ); Fri, 22 Jan 2021 03:54:31 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 576F220739; Fri, 22 Jan 2021 08:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611305631; bh=Fz2SdsRmzyg/R2X1FlxG9bQZ+ajptlq0wR7ERPzwqDc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ddZNA3M6UjNKCbv2ln05xi74+gg8RxPyfmTwHQ4mUmmkjwJ9S9/sn0rRIy3ApJYra ofdkWNtzHT0/iNjwUZK2whof89UzJC4pL+jhDlg2zofzNVukbVCGpITfv4dRSH/NP+ Vljz4p4ya+TFxfBBgfNn7l16vKcvpy85i80JNbTCcKiLpQnkq2hhXjk5a4bFmW6INV djOy8m4qPjMvnzIVJvaQcwI+tPU6Vw+ZXR4jezPjuaA6S/H0iY30pf7MLs8p7yjxK+ R37SCiknKGV/Du5Z6/rAraxkbZZzlhu5BiY1umPObLP6MEingJjnI2C2JBYNfkRqlq PS2UjRs5P+fWQ== Date: Fri, 22 Jan 2021 09:53:48 +0100 From: Wolfram Sang To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Wim Van Sebroeck , Guenter Roeck , William Breathitt Gray , Greg Kroah-Hartman , "Rafael J. Wysocki" , Pau Oliva Fora , Dmitry Torokhov , Mauro Carvalho Chehab , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Matthew Wilcox , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Finn Thain , Michael Schmitz , Jaroslav Kysela , Takashi Iwai , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void Message-ID: <20210122085348.GB858@kunai> Mail-Followup-To: Wolfram Sang , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Wim Van Sebroeck , Guenter Roeck , William Breathitt Gray , Greg Kroah-Hartman , "Rafael J. Wysocki" , Pau Oliva Fora , Dmitry Torokhov , Mauro Carvalho Chehab , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Matthew Wilcox , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Finn Thain , Michael Schmitz , Jaroslav Kysela , Takashi Iwai , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, alsa-devel@alsa-project.org References: <20210121204812.402589-1-uwe@kleine-koenig.org> <20210121204812.402589-3-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ADZbWkCsHQ7r3kzd" Content-Disposition: inline In-Reply-To: <20210121204812.402589-3-uwe@kleine-koenig.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ADZbWkCsHQ7r3kzd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 21, 2021 at 09:48:12PM +0100, Uwe Kleine-K=C3=B6nig wrote: > The driver core ignores the return value of the remove callback, so > don't give isa drivers the chance to provide a value. >=20 > Adapt all isa_drivers with a remove callbacks accordingly; they all > return 0 unconditionally anyhow. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig Acked-by: Wolfram Sang # for I2C --ADZbWkCsHQ7r3kzd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmAKkpwACgkQFA3kzBSg KbYioA//frCM2vGMNRb9m2Wz+bP5qkNSp3R5QbWC14WxE8ZsbjcOun8Op9VX023l cmNSjxAFJ7nXTQgZYnrdfSo5+ZegXPapPa6zwpSF29HDrvoDmo7yHCVnrhSp+ko2 nauFE8d5U2LLJftrZ29QteTfvmBQn0RFdsO2NFFwCo9bVZd5UfwxinwQk3ncG4Fs 7th2N/Hwnb0Xb5NswrpHEeknQCVuYZdOx3bo21TQ/eImBBwT6iKExwzBYN+YX/Uw AckTF0es+DatjTNiFBLvNHSDf0/bjroW+oIsZeu6Wz5G73yBqWiJmyhNLR4XxRJf RgkOj9UvQsNAZhA/hKbFjtT0sv9yXYm4pe76+47Aw5YxnN5WQIAtBV0tsd5Dfs4Q FCOIHYbsR8lchLm/HGG4D9L0w5fUgQ3TzaOUaWUQ3sjeHvpTGSH7JJCblU3FXlFB N3Cn6HcfRTe7Izg9jH6lkYmaDvwsshB3VjK/uiegjLZPkN/EPGkNdwRnDId4zk/7 /Zgb5gYeLzQzXlxJM+WFgTS4aLLGg6UGxgl6PUHeSUXKdxoo9pjk7LtfRVpb+mHu LHt7KzZLjCHrntyYHaXrxSHcjQZzxr8pGnPl+bfMjlpKpkbMBIyfncncJUiDz6cy DuITnJtHM/j/zc6ciV1UPNWiF9bIu1ga6GdKu9/UEMlvE7xkgXs= =0OvQ -----END PGP SIGNATURE----- --ADZbWkCsHQ7r3kzd--