Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp887867pxb; Fri, 22 Jan 2021 01:33:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrozRjBETIsjZnzMYgEiDT8PjhDYVYgdus4+NW1Wukqlj2nBbGMqTDgCYIlhi8a9YtpF7R X-Received: by 2002:a50:fb0e:: with SMTP id d14mr2436654edq.369.1611308036417; Fri, 22 Jan 2021 01:33:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611308036; cv=none; d=google.com; s=arc-20160816; b=DKjlO2qtH+p6W9mMhMBd5qu3xgGUd6Z5jAEKtXzao0N+5pf4yzsnGSAdIDya+NuoJQ GJ+e/ClGHGS29huoUwU20UFJoiD6YzBLBkjSXjqFOjzA2PTHYYBwOx6ntuvl7h/j+7kj Ixu4N1MbYXVkoVoCZhpESX4AxWKKk0qEKRtAexhfRQRYZzhO+LSwM1+HIiNh70/DbCuo 3XKkLZRbACSgb1WETU59btYrPPmEqTQVupWaat3/4emVuVNk4qDKGNUnBU8dvhja/hzq 7IJDfNFOBaFgrHL8/TerY4CbbFVQidobrXly7G1OlWqP1Qx9S307ViMFXbUBU4nT0vX3 ygbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:subject:cc:to:from:message-id :date; bh=/fSjvGxXrQKn4B2Q7vg1MYKg0Hd8Wj1AmII3EbyvT8Y=; b=c8yk6aB/jZIEf+U93Q854fxj7dP6rm+wHwQcWkQgWv4/jTcrUqudVFr5+Lolgcntvq wFK4MAC6aIb8YOhtaFLATMnS4iuQcov/fwZqyhXLovzoI7ArpreLZ0yLuAc/GzoRrkjZ w42EMJL/M1Rstxqq3XJ52RtiSJiWXK5MX1PBQZuQFxczaMdd5h/XsK6HxqIo2ocnjkz0 XDrIWzXF6Bljxl/8FH8j+u8enRnMHFZPwVf2nehVYmQ2wUKQ76PD1kA1okGUU7bm72AH tBDSsq9LKj/py5p/hCpQQcrNDVhtsRV5r8XIxUYYzLtBFA0DXLjOjYvaNMpudc8yJRUC OPMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s15si3176837edj.492.2021.01.22.01.33.33; Fri, 22 Jan 2021 01:33:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727097AbhAVJas (ORCPT + 99 others); Fri, 22 Jan 2021 04:30:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:33964 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727156AbhAVJB6 (ORCPT ); Fri, 22 Jan 2021 04:01:58 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 15E19AEAC; Fri, 22 Jan 2021 09:01:16 +0000 (UTC) Date: Fri, 22 Jan 2021 10:01:15 +0100 Message-ID: From: Takashi Iwai To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Wim Van Sebroeck , Guenter Roeck , William Breathitt Gray , Greg Kroah-Hartman , "Rafael J. Wysocki" , Pau Oliva Fora , Dmitry Torokhov , Mauro Carvalho Chehab , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Matthew Wilcox , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Finn Thain , Michael Schmitz , Jaroslav Kysela , Takashi Iwai , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void In-Reply-To: <20210121204812.402589-3-uwe@kleine-koenig.org> References: <20210121204812.402589-1-uwe@kleine-koenig.org> <20210121204812.402589-3-uwe@kleine-koenig.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Jan 2021 21:48:12 +0100, Uwe Kleine-König wrote: > > The driver core ignores the return value of the remove callback, so > don't give isa drivers the chance to provide a value. > > Adapt all isa_drivers with a remove callbacks accordingly; they all > return 0 unconditionally anyhow. > > Signed-off-by: Uwe Kleine-König For the sound/* changes: Reviewed-by: Takashi Iwai BTW, how will we take the patches? Judging from the LOCs, sound/* are mostly affected, so I may merge them via sound.git tree, if other people have no objection. thanks, Takashi