Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp894575pxb; Fri, 22 Jan 2021 01:45:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpIsH4p5VgEONIIpSPukj4kn5r+UwfFgmz1Ylv2jt97iSiEyK8ZDWwgpqoH7KUuXyuzZxo X-Received: by 2002:a17:907:10c8:: with SMTP id rv8mr2373117ejb.228.1611308754594; Fri, 22 Jan 2021 01:45:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611308754; cv=none; d=google.com; s=arc-20160816; b=XYkZUN77uuALvRv9rP6Wk0ZSulbkHk1g3TuNiv5+O7lRrB1ARTZsraD5hNvpE4I3Ix vwanCwbbT8Nnodq23PIVdC9vXoC8dltnW8+wPV9EI18b0uG0Ggot5NmL8ZPsnEUqDcY2 Sduu4eygfnbVqNYhrc0h/7NeTQwCE4N3bK/KnWuDm/tz7s5/lSKi+ImyTzfrolWxti76 q4OBfsovR11URu8fHISNv6WZZNqYzMZSMiKPFq9/pvJYIfmJgtlYMRwzCg3ndoU5DWp7 2Pm7FU5T7Fsj6d5/Fl0yxlSSyDEQUCkrjirJ89cf38rcauH/AeLYfuoyhWwcM4v7FU0m fbAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=YVtL57Gz6ngYQWieTf+LZYQbcrzQg4GONslX47X+qjA=; b=gJK6RLomEbJVehfis+ENNPrw2Bf6IYHgNiO5Qbk1VayGSPR7yp9ISxHmeq0uvS+D2P gIJlmmrbTKMleTPjX62AsnTN89/eIvDrpJHJHP6fc4ai1leg5REdbmemy0fkk2ahIdQ5 25HgSjr1Qq63PiLjuOGuoZNvvPoo4BTRxdydLixH1q3Xq7kJM6y0uOMpmuNZrvOCOuqF sWlwKJLJFY9iKQVZp54WK2H4wJjttYNunWdjgy4Jko3Kjis0VxpAsnd9ENwsV04GGBtk GLKs0CIXylRNEZunr3Id/pYrfBQ72YiJUEwtp68EGSJApfsUzaIO8oymKJxhIzDeXnYO XyBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k9si2990701eje.254.2021.01.22.01.45.31; Fri, 22 Jan 2021 01:45:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727420AbhAVJnJ (ORCPT + 99 others); Fri, 22 Jan 2021 04:43:09 -0500 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:57302 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726488AbhAVJYn (ORCPT ); Fri, 22 Jan 2021 04:24:43 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R861e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UMW2N.v_1611307426; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMW2N.v_1611307426) by smtp.aliyun-inc.com(127.0.0.1); Fri, 22 Jan 2021 17:23:56 +0800 From: Yang Li To: mchehab@kernel.org Cc: sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] scsi: megaraid_sas: remove redundant NULL check Date: Fri, 22 Jan 2021 17:23:44 +0800 Message-Id: <1611307424-109090-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./drivers/scsi/megaraid/megaraid_sas_fusion.c:3924:3-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index fd60728..38fc946 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -3920,8 +3920,7 @@ static irqreturn_t megasas_isr_fusion(int irq, void *devp) { unsigned int i; for (i = 0; i < instance->drv_buf_alloc; i++) { - if (instance->crash_buf[i]) - vfree(instance->crash_buf[i]); + vfree(instance->crash_buf[i]); } instance->drv_buf_index = 0; instance->drv_buf_alloc = 0; -- 1.8.3.1