Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp920736pxb; Fri, 22 Jan 2021 02:36:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJzmsw4He4NsX8dg32CX4041hEuaiKFE+wr7AE04idVgjTKMfAxGemlj6cUCvPpoQgMX4+M7 X-Received: by 2002:a17:906:a00a:: with SMTP id p10mr2630786ejy.312.1611311772937; Fri, 22 Jan 2021 02:36:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611311772; cv=none; d=google.com; s=arc-20160816; b=bBN7lYaSmnWoXUaFg49N/X85PTJj6UVX/QWnFklizs557On/gr2ZXOTCAPy/vh0aC6 gxrm7azGu/svZYlEimPew+JgkaJAj85fV45o1C3+IwmuYnFo/3t62kQBWnIiHG4TldN6 mjliCSfkU/FS1B7TtcaXZxY/BsXBFbogRW2Qsrd/0Y3IenKMu4FzhhknkMgaXgZT2iUv /ykPPB1gXeB9CB2lwln3lPVqFLUKGzLj+1XB2M1eLC/qGfneZtNXgZdhbXXBmQQVLB+f g5e9OE2Hk5gkPIg98fXZQMY+RP2mVFE1qFSndcSqmVRe7GUwMuZ2OgSTs/ePh0bc3VUn YTkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=saUZwi5UE0cvmE2w5FcMdr/GabhV3XAPlTb6nzYYMnI=; b=q5RVK+n8Kw1XE6CJcQHTzJr4TVt7RDmYPaXnUQ9xA47lrZlMu6t9gvXiM2lkldmM/K nU9ycry3WRNQ/TXpNIKt2TIQCmfVBbGXi8fCfJZwJ8dr/NeU1TExJs+5R+jHvdkbs+Zv LCKzj/UZl70BmW9AhH+p4Od9yd8xXQ5F3KunIOF74M20foVKFeDWU/OcGlNYMTkNedei TrnbpR7ndGDgS6u6gVrgSeFnS1h8Yo4KKWEvE4KUD003eGjTs00FT6C0/3+MRQ2thB+k IWgY7+eUtkRR4BH73Hs6bw2Bw3vwztmj6OrdpXr73bKEu7YZoOezrLfbwsD0SEbUGTaf dkbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gx11si2859154ejb.357.2021.01.22.02.35.48; Fri, 22 Jan 2021 02:36:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727992AbhAVKdU (ORCPT + 99 others); Fri, 22 Jan 2021 05:33:20 -0500 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:52826 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727557AbhAVJdX (ORCPT ); Fri, 22 Jan 2021 04:33:23 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0UMVZgVS_1611307935; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMVZgVS_1611307935) by smtp.aliyun-inc.com(127.0.0.1); Fri, 22 Jan 2021 17:32:19 +0800 From: Jiapeng Zhong To: roopa@nvidia.com Cc: nikolay@nvidia.com, davem@davemloft.net, kuba@kernel.org, natechancellor@gmail.com, ndesaulniers@google.com, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Jiapeng Zhong Subject: [PATCH] bridge: Use PTR_ERR_OR_ZERO instead if(IS_ERR(...)) + PTR_ERR Date: Fri, 22 Jan 2021 17:32:13 +0800 Message-Id: <1611307933-115887-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org coccicheck suggested using PTR_ERR_OR_ZERO() and looking at the code. Fix the following coccicheck warnings: ./net/bridge/br_multicast.c:1295:7-13: WARNING: PTR_ERR_OR_ZERO can be used. Reported-by: Abaci Signed-off-by: Jiapeng Zhong --- net/bridge/br_multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index 257ac4e..2229d10 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -1292,7 +1292,7 @@ static int br_multicast_add_group(struct net_bridge *br, pg = __br_multicast_add_group(br, port, group, src, filter_mode, igmpv2_mldv1, false); /* NULL is considered valid for host joined groups */ - err = IS_ERR(pg) ? PTR_ERR(pg) : 0; + err = PTR_ERR_OR_ZERO(pg); spin_unlock(&br->multicast_lock); return err; -- 1.8.3.1