Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp971455pxb; Fri, 22 Jan 2021 04:07:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJxegXGY5GPbGrZ04cx+reqysXOdulJAZHPM8YuHol1ZwS0WuKuWBhyrReVpjK04KMAWXsIr X-Received: by 2002:a17:907:94c8:: with SMTP id dn8mr2813057ejc.512.1611317269236; Fri, 22 Jan 2021 04:07:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611317269; cv=none; d=google.com; s=arc-20160816; b=hoy5fLWffMxsqtpMBG7qHWmeC9NZo53KGpq+vkUwP6px9j2qtzk4iwtdQzk3fUDYMp A/BLLUdJiTwO9Ftf2KyLyGqt+sumnhicg/b8qat2m/brgBSIXZ6u01VcHe37rtwl/jWv fJfnnCwmFFSQq3j/qo7g4sWouvpTtZqPetbVvrd0yF9glm6oJIThm1CDxiYYNR/nAqIg A4pmQWVtxAPwapTPVLLW8Z57GHqDPkmIbXloCasu/hHpKJjuYi7HFK/7zm0Cu+5Vu+Fs WYILS7MDO+OCsb1w8RSmbjSDRYgK3WDKeJBRMfoJFLQrqOX9vDGzeU9z992Af6QsguF5 lNcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=JXPYW0h7hiPfc3nFzv9PAN3QiBzbgs0DKqxJEEL+0Gk=; b=BcDkJuAZf7DFm/rFzgX/CtYInI5ddJCrpSSCqPP00EBlzuAOchIyNCfPAYZPYIDeRK K0W7AURBdVOsbMYsLwZad1BIrFaDtz9gRo+2B1YFllonpk8elfwvM05XYXFLVKVFwFr5 vtk1pZu+OmzNDL2N5w2fQXIAPBB9csd8n+r7/oGC37HDc07T+pxr9/J1gr9p+uoRgijP RcB5N8MMv4rrQffifSUvmfvNF6lv0V9PCWx/zDPrNFxKvMmN5OeBQ8hN6q/3TH7iblvu pf2MVT3ALcppxwBmE5vZHrWsT/rmzNpbf7V021mssk+qrYhGdEXR/RJc1ubdexeg3cYG bYMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f2si2927082ejz.310.2021.01.22.04.07.24; Fri, 22 Jan 2021 04:07:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727280AbhAVMGK (ORCPT + 99 others); Fri, 22 Jan 2021 07:06:10 -0500 Received: from elvis.franken.de ([193.175.24.41]:42485 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727822AbhAVKyi (ORCPT ); Fri, 22 Jan 2021 05:54:38 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1l2u4h-0006yq-01; Fri, 22 Jan 2021 11:53:55 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 4E4F5C0BF1; Fri, 22 Jan 2021 11:49:30 +0100 (CET) Date: Fri, 22 Jan 2021 11:49:30 +0100 From: Thomas Bogendoerfer To: Tiezhu Yang Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li , Ming Wang Subject: Re: [PATCH] MIPS: Make definitions of MIPSInst_FMA_{FUNC,FMTM} consistent with MIPS64 manual Message-ID: <20210122104930.GA8146@alpha.franken.de> References: <1611301998-25676-1-git-send-email-yangtiezhu@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1611301998-25676-1-git-send-email-yangtiezhu@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2021 at 03:53:18PM +0800, Tiezhu Yang wrote: > The kernel definitions of MIPSInst_FMA_FUNC and MIPSInst_FMA_FFMT are not > consistent with MADD.fmt, NMADD.fmt and NMSUB.fmt in the MIPS64 manual [1], > the field func is bit 5..3 and fmt is bit 2..0, fix them. Otherwise there > exists error when add new instruction simulation. > > [1] https://www.mips.com/?do-download=the-mips64-instruction-set-v6-06 > > Reported-by: Ming Wang > Signed-off-by: Tiezhu Yang > --- > arch/mips/include/asm/inst.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]