Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1081075pxb; Fri, 22 Jan 2021 06:47:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwfq7frVS/17iJCxLHJJu5cz22hrRLxXyJubx+hJUNCndtl7PykQWKIB0USISMr7csowH1/ X-Received: by 2002:a17:906:1a14:: with SMTP id i20mr3292244ejf.548.1611326872832; Fri, 22 Jan 2021 06:47:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611326872; cv=none; d=google.com; s=arc-20160816; b=aBf+PEkwr2O2sGRZ2W0swDSRjZ21+sNU6jz7BhC1XIsy8goq57amTdFIRZkAOTGLeh 2hugqqwlw/piNb32hlURkeZf8m52KGuUYwnET9fOGp/KWq5rnmKVogXJBWFyfr1vb4tZ +xYkX8F+W2mJ8KVCo5etUGjk/K+z62TnVTM3MxJTXngBHmNFNv4gEUO09bZGXgiowe2F oNxaFHXbwX95IDw6o0AULA0zNyj0RVtR/5JcrXIYZJqus/qszEEq6J+TRsXFAGSpOnfj PczWRWjGqKtI+OIpHtru+u/tuEp1KhAhhSouH7mls2caAOsgbWJiyP+j6k++InPenkyI 9ohw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Bd+5w6SAuwGnLG0gTCgFpVNxqx3XZTRIVpDSOCGH/q0=; b=AVZgzIjI78Eo88igHtMWnUMc6KZeqf0EU1Jr1IeVsaj4OWMU3qKlCQW6ufzNtq27tQ VIe1Vu4Kk8Qxv4UUoMKwcWtF6WAKpP/1yOvrqzE8BWh7an6u0n52GssjN4QXJhIiesIi zYm2uakuRP4ry9j0Ofep+ZW/tyLRyUtj4kgHBlbSH6rcLhCa9c/n5BzzpWMHQDQ9dg19 25SC1k10wW30JFBL1HFnU8rmqj4RQUCLiF1gM42elCrfxbk2lhImkB5SHVUOdYJ7tAnU Lo0jipdYXokKG1zMCjUlqfymMCdnLfgHGW8WPtM4CcLtdKdjY0HHKy8/8gqsuHhqAeZr uN2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=nXvgJ52B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cs9si2980513ejc.113.2021.01.22.06.47.28; Fri, 22 Jan 2021 06:47:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=nXvgJ52B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728920AbhAVOqH (ORCPT + 99 others); Fri, 22 Jan 2021 09:46:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728896AbhAVOpa (ORCPT ); Fri, 22 Jan 2021 09:45:30 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D93DC06174A for ; Fri, 22 Jan 2021 06:44:46 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id 3so6806663ljc.4 for ; Fri, 22 Jan 2021 06:44:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Bd+5w6SAuwGnLG0gTCgFpVNxqx3XZTRIVpDSOCGH/q0=; b=nXvgJ52BBj6b9k532t+afc8Iyug6kE2ObVcilm8DvdyuMNvrrFbC/Dt7hS9hdv68BG kuw8yCaMhMoNm+n4ykn41OkNnKQKO4pBywYk/1E/Xgs1Nn0hXfTMaNLRInaEbAdtKiSX SqPbbrtoayO5sKer7pb/HdZCz0NaBPABXDTmKwm2T41OJ9XqQWmm+t2Ft60T8JpcCgWp GIBNR+IR42eex+xw1ehjt/PhtafqBZslwuPrNAUUCdCb5FjnqBSMKYOhb+RmgjmbqKLO kJ8xlqJEP+c6ViVG/Fsb9G7DbgRqpKW/lMI/8XXpAoTvZxE94uf5dTzyBxyhYjREXKJn E0Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bd+5w6SAuwGnLG0gTCgFpVNxqx3XZTRIVpDSOCGH/q0=; b=QSfqNoD8ttlI3s9CeCo4GXKJfqJAjYynbjK43FA1EQ9MATgXBEUe9U17qKa04c5iJp Q6q6MOsNZDzP7zUz56nIz0crszaSB1bQAwjL5flHg/RR7yUEkDe0tseg1S9QqxUaXd2b UhmGSLnjBsEq8sEtZFyvPuq4VmHqxuYlDCMolJ1IG00OEdXyLhnCwb1PdtLrqr0nXORN odjJuC6WwV+7mks8TCoyvPoODygxv6opXGA2HnJIIma9hUf5eWMEDrDfK0mfEVg96f6x aGo7C3yJo88JaMB8+fNACQKLkZocYKbX67d5CuJqIKwqWPsImhPsk/nw1iUgKsm5Ngvu EGwQ== X-Gm-Message-State: AOAM530+7XVWYPr0Lk4mOC7T38GkavINhj6RzC0gY4FIsb7q2SAQDBcK Z5kR/KNiyDvQrychlJREG9B6JjMMxyWtJ6CbFilUYA== X-Received: by 2002:a2e:780d:: with SMTP id t13mr2491937ljc.144.1611326684827; Fri, 22 Jan 2021 06:44:44 -0800 (PST) MIME-Version: 1.0 References: <20210119181945.2071053-1-paullawrence@google.com> In-Reply-To: From: Paul Lawrence Date: Fri, 22 Jan 2021 06:44:33 -0800 Message-ID: Subject: Re: [PATCH] um: ubd: Fix crash from option parsing To: Hajime Tazaki Cc: jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, krisman@collabora.com, chris.obbard@collabora.com, linux-um@lists.infradead.org, Linux kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This was addressed/fixed by the below patch, though that one doesn't > the first "file" variable check. I don't believe the first file variable can in fact be NULL, so my check was unnecessary. Pleased to see this has been fixed, we can abandon my patch now. Paul