Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbWIOQac (ORCPT ); Fri, 15 Sep 2006 12:30:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751684AbWIOQab (ORCPT ); Fri, 15 Sep 2006 12:30:31 -0400 Received: from mail.gmx.net ([213.165.64.20]:1942 "HELO mail.gmx.net") by vger.kernel.org with SMTP id S1751678AbWIOQaa (ORCPT ); Fri, 15 Sep 2006 12:30:30 -0400 X-Authenticated: #5039886 Date: Fri, 15 Sep 2006 18:30:27 +0200 From: =?iso-8859-1?Q?Bj=F6rn?= Steinbrink To: Rohit Seth Cc: Andrew Morton , devel@openvz.org, CKRM-Tech , linux-kernel Subject: Re: [Patch03/05]- Containers: Initialization and Configfs interface Message-ID: <20060915163027.GA5285@atjola.homenet> Mail-Followup-To: =?iso-8859-1?Q?Bj=F6rn?= Steinbrink , Rohit Seth , Andrew Morton , devel@openvz.org, CKRM-Tech , linux-kernel References: <1158284486.5408.154.camel@galaxy.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1158284486.5408.154.camel@galaxy.corp.google.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 927 Lines: 31 On 2006.09.14 18:41:26 -0700, Rohit Seth wrote: > +static int __init configfs_container_init(void) > +{ > + int ret; > + > + config_group_init(&containerfs_group.cs_subsys.su_group); > + init_MUTEX(&containerfs_group.cs_subsys.su_sem); > + ret = configfs_register_subsystem(&containerfs_group.cs_subsys); > + > + if (ret) > + printk(KERN_ERR "Error %d while registering container subsystem\n", ret); > + else { > + container_wq = create_workqueue("Kcontainerd"); > + if (container_wq == NULL) { > + ret = -ENOMEM; > + printk(KERN_ERR "Unable to create Container controllers"); Shouldn't the subsystem be unregistered here? > + } > + } > + return ret; > +} Regards, Bj?rn - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/