Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1215036pxb; Fri, 22 Jan 2021 09:43:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJxUOeBh0jD+l3s7Ht+9+SGvWaH0UIFwPiY9HshAY2Q5DtUt0zUdTNSeJWVac/tCo2fo2RJs X-Received: by 2002:a50:9ee9:: with SMTP id a96mr4033394edf.343.1611337429436; Fri, 22 Jan 2021 09:43:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611337429; cv=none; d=google.com; s=arc-20160816; b=y2Rufxlca3ivFEwcl2ngfIzsWpna2kDUx0BgqpjlCkR2B/p8LQov1OanfgyHSkWht7 wLsGygNTnXWPZB9sFEyPA3rLF9bE8fInZ3hwvHYvuefOybOholBC6VvU1jJTo1XWEQoW lKdmMRx8u7JKNZlZCpm5HV8Ve5m2ZJkgeRTSe+TxElpX45lkGxM2r/spLhliJyXR18fX PqJHHljdtNeALZx3Q97sdsbyutvR3zXuhu9ZbihXF76watGQg8pmRRNmcqq6qQF47C6D V4bX4FDY9EcgaV+MbuO1tmgRO2azwg89NEmQoF4OjtXuhsUfJy1RQsmp4v7dWHBmDidq r5Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ZN5j6KfK8wmk+g4KqlPHGIbHqsqIB/EEbLwT9Van5qc=; b=xA0ztoqKraw1cPjvfYqsA0/8fOa649rCdIaqtwKBkVQ8PCu8unHWz6h2iTIt0n6MY0 KHj6ZT8ZXaeAEtgXU+a4dvYmUIVJ/9zoTQ1srHlQjdSYPs5P9IT4spqK6pQpo36k5bUf gdpwA6rww1WqrchUtNO9O12dTv3a4z/3Sv5bHWLHQduQPmBIidIGVbR/tQUu6y3aRebx 5W6lVb5lVRSox9Tw9qZ9pBs5PBHgcTX3uQL6imxTp2PDyPq3/avDx3uBwasmyE9HVY/z SswpKrRlNM5sPyZBhnsWjQClaE+SdPrm8zdgmpfr2Pd2gLUWpUtn+7nHsVgsPQkY+YF7 /FfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RuJ+Df5l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si3902947edy.156.2021.01.22.09.43.24; Fri, 22 Jan 2021 09:43:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RuJ+Df5l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728667AbhAVRlm (ORCPT + 99 others); Fri, 22 Jan 2021 12:41:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:51218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729850AbhAVReC (ORCPT ); Fri, 22 Jan 2021 12:34:02 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7E19B23A79; Fri, 22 Jan 2021 17:33:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611336801; bh=Zz7/sBdhG8IGiogtBKk0mTY8NegdDfBFJuOqnDNcMLA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RuJ+Df5lfmrPNDJ51PkcEYxRr+jpqXQweQhIQPESSUJFK0m1FLcTJcs5Q7UA7sZnF XK3A8YbaQIIAYHnH3igiGNR77G9IqJFjs1mARPv4qLPjSPXGN0QolPVyxGJ9WEv/u8 Y/d9zwQtM+OKDg0GvUpb52T12cai/I+pyL/1NLce+tvUsGWlHPv+pPWCFpbhhgjqFO CAfQgtPaeed/fEFusGweDk+j3JPGtmdm5Vma2BXVOFOV0KOg+EZDAu3aDH14bf9Lqz zBMx1SGbfXMLA13aAyZqRImtyFqsubrdcHxpfC3+eBRet3kWN+UrTzHxNAzq14f1cD MpQYrozyRdepQ== Date: Fri, 22 Jan 2021 09:33:20 -0800 From: Jakub Kicinski To: Jiapeng Zhong Cc: roopa@nvidia.com, nikolay@nvidia.com, davem@davemloft.net, natechancellor@gmail.com, ndesaulniers@google.com, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] bridge: Use PTR_ERR_OR_ZERO instead if(IS_ERR(...)) + PTR_ERR Message-ID: <20210122093320.6fbb5f11@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1611307933-115887-1-git-send-email-abaci-bugfix@linux.alibaba.com> References: <1611307933-115887-1-git-send-email-abaci-bugfix@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Jan 2021 17:32:13 +0800 Jiapeng Zhong wrote: > coccicheck suggested using PTR_ERR_OR_ZERO() and looking at the code. > > Fix the following coccicheck warnings: > > ./net/bridge/br_multicast.c:1295:7-13: WARNING: PTR_ERR_OR_ZERO can be > used. > > Reported-by: Abaci > Signed-off-by: Jiapeng Zhong You need to CC netdev