Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 22 Jan 2021 09:50:06 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Ronak Doshi <doshir@vmware.com>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Petr Vandrovec <petr@vmware.com>,
        Pv-drivers <Pv-drivers@vmware.com>,
        "David S. Miller" <davem@davemloft.net>,
        open list <linux-kernel@vger.kernel.org>,
        Joe Perches <joe@perches.com>
Subject: Re: [PATCH net-next] vmxnet3: Remove buf_info from device
 accessible structures
Message-ID: <20210122095006.58d258aa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <888F37FB-B8BD-43D8-9E75-4F1CE9D4FAC7@vmware.com>
References: <20210120021941.9655-1-doshir@vmware.com>
        <20210121170705.08ecb23d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <888F37FB-B8BD-43D8-9E75-4F1CE9D4FAC7@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 22 Jan 2021 08:24:59 +0000 Ronak Doshi wrote:
> On 1/21/21, 5:07 PM, "Jakub Kicinski" <kuba@kernel.org> wrote:
> >  On Tue, 19 Jan 2021 18:19:40 -0800 Ronak Doshi wrote:  
> > > +	tq->buf_info = kmalloc_array_node(tq->tx_ring.size, sizeof(tq->buf_info[0]),
> > > +					  GFP_KERNEL | __GFP_ZERO,
> > > +					  dev_to_node(&adapter->pdev->dev));  
> > > +	if (!tq->buf_info) {
> > > +		netdev_err(adapter->netdev, "failed to allocate tx buffer info\n")  
> >
> > Please drop the message, OOM splat will be visible enough. checkpatch
> > usually points this out  
> 
> Okay, will drop it. Checkpatch did not complain about the error message though.

Looks like it matches alloc_node or alloc_array, but not
alloc_array_node ?

our $allocFunctions = qr{(?x:
	(?:(?:devm_)?
		(?:kv|k|v)[czm]alloc(?:_node|_array)? |


CCing Joe in case he thinks it's worth fixing