Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1291368pxb; Fri, 22 Jan 2021 11:41:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwPfycUjLi0iOThg2fvJIky+KfPdhqiPC9GeiqAfJ2j45feFDfKomclgiVSm55gxNWvpAnn X-Received: by 2002:a05:6402:45:: with SMTP id f5mr4412438edu.273.1611344367133; Fri, 22 Jan 2021 11:39:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611344367; cv=none; d=google.com; s=arc-20160816; b=UmoxboB/NO7UoIBMN2Xb1E8gNaMbpuqLTaOqkAQSCfjAuxS4rHlCPhQZeKiOqZtVK+ PDb6J4qykjOlNXBIUwOQHLhsDg0/xURtmWsAwyO24Q6fsejZDH7AdtMOX6rzsWJFH9bG 7yFYbWATiQHA72b/3Od5Hoz52KUoI1IQ/DdzjvMEz83Evh6b1ihzWB3QzZwDYcSJZlg5 O1lkHxVuD8o0lA66osBy+Y9lj7PBTdVHX+gcLJOhfSs8KcmB13zsEz+i5SW/5p8qZjGP M6xVATPDhmKUdCfFV3wkC/iTJKiHshn4J+oAyFlAOQrRtLYlblkrBl4tHSAXuZQnkBMJ qf0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=GFbt9Q9FleVVeCUdG8Si9d40jYAPeifwLGkQip6/tp8=; b=MiaHDsdzGHGzWvy5ZeBsfIzBLfkpEORvsWALBFAMRHUFUqTvognRBIn1kKbsgCpZZv xRx0fj+OuMob77V8fWJ9vxivABudi/qBG3MAAWtXHwvl1ykUR3MXBXgkj9CodZDd9lc3 E1ZpIV49olMcrIU857x/0H23O4HAuzJNQORvCjqu8PXIecexSniP9Nwi+sutY3UPKWQN L6o5/BlY9NJuE0ryfFDjOogXHtIUEJLVds8bHGGHgACEyzX0yuqmsSmT0qniICnvbC9M iwapfuCcgJT2zdN469eCIxW+Q50tYUYBdx5pIOYiP/zETAAV59Ss6oFYX4eY3hWQFkBr 9Hmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bwkqMmtP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q15si4126968edr.397.2021.01.22.11.39.01; Fri, 22 Jan 2021 11:39:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bwkqMmtP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730181AbhAVTYf (ORCPT + 99 others); Fri, 22 Jan 2021 14:24:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730712AbhAVTE6 (ORCPT ); Fri, 22 Jan 2021 14:04:58 -0500 Received: from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com [IPv6:2607:f8b0:4864:20::e2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFCEFC061786 for ; Fri, 22 Jan 2021 11:04:17 -0800 (PST) Received: by mail-vs1-xe2f.google.com with SMTP id e15so3609116vsa.0 for ; Fri, 22 Jan 2021 11:04:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GFbt9Q9FleVVeCUdG8Si9d40jYAPeifwLGkQip6/tp8=; b=bwkqMmtPpa0+udzg9ETiNx73TRyndCyCrlakaQuOQthA2L6u5Glut8WN0ctvVCZioq TVN/8anvwUYb7z5zcqkACTfECL8PLOxixSmHvOdoNmLOsMQETDnhQVmXgRcPUJ/VS9Lj 3wI8/WchMgWlIT0ZTvUgWaLO3iyoiSVdUeeYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GFbt9Q9FleVVeCUdG8Si9d40jYAPeifwLGkQip6/tp8=; b=bQ5N8tLX4Z4+eNt+GGkN76JcxUtIu3YJeDLH1HudBAM3ogAkPbG3UMyXyayUoDpwk1 eD663GUflgl7dKLvOsHs+NuW/GTMxeK1E8kqV2F1652dc5FU9YaJ8ACKWH8DMkjlHtfd fJv4n3eaqkzQcxm4Tmue+787BSM0hIdrQ1HDZy3JyjJ9iVPe8DfIgv23PyYZaOxeuILO OoCvBqazKA9saIumVPcBezilrd3IIFvPieZ9Xd3+1RyvNH8XXpt//yvTz446PY5/4NCN 0qRk17ouLpd5O4+j0Xc0JzqvBYRug/KEaBGNVJTGTEgULSlMeK3mKSKHLEONP5gQ4gpT ThWg== X-Gm-Message-State: AOAM530V5ZqXskHF2ltr02pvrirnUOgOmmkPMgRsZGtar6RY2vvUXMq0 3/9xSxaD0xjSLt4j/C9y2nh25NPxoYPgjw== X-Received: by 2002:a67:6943:: with SMTP id e64mr29995vsc.10.1611342256726; Fri, 22 Jan 2021 11:04:16 -0800 (PST) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com. [209.85.217.43]) by smtp.gmail.com with ESMTPSA id q197sm1329576vkq.53.2021.01.22.11.04.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jan 2021 11:04:15 -0800 (PST) Received: by mail-vs1-f43.google.com with SMTP id f22so3590608vsk.11 for ; Fri, 22 Jan 2021 11:04:14 -0800 (PST) X-Received: by 2002:a67:ed09:: with SMTP id l9mr237347vsp.4.1611342254067; Fri, 22 Jan 2021 11:04:14 -0800 (PST) MIME-Version: 1.0 References: <20201203202737.7c4wrifqafszyd5y@google.com> <20201208054646.2913063-1-maskray@google.com> In-Reply-To: From: Doug Anderson Date: Fri, 22 Jan 2021 11:04:02 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] firmware_loader: Align .builtin_fw to 8 To: Nick Desaulniers Cc: Andrew Morton , Fangrui Song , Arnd Bergmann , linux-arch , LKML , clang-built-linux , Nathan Chancellor , kernel test robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Jan 5, 2021 at 11:20 AM Nick Desaulniers wrote: > > On Tue, Jan 5, 2021 at 9:45 AM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Dec 7, 2020 at 9:49 PM Fangrui Song wrote: > > > > > > arm64 references the start address of .builtin_fw (__start_builtin_fw) > > > with a pair of R_AARCH64_ADR_PREL_PG_HI21/R_AARCH64_LDST64_ABS_LO12_NC > > > relocations. The compiler is allowed to emit the > > > R_AARCH64_LDST64_ABS_LO12_NC relocation because struct builtin_fw in > > > include/linux/firmware.h is 8-byte aligned. > > > > > > The R_AARCH64_LDST64_ABS_LO12_NC relocation requires the address to be a > > > multiple of 8, which may not be the case if .builtin_fw is empty. > > > Unconditionally align .builtin_fw to fix the linker error. 32-bit > > > architectures could use ALIGN(4) but that would add unnecessary > > > complexity, so just use ALIGN(8). > > > > > > Fixes: 5658c76 ("firmware: allow firmware files to be built into kernel image") > > > Link: https://github.com/ClangBuiltLinux/linux/issues/1204 > > > Reported-by: kernel test robot > > > Signed-off-by: Fangrui Song > > > Acked-by: Arnd Bergmann > > > > > > --- > > > Change in v2: > > > * Use output section alignment instead of inappropriate ALIGN_FUNCTION() > > > --- > > > include/asm-generic/vmlinux.lds.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Tested-by: Douglas Anderson > > > > For whatever reason this is hitting developers on Chrome OS a whole > > lot suddenly. Any chance it could be landed? Which tree should it go > > through? > > Andrew, > Would you mind picking up this patch for us, please? > https://lore.kernel.org/lkml/20201208054646.2913063-1-maskray@google.com/ I just synced today and I'm still hitting this error when building mainline. Perhaps Andrew is busy and someone else can pick it up? It'd be nice to get this into v5.11 -Doug