Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Yang Li <abaci-bugfix@linux.alibaba.com>
CC:     "martin.petersen@oracle.c" <martin.petersen@oracle.c>,
        Martin Petersen <martin.petersen@oracle.com>,
        "njavali@marvell.com" <njavali@marvell.com>,
        "GR-QLogic-Storage-Upstream@marvell.com" 
        <GR-QLogic-Storage-Upstream@marvell.com>,
        "mrangankar@marvell.com" <mrangankar@marvell.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] scsi: qla2xxx: remove redundant NULL check
Thread-Topic: [PATCH 1/2] scsi: qla2xxx: remove redundant NULL check
Thread-Index: AQHW8KJy5TzZ1D8KyEueth5b35ly36oz+eKA
Date:   Fri, 22 Jan 2021 18:37:04 +0000
Message-ID: <984381A1-692A-42DB-818B-0A0ACAF57D10@oracle.com>
References: <1611306174-92627-1-git-send-email-abaci-bugfix@linux.alibaba.com>
In-Reply-To: <1611306174-92627-1-git-send-email-abaci-bugfix@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E370B735ECD4A74A95F96560AF53C580@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f524e6c3-8437-480f-04f7-08d8bf04b6d8
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2021 18:37:04.0210
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GgetlFxorEjoZYL+bci8RCETzrlO8JYpuMy+Vu+tqoAItM4cHxTKbVOoN43t48UAFStpK+3olWwKxoZQfen/ujsmd8lALJKYX9S6CL8xhHQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4537
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9872 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 suspectscore=0 phishscore=0 adultscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101220095
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9872 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 impostorscore=0 mlxscore=0 priorityscore=1501 phishscore=0 mlxlogscore=999
 lowpriorityscore=0 malwarescore=0 adultscore=0 clxscore=1011 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101220095
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 22, 2021, at 3:02 AM, Yang Li <abaci-bugfix@linux.alibaba.com> wro=
te:
>=20
> Fix below warnings reported by coccicheck:
> ./drivers/scsi/qla2xxx/qla_init.c:3371:2-7: WARNING: NULL check before
> some freeing functions is not needed.
> ./drivers/scsi/qla2xxx/qla_init.c:7855:5-10: WARNING: NULL check before
> some freeing functions is not needed.
> ./drivers/scsi/qla2xxx/qla_init.c:7916:2-7: WARNING: NULL check before
> some freeing functions is not needed.
> ./drivers/scsi/qla2xxx/qla_init.c:8113:4-18: WARNING: NULL check before
> some freeing functions is not needed.
> ./drivers/scsi/qla2xxx/qla_init.c:8174:2-7: WARNING: NULL check before
> some freeing functions is not needed.
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
> ---
> drivers/scsi/qla2xxx/qla_init.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_i=
nit.c
> index dcc0f0d8..edd5dd1 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -3371,8 +3371,7 @@ static void qla2x00_tmf_sp_done(srb_t *sp, int res)
> 				    "Re-Allocated (%d KB) and save firmware dump.\n",
> 				    dump_size / 1024);
> 			} else {
> -				if (ha->fw_dump)
> -					vfree(ha->fw_dump);
> +				vfree(ha->fw_dump);
> 				ha->fw_dump =3D fw_dump;
>=20
> 				ha->fw_dump_len =3D ha->fw_dump_alloc_len =3D
> @@ -7855,8 +7854,7 @@ bool qla24xx_risc_firmware_invalid(uint32_t *dword)
> 	templates =3D (risc_attr & BIT_9) ? 2 : 1;
> 	ql_dbg(ql_dbg_init, vha, 0x0160, "-> templates =3D %u\n", templates);
> 	for (j =3D 0; j < templates; j++, fwdt++) {
> -		if (fwdt->template)
> -			vfree(fwdt->template);
> +		vfree(fwdt->template);
> 		fwdt->template =3D NULL;
> 		fwdt->length =3D 0;
>=20
> @@ -7916,8 +7914,7 @@ bool qla24xx_risc_firmware_invalid(uint32_t *dword)
> 	return QLA_SUCCESS;
>=20
> failed:
> -	if (fwdt->template)
> -		vfree(fwdt->template);
> +	vfree(fwdt->template);
> 	fwdt->template =3D NULL;
> 	fwdt->length =3D 0;
>=20
> @@ -8113,8 +8110,7 @@ bool qla24xx_risc_firmware_invalid(uint32_t *dword)
> 	templates =3D (risc_attr & BIT_9) ? 2 : 1;
> 	ql_dbg(ql_dbg_init, vha, 0x0170, "-> templates =3D %u\n", templates);
> 	for (j =3D 0; j < templates; j++, fwdt++) {
> -		if (fwdt->template)
> -			vfree(fwdt->template);
> +		vfree(fwdt->template);
> 		fwdt->template =3D NULL;
> 		fwdt->length =3D 0;
>=20
> @@ -8174,8 +8170,7 @@ bool qla24xx_risc_firmware_invalid(uint32_t *dword)
> 	return QLA_SUCCESS;
>=20
> failed:
> -	if (fwdt->template)
> -		vfree(fwdt->template);
> +	vfree(fwdt->template);
> 	fwdt->template =3D NULL;
> 	fwdt->length =3D 0;
>=20
> --=20
> 1.8.3.1
>=20

Make Sense.=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering