Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-PHdr: =?us-ascii?q?9a23=3AM/Zh5RR8y1r+A0NfAZ+t4dL0zdpsv++ubAcI9p?=
 =?us-ascii?q?oqja5Pea2//pPkeVbS/uhpkESQBNuJ+/NAiuzG9avnXD9I7ZWAtSUEd5pBH1?=
 =?us-ascii?q?8AhN4NlgMtSMiCFQXgLfHsYiB7eaYKVFJs83yhd0QAHsH4ag7Co3mz6y5UER?=
 =?us-ascii?q?L6ZkJ5I+3vEdvUiMK6n+m555zUZVBOgzywKbN/JRm7t0PfrM4T1IBjMa02jB?=
 =?us-ascii?q?DOpyhF?=
From:   "Daniel Walker (danielwa)" <danielwa@cisco.com>
To:     Michal Simek <michal.simek@xilinx.com>
CC:     Daniel Walker <dwalker@fifo99.com>,
        "xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
        Rob Herring <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: boot: dts: add new dts for hellcat & petra
Thread-Topic: [PATCH 1/2] arm64: boot: dts: add new dts for hellcat & petra
Thread-Index: AQHW8P27mGDl3zHar0GeD3nuSvVt0w==
Date:   Fri, 22 Jan 2021 20:32:41 +0000
Message-ID: <20210122203240.GS3710@zorba>
References: <20210121231237.30664-1-danielwa@cisco.com>
 <185100f4-67f1-140b-ad01-9997891e68da@xilinx.com>
In-Reply-To: <185100f4-67f1-140b-ad01-9997891e68da@xilinx.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
user-agent: Mutt/1.9.4 (2018-02-28)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5B214B43DCF8D64D8D385437719CD234@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 43ace85b-9ed4-41ec-f5ca-08d8bf14ddeb
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2021 20:32:41.5140
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nSKK+cV7ETy19fqPdV2bRPEprflhkZANv0TRnH5ezBTi5q/F0Oig6qyG2leasKs4D0CvNBj4Uo2zN+NvWqgi9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3861
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.11, xch-aln-001.cisco.com
X-Outbound-Node: alln-core-6.cisco.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 22, 2021 at 09:48:53AM +0100, Michal Simek wrote:
> Hi Daniel,
>=20
> On 1/22/21 12:12 AM, Daniel Walker wrote:
> > Add Petra and Hellcat dts file. These platforms are based on
> > the Xilinx Zynqmp platform.
> >=20
> > Signed-off-by: Daniel Walker <dwalker@fifo99.com>
> > Cc: xe-linux-external@cisco.com
> > ---
> >  arch/arm64/boot/dts/xilinx/Makefile           |   2 +
> >  .../boot/dts/xilinx/zynqmp-petra-hellcat.dts  | 856 ++++++++++++++++++
> >  arch/arm64/boot/dts/xilinx/zynqmp-petra.dts   | 847 +++++++++++++++++
> >  3 files changed, 1705 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-petra-hellcat.dts
> >  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-petra.dts
>=20
> First of all I can't see 2/2.
=20
It wasn't being submitted to you. But here it is if you care to look at it.

https://lkml.org/lkml/2021/1/21/1468

>=20
> Long time ago we said that we are not going to push any PL related
> configurations. It means all below can't be merged.
> And there are also coding style issues.

You'll need to explain this more. It's likely this was added at the suggest=
ion of
Xilinx. If it can't be upstreamed what should we replace it with ?

I will review your other comments and re-submit.

Daniel=