Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices
To:     Sergej Bauer <sbauer@blackbox.su>, netdev@vger.kernel.org
Cc:     andrew@lunn.ch, "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Bryan Whitehead <bryan.whitehead@microchip.com>,
        UNGLinuxDriver@microchip.com,
        Simon Horman <simon.horman@netronome.com>,
        Mark Einon <mark.einon@gmail.com>,
        Madalin Bucur <madalin.bucur@oss.nxp.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Masahiro Yamada <masahiroy@kernel.org>,
        linux-kernel@vger.kernel.org
References: <20210122214247.6536-1-sbauer@blackbox.su>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <ecc54ce2-cbda-d801-1127-e1c15aa22654@gmail.com>
Date:   Fri, 22 Jan 2021 13:52:48 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <20210122214247.6536-1-sbauer@blackbox.su>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/22/2021 1:42 PM, Sergej Bauer wrote:
> From: sbauer@blackbox.su
> 
> v1->v2:
> 	switch to using of fixed_phy as was suggested by Andrew and Florian
> 	also features-related parts are removed
> 
> Previous versions can be found at:
> v1:
> initial version
> 	https://lkml.org/lkml/2020/9/17/1272
> 
> Signed-off-by: Sergej Bauer <sbauer@blackbox.su>

You are not explaining why you need this and why you are second guessing
the fixed PHY MII emulation that already exists. You really need to do a
better job at describing your changes and why the emulation offered by
swphy.c is not enough for your use case.
-- 
Florian