Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices
To:     Sergej Bauer <sbauer@blackbox.su>
Cc:     Andrew Lunn <andrew@lunn.ch>, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Bryan Whitehead <bryan.whitehead@microchip.com>,
        UNGLinuxDriver@microchip.com,
        Simon Horman <simon.horman@netronome.com>,
        Mark Einon <mark.einon@gmail.com>,
        Madalin Bucur <madalin.bucur@oss.nxp.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Masahiro Yamada <masahiroy@kernel.org>,
        linux-kernel@vger.kernel.org
References: <20210122214247.6536-1-sbauer@blackbox.su>
 <3174210.ndmClRx9B8@metabook>
 <5306ffe6-112c-83c9-826a-9bacd661691b@gmail.com>
 <4496952.bab7Homqhv@metabook>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <cce7fdd0-2b75-26f5-ce25-ca8803ffccc5@gmail.com>
Date:   Fri, 22 Jan 2021 17:39:47 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <4496952.bab7Homqhv@metabook>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 1/22/2021 5:01 PM, Sergej Bauer wrote:
> On Saturday, January 23, 2021 3:01:47 AM MSK Florian Fainelli wrote:
>> On 1/22/2021 3:58 PM, Sergej Bauer wrote:
>>> On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote:
>>>>>>> @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct
>>>>>>> lan743x_adapter *adapter)>
>>>>>>>
>>>>>>>  	struct net_device *netdev = adapter->netdev;
>>>>>>>  	
>>>>>>>  	phy_stop(netdev->phydev);
>>>>>>>
>>>>>>> -	phy_disconnect(netdev->phydev);
>>>>>>> -	netdev->phydev = NULL;
>>>>>>> +	if (phy_is_pseudo_fixed_link(netdev->phydev))
>>>>>>> +		lan743x_virtual_phy_disconnect(netdev->phydev);
>>>>>>> +	else
>>>>>>> +		phy_disconnect(netdev->phydev);
>>>>>>
>>>>>> phy_disconnect() should work. You might want to call
>>>>
>>>> There are drivers which call phy_disconnect() on a fixed_link. e.g.
>>>>
>>>> https://elixir.bootlin.com/linux/v5.11-rc4/source/drivers/net/usb/lan78xx
>>>> .c# L3555.
>>>>
>>>>
>>>> It could be your missing call to fixed_phy_unregister() is leaving
>>>> behind bad state.
>>>
>>> lan743x_virtual_phy_disconnect removes sysfs-links and calls
>>> fixed_phy_unregister()
>>> and the reason was phydev in sysfs.
>>>
>>>>> It was to make ethtool show full set of supported speeds and MII only in
>>>>> supported ports (without TP and the no any ports in the bare card).
>>>>
>>>> But fixed link does not support the full set of speed. It is fixed. It
>>>> supports only one speed it is configured with.
>>>
>>> That's why I "re-implemented the fixed PHY driver" as Florian said.
>>> The goal of virtual phy was to make an illusion of real device working in
>>> loopback mode. So I could use ethtool and ioctl's to switch speed of
>>> device.> 
>>>> And by setting it
>>>> wrongly, you are going to allow the user to do odd things, like use
>>>> ethtool force the link speed to a speed which is not actually
>>>> supported.
>>>
>>> I have lan743x only and in loopback mode it allows to use speeds
>>> 10/100/1000MBps
>>> in full-duplex mode only. But the highest speed I have achived was
>>> something near
>>> 752Mbps...
>>> And I can switch speed on the fly, without reloading the module.
>>>
>>> May by I should limit the list of acceptable devices?
>>
>> It is not clear what your use case is so maybe start with explaining it
>> and we can help you define something that may be acceptable for upstream
>> inclusion.
> it migth be helpful for developers work on userspace networking tools with
> PHY-less lan743x (the interface even could not be brought up)
> of course, there nothing much to do without TP port but the difference is
> representative.

You are still not explaining why fixed PHY is not a suitable emulation
and what is different, providing the output of ethtool does not tell me
how you are using it.

Literally everyone using Ethernet switches or MAC to MAC Ethernet
connections uses fixed PHY and is reasonably happy with it.
-- 
Florian