Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/4] ubifs: Correctly set inode size in ubifs_link()
To:     Richard Weinberger <richard@nod.at>,
        <linux-mtd@lists.infradead.org>
CC:     <david@sigma-star.at>, <linux-kernel@vger.kernel.org>,
        <stable@vger.kernel.org>
References: <20210122212229.17072-1-richard@nod.at>
 <20210122212229.17072-2-richard@nod.at>
From:   Zhihao Cheng <chengzhihao1@huawei.com>
Message-ID: <91b23161-db4a-4d64-db30-e42e2eaade1e@huawei.com>
Date:   Sat, 23 Jan 2021 10:35:56 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20210122212229.17072-2-richard@nod.at>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

?? 2021/1/23 5:22, Richard Weinberger д??:
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
> index 9a6b8660425a..04912dedca48 100644
> --- a/fs/ubifs/dir.c
> +++ b/fs/ubifs/dir.c
> @@ -693,7 +693,7 @@ static int ubifs_link(struct dentry *old_dentry, struct inode *dir,
>   	struct inode *inode = d_inode(old_dentry);
>   	struct ubifs_inode *ui = ubifs_inode(inode);
>   	struct ubifs_inode *dir_ui = ubifs_inode(dir);
> -	int err, sz_change = CALC_DENT_SIZE(dentry->d_name.len);
> +	int err, sz_change;
>   	struct ubifs_budget_req req = { .new_dent = 1, .dirtied_ino = 2,
>   				.dirtied_ino_d = ALIGN(ui->data_len, 8) };
>   	struct fscrypt_name nm;
> @@ -731,6 +731,8 @@ static int ubifs_link(struct dentry *old_dentry, struct inode *dir,
>   	if (inode->i_nlink == 0)
>   		ubifs_delete_orphan(c, inode->i_ino);
>   
> +	sz_change = CALC_DENT_SIZE(fname_len(&nm));
> +
>   	inc_nlink(inode);
>   	ihold(inode);
>   	inode->i_ctime = current_time(inode);
>