Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Bean Huo <huobean@gmail.com>
Cc:     alim.akhtar@samsung.com, avri.altman@wdc.com,
        asutoshd@codeaurora.org, jejb@linux.ibm.com,
        martin.petersen@oracle.com, stanley.chu@mediatek.com,
        beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
        cang@codeaurora.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: Cleanup WB buffer flush toggle implementation
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1sg6s9wrw.fsf@ca-mkp.ca.oracle.com>
References: <20210121185736.12471-1-huobean@gmail.com>
Date:   Fri, 22 Jan 2021 22:07:33 -0500
In-Reply-To: <20210121185736.12471-1-huobean@gmail.com> (Bean Huo's message of
        "Thu, 21 Jan 2021 19:57:36 +0100")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.ca.oracle.com (138.3.200.58) by BY5PR03CA0008.namprd03.prod.outlook.com (2603:10b6:a03:1e0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12 via Frontend Transport; Sat, 23 Jan 2021 03:07:35 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eab6c7a8-aeeb-40f5-321c-08d8bf4c08de
X-MS-TrafficTypeDiagnostic: PH0PR10MB4776:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB4776D1E022E47B6ACD53F6D48EBF9@PH0PR10MB4776.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1C72rUnYPmTiWBn1HX4WCimy89qete5JuhN2gmSE+x/fRLcls8ZDY/K9q95IAtzGScXWCgW1iw/XFPKollDJRO8O5AR89SBQityhvaAGAbIlEqrtc/q0mGlr73hEjke/t+60DOCpyNxaWofANxbb3k7eNwUPjgCrTZthpgstHevW8mEn64JqvRPuKS0P/4i/7eWjENvKtwJcBCUZvhIQPXvMWWAbsqxDrXisElfQLJBQN0BwQLkmzcldpb5BuqoM74/EUGpIGzpk3C4WpsPRb475XY099rffPvwmtnndc33bdNmAzwRQ/aWADm9IRRtZnXD6zSd6DI9Gj3V/OglW+QzJZSngxZJ9XcZXfKCUUV2yz3Mp3oOxPzHETRdVTvV63kPNnGQnT/DlXO5Ua2f7Wg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(136003)(366004)(396003)(376002)(7416002)(8676002)(36916002)(66946007)(8936002)(86362001)(4326008)(478600001)(52116002)(558084003)(7696005)(2906002)(186003)(83380400001)(6916009)(66476007)(5660300002)(26005)(66556008)(16526019)(316002)(956004)(55016002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?a03EUfD/5blpWWW5zu/zNV5sIpBRgEB0JFuQjSp0ZQBTj4pZzBdkQwVKzNKV?=
 =?us-ascii?Q?KHRhwBzLLwrOzb81oEqVbah/KkwJADi9aiOAHkVSCdBG4DwdLfCVB0GhLBw2?=
 =?us-ascii?Q?85VenFkRP6MXjUBz5VLY3xgYBWF+LwWirESCA6LN2bUUIpY9sb7sHxAAwFh3?=
 =?us-ascii?Q?tMnjOkPSwA9IIC9ktd9MFLcg54iVlv7DsMrptG51RTCXTVvTe7ddgk427TJV?=
 =?us-ascii?Q?UXpWBOvnNxEdkkX3yVrmDlU5cYvtOPe9rXPff5N03u9cfNomcb8G/gZhsLSS?=
 =?us-ascii?Q?joHa9O4xdJ2wqGnREIIxfbchEfwkIiAvs2Y0pRM08sJXTzDkxGKUH1BhbMlz?=
 =?us-ascii?Q?1eZZLbOMV4HRcEYs/CLg5ZKOyw/TPKBYCrZEUpGkpv7QjowbnhPUVyfzh+ef?=
 =?us-ascii?Q?xtX294D2nTzc8faJGCE64E+BE0c5EhaYq3p7kTQH8H7vudUFOt+3jPfDqrUA?=
 =?us-ascii?Q?Rrn/5VMRnMS0kLMzWMvJ23RsrSV93n7pjpVzphQKGf0jYAgncZeitnBVyAjf?=
 =?us-ascii?Q?xwHFcUmv3OE76mcuN4Ypb8HhJ02O8huQilyVvuJhsX9ZEBF0BivuWu2CzVEN?=
 =?us-ascii?Q?1e4c/qQoi6sD5TXF8R4BWjcrO/dRAL+kpLE0AQxQ4U/yz0lSNWD48G3bHjhk?=
 =?us-ascii?Q?YOMCRYFS1dGpY53tFsF34NtmICNzdLrdJhq+oLsFItcUfXGuYsAJmjSKbokF?=
 =?us-ascii?Q?/XujQjOaFBwWuRlRYYbGx7HbnamzfzmCW3j4VG2/C6Pxu7lDHe08lgYet0rT?=
 =?us-ascii?Q?ReeK2QhGyK1u2jT4VhuwaRTB2A1XPaFAIaybfb9rx1CHLBLWjCuv0x2b4GUM?=
 =?us-ascii?Q?rhH7zleyKnhlboAfYXuTF/VrXvtKCgQchZ/42c7vrt54mSBfkzAM8FtAqeTM?=
 =?us-ascii?Q?1M2vlA4eVBIguX8OEjxD/hUMKfI3u3Sp1SCMld+ePXc73ct4jBURiVWzUitF?=
 =?us-ascii?Q?lCNLJhDTeyvOcbVb+JSAZbrC77F2L2KeU9noOpWrR2kR8I6NrHEJ9JjbNzkz?=
 =?us-ascii?Q?XIcNGitLGprVHAQRsGNc5hv+kfby4IhbBRIWhLlihOSEdLMQE9ps5r5cS81R?=
 =?us-ascii?Q?EyhKKwk+?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eab6c7a8-aeeb-40f5-321c-08d8bf4c08de
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2021 03:07:36.1010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hu31ulhF44NDLGHnSVx7EwWci4XaeWrOg655aEPpXhjcluoPv42QTBc1yKdf+HDllOzMtlxF5gn7IHTmoCXbH8Ne0eLEg6NGd3KvzAMtqPs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4776
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9872 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 malwarescore=0
 bulkscore=0 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101230017
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9872 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 phishscore=0
 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0
 priorityscore=1501 mlxscore=0 clxscore=1015 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101230017
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Bean,

> Delete ufshcd_wb_buf_flush_enable() and ufshcd_wb_buf_flush_disable(),
> move the implementation into ufshcd_wb_toggle_flush().

Applied to 5.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering