Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     "Ewan D. Milne" <emilne@redhat.com>
Cc:     Martin Kepplinger <martin.kepplinger@puri.sm>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, dgilbert@interlog.com,
        bvanassche@acm.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi_logging: print cdb into new line after opcode
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1mtx09wpa.fsf@ca-mkp.ca.oracle.com>
References: <20210122083918.901-1-martin.kepplinger@puri.sm>
        <c0c7b4cde76c9b15aad9fa213dcaeb75295763fd.camel@redhat.com>
Date:   Fri, 22 Jan 2021 22:09:57 -0500
In-Reply-To: <c0c7b4cde76c9b15aad9fa213dcaeb75295763fd.camel@redhat.com> (Ewan
        D. Milne's message of "Fri, 22 Jan 2021 14:52:56 -0500")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.ca.oracle.com (138.3.200.58) by CH0PR04CA0110.namprd04.prod.outlook.com (2603:10b6:610:75::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12 via Frontend Transport; Sat, 23 Jan 2021 03:10:00 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b28a3421-e4e7-412e-94e0-08d8bf4c5f1c
X-MS-TrafficTypeDiagnostic: PH0PR10MB4711:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB471107B73B525A384B8511078EBF9@PH0PR10MB4711.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LzwCVhA4E6lHaLpuyM22vkNbGrufMsFTypAIKW9LXCFlzp6jU5gI1pQIOuzEm4zjqBetaDZhUCQ+XAG+xDGFWSkem2LbU8S9CZFEjTHoGn+QlUxLSOoOUEiZmXkZ72CurkjSxx0RFvFMHveZZrzBIyg82YGaBxKOdNo/u+ejEN5GyXGs30JI5HQpcl0VNxTjum3GqcNf2ukF8TeP7gn8skG2sWMVAs0Uidm2eQqJsDNanr7r+lKItYBXz8AxB6HJ6LDBss6T8AebCZMRKYsGJbj/HHyJFvQnFMRQiYI3UqpKKnPzmmsVXNRvehHOSZcEJQysv34w9h5OQrrVuP9T9duy4aM6+d8d4da70dqIVEpOWxlk5EOuiGn1qNvm1dIabVbQB3FSDf/5ilWLYnPTkQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(136003)(346002)(366004)(396003)(66556008)(5660300002)(16526019)(26005)(6916009)(83380400001)(6666004)(4744005)(186003)(8676002)(66476007)(66946007)(8936002)(956004)(7696005)(4326008)(86362001)(55016002)(52116002)(316002)(36916002)(2906002)(478600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?n3vJ8BX8vqVYSbxHxM0osM5GIWQLv/a+gfqnk46/freh7mV2+Tu2iZyzqa/4?=
 =?us-ascii?Q?SSDCB8qVSjkA03ySWIzaowtlUUjHUoF3CBZ0TdePmTTZ8FzMCE6p/+9jS2Y2?=
 =?us-ascii?Q?lE+Bq7Pppjeo2xe7AGzF3LmUKZ+tbQQIwKKIdadGZLmJpPby7Ev+RvMfUdCa?=
 =?us-ascii?Q?s5CdM7/kH+hBDitI7+PWVhq98IOp7qgMlskz9i8ZT8hawfeg0fOxPR4vt2HF?=
 =?us-ascii?Q?VS6R9h+xwbzb5deCh8VTjEzRXO3YlJAODY5dfbID4FPyHf3NrlcCI5HaRxtF?=
 =?us-ascii?Q?82qtpnS6cGMCm96i9Jgiu3zHXpQ++K33saEMi/9c1GVflgVYvId8cIK3M89h?=
 =?us-ascii?Q?ziAwo3BthQw2SwcnnE0mSEP6XMQOun2AMtuJEt/6OfdT9GZVsZYmT7pZXpEV?=
 =?us-ascii?Q?YGTZY7jzDKFSQI1NLUVPQnsqsBbUX4rUZ4HLp6HZe1kwRH9JUmbODZGGR7ns?=
 =?us-ascii?Q?sQqAqzQSQuz4MOFaO8nfKad7TfZ8UUqbeyIzt6HzVjI3ZUQcm0qgSX1njlBf?=
 =?us-ascii?Q?UNbjGIuluL6WliSjsqsXJbdzhsPXK3+Og3Nj1uc7ayM0h+7UN0Xox/Htw3sv?=
 =?us-ascii?Q?KetNJ/goiZxEqIgWe3xfDN7roVDILZdGlG+x8WaIZgEJOye4H8O6Eb22pMXa?=
 =?us-ascii?Q?iFYKLd1YV1p9pGoB6nfmFXzHo9Pt278BU+XabrBdNK55bAhQejOgj5R3do9B?=
 =?us-ascii?Q?6bi1naYA0yXa2AtaSxw0ysoW45pfTOsz6UtgOYMlaYy6IQcZFFKo5Y/L+RCt?=
 =?us-ascii?Q?FZ5iO2xrGj58zlL/Td+aXZRXu9eB9jp7K/5kaouS69x1IhGpRANiBmRfY5Mm?=
 =?us-ascii?Q?9Yu+VP6uz+HTofsr/QyAfK9MQfKh9M0iqcCCWAXVJ2bT1RUGbaw+vYm4ceu6?=
 =?us-ascii?Q?5Nd1E/9n+sZNInE+e3FCaJhNmDDyN5raPYbkd5lW67lKaO3ars/NneQs1jGt?=
 =?us-ascii?Q?mmCRO1QkfhsEYusUwXFYjTOkOTDDh1jYthiuNIYTFy2uW30DqAC7A1QKFapm?=
 =?us-ascii?Q?6gXS3LL264BcVEYmMayM/zAAFvYy/t+XNBsSuoEDMPk3WN31byI57WO4QbZp?=
 =?us-ascii?Q?tVZKQ7pn?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b28a3421-e4e7-412e-94e0-08d8bf4c5f1c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2021 03:10:00.7929
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bdvu1nck2cJaIUdQMuWM2NtewLq8bkv+RZIVX/vIuGZCmvA5OYvpgRljd10jvxGQ3a0JvSMY3cdQ2RKclKic1/y8yUyuCxjfC/JX+Ug35Gc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4711
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9872 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=999
 adultscore=0 suspectscore=0 phishscore=0 mlxscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101230017
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9872 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 phishscore=0
 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0
 priorityscore=1501 mlxscore=0 clxscore=1011 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101230018
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Ewan,

>> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 60 40 00 00 01
>> 00
>> 
>> Print the cdb into a new line in any case, not only when cmd_len is
>> greater than 16. The above example error will then read:
>> 
>> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28
>> 28 00 01 c0 09 00 00 00 08 00
>
> I'd rather we not change this.

I agree. While the current format is suboptimal, there are lots of
things out there parsing these error messages.

-- 
Martin K. Petersen	Oracle Linux Engineering