Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 23 Jan 2021 12:00:01 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     David Ahern <dsahern@gmail.com>
Cc:     Maciej =?UTF-8?B?xbtlbmN6eWtvd3NraQ==?= <zenczykowski@gmail.com>,
        Praveen Chaudhary <praveen5582@gmail.com>,
        David Miller <davem@davemloft.net>, corbet@lwn.net,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        Hideaki Yoshifuji <yoshfuji@linux-ipv6.org>,
        Linux NetDev <netdev@vger.kernel.org>,
        linux-doc@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Zhenggen Xu <zxu@linkedin.com>
Subject: Re: [PATCH v3 net-next 1/1] Allow user to set metric on default
 route learned via Router Advertisement.
Message-ID: <20210123120001.50a3f676@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <bc855311-f348-430b-0d3c-9103d4fdbbb6@gmail.com>
References: <20210119212959.25917-1-pchaudhary@linkedin.com>
        <1cc9e887-a984-c14a-451c-60a202c4cf20@gmail.com>
        <CAHo-Oozz-mGNz4sphOJekNeAgGJCLmiZaiNccXjiQ02fQbfthQ@mail.gmail.com>
        <bc855311-f348-430b-0d3c-9103d4fdbbb6@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 22 Jan 2021 22:16:41 -0700 David Ahern wrote:
> On 1/22/21 9:02 PM, Maciej =C5=BBenczykowski wrote:
> > Why can't we get rid of the special case for 0 and simply make 1024 the
> > default value? =20
>=20
> That would work too.

Should we drop it then? Easier to bring it back than to change the
interpretation later. It doesn't seem to serve any clear purpose right
now.

(Praveen if you post v4 please take a look at the checkpatch --strict
warnings and address the ones which make sense, e.g. drop the brackets
around comparisons, those are just noise, basic grasp of C operator
precedence can be assumed in readers of kernel code).