Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1982730pxb; Sat, 23 Jan 2021 12:13:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwH6SVi6QK3TxcfqryhEMAWgiX6YLpdXfWVK0O+j90eTIEo0lvJaZAyLLqIHPoPMOZkLY/9 X-Received: by 2002:aa7:d504:: with SMTP id y4mr530247edq.372.1611432791534; Sat, 23 Jan 2021 12:13:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611432791; cv=none; d=google.com; s=arc-20160816; b=a2CW0NQ7dlaiEh4u30ZITVT+JB0p8FkskoNlvHnrFgUxecffbG1JdQP/iK78DkDKXx dcMYXOCxiXQ1FCqtjhX26Ryk5dugOPi9ZfxU0fR47xdMXazTmHx7nEVG11dojpnC1DAq JkZhKpNRi1c0BYOsT47aiy41w2WQKiMPlXku4v9/FNb2hH248tqafm444VnsEnHMxIEY 0vtDTp4EtZs5LXPeCKDYSY2aRz2adtx1pJO9KyZ2XQ+UFbEIVHXlYVqJ7VBbUZ2rUi+C jpaaZT0h7yYXTio1cdE+rnw5h0chz8w3y8yt4nBGuOZbPESi7FYSZIIiK+98N5Si43iN M05g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:dkim-signature:dkim-signature:from; bh=snbBb8jbhWawsw2GQsoMHEAKGubaOMjN8g5bGgFLep8=; b=aKH9rsOEQW3S+cKYap3cOQUK0eXmV/T9pP7K1T1YCwgkffPRDtYn+N5Kj8wOem1JRS zVyvPxGbDBunRYOzhD3IP0LNdauaJM0qVi+Ro2RQr+UrYdFjUBhARBPjtChw4lYdBBgD ik2FB6GyNovHPhGWcfrb79PbzMDnjN8ekwoQlEA1cMtt15sQdx/XFTP8yioVf22zkojk awPu+5RrC124isr1OjXn6JpiEdf6ySO6fQRsaBwHPX5qB8FCISnKdSlrGsBD3iOWlXBv gtaijnetTsswSQvV9GV+mWaHjx15mLOlXWxlqyO+aBp1OiX+sMnvvpjQubV5BW4o1tYv iVQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=b6Hbygbi; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b="jdIEwID/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y36si5374427ede.158.2021.01.23.12.12.48; Sat, 23 Jan 2021 12:13:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=b6Hbygbi; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b="jdIEwID/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726541AbhAWULp (ORCPT + 99 others); Sat, 23 Jan 2021 15:11:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726374AbhAWULT (ORCPT ); Sat, 23 Jan 2021 15:11:19 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20425C0613D6; Sat, 23 Jan 2021 12:10:39 -0800 (PST) From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1611432634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=snbBb8jbhWawsw2GQsoMHEAKGubaOMjN8g5bGgFLep8=; b=b6HbygbiVP2lcXA+lKmy7IiN+6FqeUJFUkgeR5UelMv2N8aINVYMIQ1tcLOoHrvmv3ePTT n61hiRZhsU+Jyy4YJs35a16Hc+W8wzgRoHhYKEBn3FRgrgwa3LODg074Tc+6p6cwgbPphb 8OKYLYwLwiqp6yDPk7ZS9VH0r1e1iVGElLKoTsVd5939d8eOxoHzIcxj50F72PUfI2Iqdj I3kWF89xRZf3Ydl4RTtqjVXRpIwF7dtl/EeB2/cA1OWP1+SUVaCzcobhxTn3kq3N2uRwVT Um3G8+5ZuxMFbXlG6JXNUXhoSO9raFovDkJSVCaaZWfOCU981ilwa+lJFx+xSQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1611432634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=snbBb8jbhWawsw2GQsoMHEAKGubaOMjN8g5bGgFLep8=; b=jdIEwID/4bQ3nmAPbaZAtu9xC+D1aOSxyJaF/RtW1fqRhdcS97ZAwgx+WYKCfdSVq1i24b jFlK7OZgy37YMDDQ== To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jens Axboe , Thomas Gleixner , Peter Zijlstra , Ingo Molnar Subject: [PATCH v3 0/3] blk-mq: Don't complete in IRQ, use llist_head Date: Sat, 23 Jan 2021 21:10:24 +0100 Message-Id: <20210123201027.3262800-1-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Patch 2+3 were applied and then dropped by Jens due to a NOHZ+softirq related warning [0]. Turns out a successful wakeup via set_nr_if_polling() will not process any softirqs and the CPU may go back to idle. This is addressed by patch #1. smpcfd_dying_cpu() will also invoke SMP-functions calls via flush_smp_call_function_queue() but the block layer shouldn't queue anything because the CPU isn't online anymore. The two caller of flush_smp_call_function_from_idle() look fine with opening interrupts from within do_softirq(). [0] https://lkml.kernel.org/r/1ee4b31b-350e-a9f5-4349-cfb34b89829a@kernel.dk Sebastian