Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [PATCH v3 net-next 1/1] Allow user to set metric on default route
 learned via Router Advertisement.
From:   praveen chaudhary <praveen5582@gmail.com>
In-Reply-To: <2de4989b-5b72-cb0a-470f-9bd0dcb96e53@gmail.com>
Date:   Sun, 24 Jan 2021 00:09:20 -0800
Cc:     =?utf-8?Q?Maciej_=C5=BBenczykowski?= <zenczykowski@gmail.com>,
        David Miller <davem@davemloft.net>, corbet@lwn.net,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        Hideaki Yoshifuji <yoshfuji@linux-ipv6.org>,
        Linux NetDev <netdev@vger.kernel.org>,
        linux-doc@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Zhenggen Xu <zxu@linkedin.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3ACC52AF-8992-4CD9-B89F-2529DA402A25@gmail.com>
References: <20210119212959.25917-1-pchaudhary@linkedin.com>
 <1cc9e887-a984-c14a-451c-60a202c4cf20@gmail.com>
 <CAHo-Oozz-mGNz4sphOJekNeAgGJCLmiZaiNccXjiQ02fQbfthQ@mail.gmail.com>
 <bc855311-f348-430b-0d3c-9103d4fdbbb6@gmail.com>
 <20210123120001.50a3f676@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <2de4989b-5b72-cb0a-470f-9bd0dcb96e53@gmail.com>
To:     David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>
Precedence: bulk


> On Jan 23, 2021, at 5:13 PM, David Ahern <dsahern@gmail.com> wrote:
>=20
> On 1/23/21 1:00 PM, Jakub Kicinski wrote:
>> On Fri, 22 Jan 2021 22:16:41 -0700 David Ahern wrote:
>>> On 1/22/21 9:02 PM, Maciej =C5=BBenczykowski wrote:
>>>> Why can't we get rid of the special case for 0 and simply make 1024 =
the
>>>> default value? =20
>>>=20
>>> That would work too.
>>=20
>> Should we drop it then? Easier to bring it back than to change the
>> interpretation later. It doesn't seem to serve any clear purpose =
right
>> now.
>>=20
>> (Praveen if you post v4 please take a look at the checkpatch --strict
>> warnings and address the ones which make sense, e.g. drop the =
brackets
>> around comparisons, those are just noise, basic grasp of C operator
>> precedence can be assumed in readers of kernel code).
>>=20
>=20
> let's do a v4.
>=20
> Praveen: set the initial value to IP6_RT_PRIO_USER, do not allow 0,
> remove the checks on value and don't forget to update documentation.
>=20

Sure, I will respin V4, with above mentioned changes. Also, I will =
address checkpatch --strict warnings.

I wanted to set initial value to IP6_RT_PRIO_USER in v1, but avoided =
till review for 2 simple coding reasons:
1.) IP6_RT_PRIO_USER must be exposed in net/ipv6/addrconf.c by including =
include/uapi/linux/ipv6_route.h.
2.) If rt6_add_dflt_router() will be called from other files in future, =
IP6_RT_PRIO_USER should be included in all those files as well, because =
caller will pass most probably default value.

> Oh and cc me on the next otherwise the review depends on me finding =
time
> to scan netdev.

Sure, I will cc you and will add =E2=80=9CReviewed by=E2=80=9D as well. =
I will also send you the lkml link to v4.
Thanks Jakub and you for reviewing this over the weekend.