Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2443372pxb; Sun, 24 Jan 2021 07:10:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqC9OnBowTWx5TsknRzFoM25HioBajLH30JDTZHXHvB/ZqfBenrCKuNtLkAeCfIfp5RGrg X-Received: by 2002:aa7:c44f:: with SMTP id n15mr207041edr.150.1611501052257; Sun, 24 Jan 2021 07:10:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611501052; cv=none; d=google.com; s=arc-20160816; b=QrU/qPCC8ZkM1G2sydm/nT6dN4q6/ojqfSfGuXr1ZCjHVBsSHDMfGkR/OmPIIEeolE cyEhl9LC4iVMwjAtiGPgPjVYM8tajSDjIxiKU1MVuXIAIahLZqNUzRDe98tWOQhI4FGB 1gDbrS6B9zqTtsInA8UNtzKFHuxYciUxRTZrHydkLWpupLekpzQqZdLkLJNvA/SE83Lc 5fNyQpJGTqmVlto0thlQJZ4b1mChTIik/CgiWHDDYQhDt2+C5q6LpQl/GrkHsDGsmD6f 7L6clb/RuiX3HY5lE5gHAa2b07K2fbG+2+eACAQz13OVS15H+JoW8gb0RD5FKf2mcDQD rM3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=WggKaRygWF5ZvUkOTaB2jRxdcoS8ZrKYqVE+CHFSYHs=; b=SlbGC0kQtspN8eCOwmVmZ1EDlb8HXxf7d3iSZ9kW8OkFBLSLfcWbnFvBeW8PVzkBXH UDeJgJyS3qw29zDEWJasJ1x4JSHbySf56vJ4o1Q7vgfD8PebWf8mkf6l3Yp1iyc16LUT 1r2B5kIh+PCnf2wPpfp5Khw17SVpOHhYroktBEOv3dnDuBLTOICwoZ+bpUgdf3K0Mhul QJ0/xCNY6mT4hj2mk3dw9gIuBxSE6IYKzOZmGVo8Mb8nORNuYG4ye1ZL7HpBgRClmRDV DnjdZAITKLec2vSUG2+dIp4sxFHm5VJ6YbWdQwIiQvytxDsWnlqnvymM4ziF5tHLbetb kYYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IQ5f3lnj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i16si5121086ejc.454.2021.01.24.07.10.28; Sun, 24 Jan 2021 07:10:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IQ5f3lnj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726243AbhAXPIX (ORCPT + 99 others); Sun, 24 Jan 2021 10:08:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48933 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726230AbhAXPIV (ORCPT ); Sun, 24 Jan 2021 10:08:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611500813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WggKaRygWF5ZvUkOTaB2jRxdcoS8ZrKYqVE+CHFSYHs=; b=IQ5f3lnjauBe4cHO/xRVcvMeZBbOicE3LtkBQRR5wP/FSmGtEvvajobmeqcjd81LlooLzf G/3XNPAqGSCC2lVdNZPub8C9Da/6qqmguITQQr7lFYGNQFVVZM5NcMqwqX3xiVNIG+2XUv O9NGFbx/1w+kan6iD/XTbm2s2HUH5KI= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-ghWhBjN7MBaqI6fyHvIMXw-1; Sun, 24 Jan 2021 10:06:52 -0500 X-MC-Unique: ghWhBjN7MBaqI6fyHvIMXw-1 Received: by mail-qv1-f72.google.com with SMTP id k20so667127qvm.16 for ; Sun, 24 Jan 2021 07:06:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=WggKaRygWF5ZvUkOTaB2jRxdcoS8ZrKYqVE+CHFSYHs=; b=NP07nMGbMLzYriuREHpQHKMYXCbSMD4tD/7Ux+2lDnIU8ss4yL0L60JXUdvAqo4cxh bg+LwQgGi2fbkp358jXZZzERx2XJO0MAu/rvHMNKD+WLCj91HNkhZQ8RhH+BKrlHkk1H 9MRV+bQ0Dp94HTlkQLV7pgcrSO0fB5uHULLTgVUEARV42WDJblOAtjUQDDu3fo0oNsmN BoRcfYNZHEGFdUFZjwI1dAWkfg3WR3nSH1jJqsCemMLdCfRM5BoEWsYaiCfpeJKqCMmX 0OLRMkeAANJLAWCouZqx2zEMNWxn9JdpKsVixDuZ+YLC/doRN2HaBeHv06dgsyrqt4bK 689Q== X-Gm-Message-State: AOAM531Xyxc8yyuyPZirczy9YwLPuuEvfojlmnPzAHE673Kh/4h8Um7O CwH9NSp7DQetraW8GBqfmC+Z6MBMIyUj3bmTDPdDuPqa1EPPEGVXiYj/K/Yxa+dT+HP1JpQbfzj 7qnUX8Kjx9N2F3+JIyUFrO285 X-Received: by 2002:a0c:c242:: with SMTP id w2mr1117971qvh.33.1611500811442; Sun, 24 Jan 2021 07:06:51 -0800 (PST) X-Received: by 2002:a0c:c242:: with SMTP id w2mr1117955qvh.33.1611500811240; Sun, 24 Jan 2021 07:06:51 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id j124sm10093281qkf.113.2021.01.24.07.06.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Jan 2021 07:06:50 -0800 (PST) Subject: Re: [PATCH v3] selftests: drivers: fpga: A test for interrupt support To: Moritz Fischer Cc: shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-fpga@vger.kernel.org References: <20210117161815.514078-1-trix@redhat.com> From: Tom Rix Message-ID: <4c5adecc-8a66-350a-c1a2-a44e8ca982ef@redhat.com> Date: Sun, 24 Jan 2021 07:06:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/23/21 8:24 PM, Moritz Fischer wrote: > Tom, > > On Sun, Jan 17, 2021 at 08:18:15AM -0800, trix@redhat.com wrote: >> From: Tom Rix >> >> Check that the ioctl DFL_FPGA_PORT_ERR_GET_IRQ_NUM returns >> an expected result. >> >> Tested on vf device 0xbcc1 >> >> Sample run with >> # make -C tools/testing/selftests TARGETS=drivers/fpga run_tests >> ... >> TAP version 13 >> 1..1 >> # selftests: drivers/fpga: intr >> # TAP version 13 >> # 1..1 >> # # Starting 1 tests from 1 test cases. >> # # RUN global.afu_intr ... >> # # OK global.afu_intr >> # ok 1 global.afu_intr >> # # PASSED: 1 / 1 tests passed. >> # # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 >> ok 1 selftests: drivers/fpga: intr >> >> Signed-off-by: Tom Rix >> --- >> v1: Convert to kselftest_harness.h framework >> v2: reverse xmas tree variables >> --- >> MAINTAINERS | 1 + >> tools/testing/selftests/Makefile | 1 + >> tools/testing/selftests/drivers/fpga/Makefile | 7 ++++ >> tools/testing/selftests/drivers/fpga/config | 1 + >> tools/testing/selftests/drivers/fpga/intr.c | 36 +++++++++++++++++++ >> 5 files changed, 46 insertions(+) >> create mode 100644 tools/testing/selftests/drivers/fpga/Makefile >> create mode 100644 tools/testing/selftests/drivers/fpga/config >> create mode 100644 tools/testing/selftests/drivers/fpga/intr.c >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index de610a06cb5c..7ed3ce58d95e 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -6973,6 +6973,7 @@ F: Documentation/driver-api/fpga/ >> F: Documentation/fpga/ >> F: drivers/fpga/ >> F: include/linux/fpga/ >> +F: tools/testing/selftests/drivers/fpga/ >> >> FPGA SECURITY MANAGER DRIVERS >> M: Russ Weight >> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile >> index afbab4aeef3c..aad4763ec348 100644 >> --- a/tools/testing/selftests/Makefile >> +++ b/tools/testing/selftests/Makefile >> @@ -9,6 +9,7 @@ TARGETS += core >> TARGETS += cpufreq >> TARGETS += cpu-hotplug >> TARGETS += drivers/dma-buf >> +TARGETS += drivers/fpga >> TARGETS += efivarfs >> TARGETS += exec >> TARGETS += filesystems >> diff --git a/tools/testing/selftests/drivers/fpga/Makefile b/tools/testing/selftests/drivers/fpga/Makefile >> new file mode 100644 >> index 000000000000..eba35c405d5b >> --- /dev/null >> +++ b/tools/testing/selftests/drivers/fpga/Makefile >> @@ -0,0 +1,7 @@ >> +# SPDX-License-Identifier: GPL-2.0-only >> +CFLAGS += -I../../../../../usr/include/ >> +CFLAGS += -I../../../../../include/uapi/ >> + >> +TEST_GEN_PROGS := intr >> + >> +include ../../lib.mk >> diff --git a/tools/testing/selftests/drivers/fpga/config b/tools/testing/selftests/drivers/fpga/config >> new file mode 100644 >> index 000000000000..e2111b81d8d7 >> --- /dev/null >> +++ b/tools/testing/selftests/drivers/fpga/config >> @@ -0,0 +1 @@ >> +CONFIG_FPGA_DFL_AFU=m >> diff --git a/tools/testing/selftests/drivers/fpga/intr.c b/tools/testing/selftests/drivers/fpga/intr.c >> new file mode 100644 >> index 000000000000..927dcc757f0b >> --- /dev/null >> +++ b/tools/testing/selftests/drivers/fpga/intr.c >> @@ -0,0 +1,36 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include "../../kselftest_harness.h" >> + >> +TEST(afu_intr) >> +{ >> + struct dfl_fpga_port_info port_info; >> + uint32_t irq_num = UINT32_MAX; >> + int devfd, status; >> + >> + devfd = open("/dev/dfl-port.0", O_RDONLY); >> + if (devfd < 0) >> + SKIP(0, "no fpga afu device 0"); >> + /* >> + * From fpga-dl.h : >> + * Currently hardware supports up to 1 irq. >> + * Return: 0 on success, -errno on failure. >> + */ >> + status = ioctl(devfd, DFL_FPGA_PORT_ERR_GET_IRQ_NUM, &irq_num); >> + ASSERT_EQ(0, status) { >> + TH_LOG("ioctl() failed to get the number irqs"); >> + } >> + ASSERT_LT(irq_num, 256) { >> + TH_LOG("unexpeced number of irqs"); >> + } >> + close(devfd); >> +} >> + >> +TEST_HARNESS_MAIN >> -- >> 2.27.0 >> > Looks good to me, from FPGA perspective, needs Acked-by from Shua, though. > > Also, this does not apply to linux-next, or for-5.12 or char-misc-next, > so I'm confused :) > > Once that's sorted, feel free to add This applied to char-misc-next, at least a couple of days ago, I will check again T > Acked-by: Moritz Fischer > > - Moritz >