Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2446754pxb; Sun, 24 Jan 2021 07:16:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKaQtSu2nZXmIR8YwwiW4aoNGnnTc/VzeyOKjvwUWJPhUBeNC/kYAlx5n7trIQ3ca3bipK X-Received: by 2002:a17:906:6846:: with SMTP id a6mr276898ejs.470.1611501402184; Sun, 24 Jan 2021 07:16:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611501402; cv=none; d=google.com; s=arc-20160816; b=PTvWSnfWKSZTsiBhFpZstnDLgMHSSSe0+5FsoY2EXT6nSOMrEjmpnhrh7E9sAkA/fA deadL5SRf81rq+VG131CjITy3Qq7ecCOTSZl5q9ntDJQuwdoPm0nZGdHNGFtWwGN+tww rzAjAqGqs70/ogdoieg08VqY+W7BGRbjxvGwfeqAAlfa+R9muNdSvkyNXGhTaDcUiOZz hPyGNndsqrEuflV4K5ogB0TGiouZfKgY1V4DnDgdbgSKl0En2Qh6vsRAVQHX7qXmuIwg dyFRZZnwoqDxoinsfuRQVYMXLoVywqikorZg+eGPC9t2Qcr//6+lnynShtmthKIsXZv9 J+kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=AkBGm8p0fa4rt1PI1coAbw65Fn4m5HoJaXKXxd+BTEc=; b=o6IeDMCAvSabwZlfVKsU9s/9r+3+D+pNr3+BZwzKbNi96yyGgItycJEHBOHR2Z5xnI /osoLeEc19uChKX9C+50EE4hylFC6FTy7hkhfLJqySpn019jpvbPwArLJZ/iYNixsZ7m eHx8sFMauqXveNkx/aaANxlFxxua7dcSqvJIPEh8PJ180KQ3XZLTFbIO45TkSCvhgfu4 IdU7hFjdyGqpvOC0lgyezC1qX9RzkGiP3s1m2oyFsN5HbOOE0qyqps27zcFJNx0HU/vD Gi09IkDlxbi/KusZ+P4s/fIwHpoWuC7cMxy/Ti204fu1toQe7dc3ilmEgd4Le4UpdFSr ogCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b9fAFLXM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si5227298ejk.328.2021.01.24.07.16.18; Sun, 24 Jan 2021 07:16:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b9fAFLXM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726709AbhAXPNA (ORCPT + 99 others); Sun, 24 Jan 2021 10:13:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29030 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726444AbhAXPLC (ORCPT ); Sun, 24 Jan 2021 10:11:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611500972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=AkBGm8p0fa4rt1PI1coAbw65Fn4m5HoJaXKXxd+BTEc=; b=b9fAFLXMSOkPd9Xjijt04qDItG38VWRCGZoz7rFR/j3YEOHaQJOUWIh6T3E1vb2oOjKWBt Fl6SJOfZ3RPaH8f5R8avTPkXahCbFqKQDRzlJz14TDQnK/4nNC2hLePsVTWYp10wyN3Vdb Vx1yZjZ+7PghLsSDq47GneHKFE18Y70= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-RgcbBGE_OReGCBNEG6dHrA-1; Sun, 24 Jan 2021 10:09:30 -0500 X-MC-Unique: RgcbBGE_OReGCBNEG6dHrA-1 Received: by mail-qv1-f72.google.com with SMTP id h1so7621995qvr.7 for ; Sun, 24 Jan 2021 07:09:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AkBGm8p0fa4rt1PI1coAbw65Fn4m5HoJaXKXxd+BTEc=; b=fJwDTRA+0ylXRdP62dj9xJcE0LcGT2pjqo2rucncXb2JKM/sp77sehWnixsCIv4jPn do+DYyYy6iDVbZHZp1tGyZG/IflhvW9suR1O/rMyalQlmETsJ7632sMEidtHbdreryXH fLQKoMGa3b0n6cvUPGkSE84hDj70v6m3JjJI4jWGUvGstfGzF46qTBvCNa322clIPXs8 ie/2dSxT65K37uaO8iCPrsC6J5sDgEkweLAKSwIiaqkE10O4UqCpgtCvOOrOSf/iVbrs Xg37b9QYtjIdA3H9y29a4ybGYnVLUlXe3tD+J0tZPe1zbwFeBN3g7AB40YaEbSP/l77y STqw== X-Gm-Message-State: AOAM5320OwBkv6V9scvE3B99U5qJhDdyxrl6ETUa9FC1zDx6VLHwk2wV T3hrBdGInEgc9I1uHyPPh5d0ibBpPXBGi7hzlnPzwXdr5bvV1DXuvJ52Q6dbP+eX3FyRXnHJHsx 7GutfsH1vGrRvHjx4SFg1uZdj X-Received: by 2002:ac8:1184:: with SMTP id d4mr83455qtj.103.1611500970477; Sun, 24 Jan 2021 07:09:30 -0800 (PST) X-Received: by 2002:ac8:1184:: with SMTP id d4mr83442qtj.103.1611500970318; Sun, 24 Jan 2021 07:09:30 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id v12sm2556362qkg.63.2021.01.24.07.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jan 2021 07:09:29 -0800 (PST) From: trix@redhat.com To: wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net, kuba@kernel.org, socketcan@hartkopp.net, colin.king@canonical.com Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] can: mcba_usb: remove h from printk format specifier Date: Sun, 24 Jan 2021 07:09:16 -0800 Message-Id: <20210124150916.1920434-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi]. Signed-off-by: Tom Rix --- drivers/net/can/usb/mcba_usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c index df54eb7d4b36..dc79c050f5f7 100644 --- a/drivers/net/can/usb/mcba_usb.c +++ b/drivers/net/can/usb/mcba_usb.c @@ -466,7 +466,7 @@ static void mcba_usb_process_ka_usb(struct mcba_priv *priv, struct mcba_usb_msg_ka_usb *msg) { if (unlikely(priv->usb_ka_first_pass)) { - netdev_info(priv->netdev, "PIC USB version %hhu.%hhu\n", + netdev_info(priv->netdev, "PIC USB version %u.%u\n", msg->soft_ver_major, msg->soft_ver_minor); priv->usb_ka_first_pass = false; @@ -492,7 +492,7 @@ static void mcba_usb_process_ka_can(struct mcba_priv *priv, struct mcba_usb_msg_ka_can *msg) { if (unlikely(priv->can_ka_first_pass)) { - netdev_info(priv->netdev, "PIC CAN version %hhu.%hhu\n", + netdev_info(priv->netdev, "PIC CAN version %u.%u\n", msg->soft_ver_major, msg->soft_ver_minor); priv->can_ka_first_pass = false; @@ -554,7 +554,7 @@ static void mcba_usb_process_rx(struct mcba_priv *priv, break; default: - netdev_warn(priv->netdev, "Unsupported msg (0x%hhX)", + netdev_warn(priv->netdev, "Unsupported msg (0x%X)", msg->cmd_id); break; } -- 2.27.0