Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 24 Jan 2021 16:45:35 +0100
From:   Stephan Gerhold <stephan@gerhold.net>
To:     Konrad Dybcio <konrad.dybcio@somainline.org>
Cc:     Jonathan Albrieux <jonathan.albrieux@gmail.com>,
        linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: Add device tree for BQ Aquaris X5
 (Longcheer L8910)
Message-ID: <YA2WHwuKwaLZ9sVm@gerhold.net>
References: <20210124135409.5473-1-jonathan.albrieux@gmail.com>
 <20210124135409.5473-2-jonathan.albrieux@gmail.com>
 <cb299b22-f00f-c8fd-648e-6f34c34b0967@somainline.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cb299b22-f00f-c8fd-648e-6f34c34b0967@somainline.org>
Precedence: bulk

On Sun, Jan 24, 2021 at 04:12:30PM +0100, Konrad Dybcio wrote:
> The sorting on smd_rpm_regulators & msmgpio seems off.. unless it's the new thing to put it at the end?
> 

It's consistent like this for all MSM8916 device trees at least.

Back when I converted them I thought that it's kind of annoying to have
this large list of regulators and pinctrl placed right inbetween all
other device definitions. And it's even worse for apq8016-sbc.dtsi which
has this large list of gpio-line-names. It just makes it harder to see
the actual interesting definitions (new devices etc) in my opinion.

I think I mentioned this in my patch description back then
and Bjorn did not complain. :-)

But I understand this may be somewhat inconsistent with other qcom
device trees at the moment, so I suppose I would be fine with a patch
to order them entirely alphabetically.
(As long as it's consistent for all MSM8916 device trees...)

Thanks,
Stephan