Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Luca Weiss <luca@z3ntu.xyz>
To:     Iskren Chernev <iskren.chernev@gmail.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        ~postmarketos/upstreaming@lists.sr.ht
Cc:     Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht,
        Samuel Pascua <pascua.samuel.14@gmail.com>,
        Alexey Minnekhanov <alexeymin@postmarketos.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH 3/4] ARM: dts: qcom: msm8974-klte: add support for display
Date:   Sun, 24 Jan 2021 18:31:34 +0100
Message-ID: <6632821.dtBD41K2ms@g550jk>
In-Reply-To: <282b07a1-2e39-2dbe-dd7b-eed2ae9e25fb@somainline.org>
References: <20210124135610.1779295-1-iskren.chernev@gmail.com> <20210124135610.1779295-3-iskren.chernev@gmail.com> <282b07a1-2e39-2dbe-dd7b-eed2ae9e25fb@somainline.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Hi Konrad,

On Sonntag, 24. J=E4nner 2021 16:04:13 CET Konrad Dybcio wrote:
> > +	mdss@fd900000 {
> > +		status =3D "ok";
> > +
> > +		mdp@fd900000 {
> > +			status =3D "ok";
> > +		};
> > +
> > +		dsi@fd922800 {
> > +			status =3D "ok";
> > +
> > +			vdda-supply =3D <&pma8084_l2>;
> > +			vdd-supply =3D <&pma8084_l22>;
> > +			vddio-supply =3D <&pma8084_l12>;
> > +
> > +			#address-cells =3D <1>;
> > +			#size-cells =3D <0>;
> > +
> > +			ports {
> > +				port@1 {
> > +					endpoint {
> > +						remote-
endpoint =3D <&panel_in>;
> > +						data-lanes=20
=3D <0 1 2 3>;
> > +					};
> > +				};
> > +			};
> > +
> > +			panel: panel@0 {
> > +				reg =3D <0>;
> > +				compatible =3D "samsung,s6e3fa2";
> > +
> > +				pinctrl-names =3D "default";
> > +				pinctrl-0 =3D <&panel_pin>;
> > +
> > +				port {
> > +					panel_in: endpoint {
> > +						remote-
endpoint =3D <&dsi0_out>;
> > +					};
> > +				};
> > +			};
> > +		};
> > +
> > +		dsi-phy@fd922a00 {
> > +			status =3D "ok";
> > +
> > +			vddio-supply =3D <&pma8084_l12>;
> > +		};
> > +	};
> >=20
> >  };
>=20
> Please use &label here. If there's none, add them in msm8974.dtsi.
>=20

All msm8974 dts(i) files use this style. Deviating from it for this doesn't=
=20
make sense. And yes msm8974 should probably be converted to the newer label=
=20
style (as was done with msm8916 a while ago).

>=20
> Konrad

Regards
Luca