Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2628868pxb; Sun, 24 Jan 2021 14:24:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQ0iO7GC7Q1pxxTO/lPAeZGVkkr6PZyTHH19Bk8um4o7bR3Gt44MUcKPA7hdqugbOYZ0h/ X-Received: by 2002:a50:fd83:: with SMTP id o3mr122666edt.359.1611527076043; Sun, 24 Jan 2021 14:24:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611527076; cv=none; d=google.com; s=arc-20160816; b=giHAasNfyFOGnRsheW6gy9hP68WDzfA05Y2Ym+ER4zuZwMY4PxTYtcs9+z2eHTZ5il ocRpSa4CvZiEJqBPmrLxxQ8nz2Y6idCDcoDn335U8M/6VayBAAWyA6OwkdbkiK2N+LGz GN5bwb2HynPsCiTppLkPiH/nCQz8rMPAermkNsrJR1HGAoEXYN51dr5yzRaxu0TyY6C4 Eo6yh/j/NZavZUqKLFY/CX5RPSrncxWBl5ut2iUEom5It5es8zj/az4RRjmkTd7OdDN1 ipVgQwsQGJYJVGB2kAfayzQmxT3cuc/79yzpHfXbB8TqlTTQkt8NhrPlMkXl6FJqkzi/ Yu3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=x4XE9iMxFXIuUuZtgsZMasuRPCByYS0f7P0XS6GDiNw=; b=SDsnp1fOe/9LM8TZ35HLdBNpz3L2qw6kWYLBlhzoNqunP+zFD5FABEHR3NXY1tOhg9 xxiZ2tNpyO8BqiduFDd/x7q5OBTSA8iVna9esyg2ASfYPpcIbE4FmbbhYfFNBQdlcfUG fGdgqv/PP/MZ65uan+iYodmJJcGC2fGa+SX3Pgg3wGo+X85dij5E3jJ7Go4cS91KEMcy hSNcaKcgpmTo9OLrKmVP44IY/ZTlAdNwQERRSEipHbAydvqL7PeKq6PqjFAW+gWh3QvK tA47n5/d9jsRqOQfknYRlH6RFaZo2eTZPioUcjgAjNc3HmlSIIfXsU2eX/NA3wjx5NPw 4uHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g5si6832057edv.276.2021.01.24.14.24.12; Sun, 24 Jan 2021 14:24:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726103AbhAXWXU convert rfc822-to-8bit (ORCPT + 99 others); Sun, 24 Jan 2021 17:23:20 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:31474 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725968AbhAXWXR (ORCPT ); Sun, 24 Jan 2021 17:23:17 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-221-V_JHwXlIPZiqhlLQqW69Yw-1; Sun, 24 Jan 2021 22:21:37 +0000 X-MC-Unique: V_JHwXlIPZiqhlLQqW69Yw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Sun, 24 Jan 2021 22:21:38 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Sun, 24 Jan 2021 22:21:38 +0000 From: David Laight To: 'Lennert Buytenhek' , Jens Axboe CC: "linux-kernel@vger.kernel.org" , "io-uring@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-btrfs@vger.kernel.org" Subject: RE: [RFC PATCH] io_uring: add support for IORING_OP_GETDENTS64 Thread-Topic: [RFC PATCH] io_uring: add support for IORING_OP_GETDENTS64 Thread-Index: AQHW8X6IGyYpVbXZsUSWaK/6c3T86ao3WrlQ Date: Sun, 24 Jan 2021 22:21:38 +0000 Message-ID: References: <20210123114152.GA120281@wantstofly.org> In-Reply-To: <20210123114152.GA120281@wantstofly.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > One open question is whether IORING_OP_GETDENTS64 should be more like > pread(2) and allow passing in a starting offset to read from the > directory from. (This would require some more surgery in fs/readdir.c.) Since directories are seekable this ought to work. Modulo horrid issues with 32bit file offsets. You'd need to return the final offset to allow another read to continue from the end position. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)