Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 25 Jan 2021 11:17:10 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Rob Herring <robh@kernel.org>
Cc:     David Airlie <airlied@linux.ie>,
        Nicolas Boichat <drinkcat@google.com>,
        Hsin-Yi Wang <hsinyi@chromium.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sam Ravnborg <sam@ravnborg.org>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Maxime Ripard <mripard@kernel.org>,
        Mark Brown <broonie@kernel.org>,
        Ricardo =?iso-8859-1?Q?Ca=F1uelo?= 
        <ricardo.canuelo@collabora.com>, dri-devel@lists.freedesktop.org,
        devicetree@vger.kernel.org, Sheng Pan <span@analogixsemi.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag
 and swing setting
Message-ID: <20210125031709.GA12296@zhaomy-pc>
References: <cover.1609380663.git.xji@analogixsemi.com>
 <d13442f84fefccc992d6c5e48ac1e6129882af31.1609380663.git.xji@analogixsemi.com>
 <20210111221435.GA3138373@robh.at.kernel.org>
 <20210112085737.GC5827@pc-user>
 <CAL_JsqJ1B6JzpdgtP=ZNtWasjW5R0rYyUGV3RTDxT1LPa1rz5w@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAL_JsqJ1B6JzpdgtP=ZNtWasjW5R0rYyUGV3RTDxT1LPa1rz5w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from zhaomy-pc (61.148.116.10) by HK2PR0401CA0023.apcprd04.prod.outlook.com (2603:1096:202:2::33) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.3784.12 via Frontend Transport; Mon, 25 Jan 2021 03:17:38 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f0deb1d3-5f75-4caf-19c8-08d8c0dfc50c
X-MS-TrafficTypeDiagnostic: BYAPR04MB4741:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR04MB474167D271B9CAA3D6A2EFAFC7BD9@BYAPR04MB4741.namprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: hKX6PAcLQG9lAEEP0dmIsIbQJv1MDy+4wMGwSKjhOCWGwMq4r2UKvdoEXw6CG6jS7X7wOZbakmnvcn9IcsnCIBX6eFVYh4Tduv+U5Fcv/33V3Zta1jXbMy8uXrWj5vJXZPlmiJI/hFcAx9npweDKUDgwsDESI6kVelKy/nQP9lbMIPVc/xcaGVzBNqS9nl3h6X4eRmmH+0KXAffJZ16Q7Wylfna/oDpHskPim3LoIvk+1XYcrYjnlt8d2zNw802xVm2HpgPlnZ0vYeYJoaf6MG5GBDysrSHjhVbKmg6k3YgJ5bOdTjNfo1f4kUzh+DuEaFmIk+w/liAL2bT86VIHFqlRj/sIHJyA82ew/DegHj8z327budbVFUPREB6toWeAWZB1MlTfPi2SpSuAuHqxur97BiqRwvqv9iQKDEnFmZDUrU5NN8k8l6xIcd32f2/F
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR04MB6739.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(39840400004)(376002)(346002)(396003)(33656002)(6496006)(52116002)(956004)(83380400001)(316002)(2906002)(8676002)(54906003)(33716001)(4326008)(478600001)(86362001)(5660300002)(1076003)(55016002)(66476007)(66556008)(26005)(16526019)(6916009)(8936002)(66946007)(9686003)(186003)(53546011)(7416002)(6666004)(16060500001);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?vJwwbLgR37v6gbGQ9RMiIim0pYBc8OIpeXiBOV2D0Gr6UAYR/ZBJtfLLUCDv?=
 =?us-ascii?Q?V/oxCQpaXH/czn2AzP0B2n0IdWupsOu6RGrfyAEb0r0kf2YytvvzO8zGz26C?=
 =?us-ascii?Q?/2BWnzzWKxkQnhHoci4IF0jpdefpo9rtj5uHUeGI1tjwlpHBjV68jJIKGOdy?=
 =?us-ascii?Q?OKCrdQzApoPyiFsNwmgEpoWlj1Hvac5VlqWF7U2pIf8WNZWl5WVqucpDJGgg?=
 =?us-ascii?Q?U3c0Wu96i31lTQ5/VYMzHGUfdeGoQAcn+CJrXTRdRnt2FrPew4tC0kKRDY45?=
 =?us-ascii?Q?7gPeLN//6U+oSmGZXRjfOj6kK+RiN8KsD5pKGX5pRZIlxydNpuvTuHWWJrwc?=
 =?us-ascii?Q?BxrdYZsD8e7NVH4B2ksJoDztpospwP00xz2k16r8bY3jUxJWYiUTJTuAmU40?=
 =?us-ascii?Q?8D3b4mbEl8eAxlSuXIe4N6VThJXRjzB2Q4LCjlI92qBUCTvUThNkrv91PDj9?=
 =?us-ascii?Q?uyFawFl9sz6PtzpHxeqMSGDJWqwJmz73IacirDA6IkywXPQUKQvJ/t5KJA8w?=
 =?us-ascii?Q?2eModwtEOC5rCu/hBhpe4ozgsjWFPy/V8R7N0Wc3pdXSbqggIshbpYsEfTqO?=
 =?us-ascii?Q?wOyLSkrktFw9HT+bXrtfv9mUIEaVrpsYVwXR/Ka6wr5KclOwi3Qyt5Y9t9cV?=
 =?us-ascii?Q?xkMBX5vZqGzi4Rdjl6SyC+jNvroNTmQU4eIUtQY4XZ0hdXpFQnukvKt+vGmC?=
 =?us-ascii?Q?CW9l+GxHAtT1p3pbLJpuCrEano3CbWrdpQJY/yCezUkQPQH5Z1qL/lQudgf4?=
 =?us-ascii?Q?oB/XND8jH/IvD9bUSFk3QjTEqHHVJTZujo9hOEtDJikeciBD20fI2TH71Kp7?=
 =?us-ascii?Q?yDU97POVXdmMzQD/hObo4y6ipA/nK0ZixASC4vCCt4vEO/KvtVlbFxydGC3N?=
 =?us-ascii?Q?GroGePAwygGA7E/yxC1kD/KxwUBu/CDqf5q/xlIWvLrbysEtR4f9VrPZrN9F?=
 =?us-ascii?Q?75qTfv6bcePcAZPcHf9AC6afkr2zi8VraGskjYCnfxmMVXTbCD3r4r5Pgy1J?=
 =?us-ascii?Q?vXr+YjIQ5TyXBA79G9SjrRNrrt7WijDSOH23VNnpRDET/LS4L/ME3Q5D9CuN?=
 =?us-ascii?Q?Jh5i4/Q4?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0deb1d3-5f75-4caf-19c8-08d8c0dfc50c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2021 03:17:39.2176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6G+ByPT6h5mqaVNu26eLVhk9GItFgbyclurLVSIjDO+LPHn/xc+SpdfgEL5iK7q/syHFDCiuLY+xLsiPStEslQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4741
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 23, 2021 at 12:16:02AM +0800, Rob Herring wrote:
> On Tue, Jan 12, 2021 at 2:57 AM Xin Ji <xji@analogixsemi.com> wrote:
> >
> > Hi Rob Herring, thanks for the comments.
> >
> > On Mon, Jan 11, 2021 at 04:14:35PM -0600, Rob Herring wrote:
> > > On Thu, Dec 31, 2020 at 10:21:12AM +0800, Xin Ji wrote:
> > > > Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add
> > > > swing setting for adjusting DP tx PHY swing
> > > >
> > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > ---
> > > >  .../bindings/display/bridge/analogix,anx7625.yaml  | 25 ++++++++++++++++++++--
> > > >  1 file changed, 23 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > > index 60585a4..4eb0ea3 100644
> > > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > > @@ -34,6 +34,16 @@ properties:
> > > >      description: used for reset chip control, RESET_N pin B7.
> > > >      maxItems: 1
> > > >
> > > > +  analogix,swing-setting:
> > > > +    type: uint8-array
> > >
> > > Humm, this should have be rejected by the meta-schema.
> > We needs define an array to adjust DP tx PHY swing, the developer hopes these
> > settings are changeable, so I moved the register data to DT. Can you
> > give me some suggestion if it is rejected by the meta-schema?
> > >
> > > > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> > >
> > > This is how types are defined other than boolean or nodes (object).
> > >
> > > > +    description: an array of swing register setting for DP tx PHY
> > > > +
> > > > +  analogix,mipi-dpi-in:
> > > > +    type: int
> > > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > > +    description: indicate the MIPI rx signal type is DPI or DSI
> > >
> > > Why does this need to be in DT, you should be able to determine this
> > > based on what you are connected to.
> > As the anx7625 can receive MIPI DSI and DPI data (depends on hardware
> > implement, we have a project which have two anx7625, one is DSI input,
> > the other is DPI input), we needs to let driver know what kind of MIPI
> > rx signal input. And there is no other way to tell driver the MIPI rx
> > signal type, we needs define this flag.
> 
> That's only true if what's driving the output is a single h/w block
> that can drive either. But typically you have 2 blocks: an LCD
> controller driving parallel signals and a DSI controller in front of
> it doing parallel to DSI conversion. The anx7625 would be connected to
> the LCD controller or DSI controller via the graph binding depending
> on the h/w connection.
> 
> However, if you do need this, then let's extend video-interfaces.yaml
> 'bus-type' to include DSI (it already has parallel).
> 
> Rob
Hi Rob, thanks, I'll add 'bus-type' in the next version.
Thanks,
Xin