Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2777171pxb; Sun, 24 Jan 2021 20:38:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJx7E+/WjU75wZXw1Mxl2KnFkOCG3ywDJE7ceKA8EGarS06TvNrk2ex3W7eFknjfT/gotUON X-Received: by 2002:a17:906:cd12:: with SMTP id oz18mr1605910ejb.376.1611549530215; Sun, 24 Jan 2021 20:38:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611549530; cv=none; d=google.com; s=arc-20160816; b=CJGyBnn7WfASutZFEAknxFZkijUNAy+CRZmhG96Y9U13erlsW2nqaqklnZI/P2Y1IN yjp9aRS0k+eSNJdpeU8Xhi/+N9yDywcBdk5Zv+HZJjVRVMahlvCIeMOcMVMzAWmHyOXD VvP2C2EmVrgl3HvBHHQRT6mfUskc87v8xV/RVwTAPdRIPC6pCGxbJKbjN3U9CNPM4eI8 HRZo7+waa13KpDRGbBL486ZKJ1CHMHAyrQhb5uaETa9vpHZS41cNypMWGqs0nTFIiSQs D89c+vmWLWXC3s5ziSMr+fI4uDz5oRxrvt6jJRPkaZro7k8vSIJYknLPsgRYODWLNRx5 i4zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=Eqqx1gni4Q4abmvsdVexzq6eMIJu3GVUnZLPq6wIbFo=; b=XFFeCa++v72GcCX9RpyN9eVRmFNlDjpuKbZPB1NaL7fG8U7WDkAYqoQ94WPd5cmx3k uydqSuddxX17I2D5FEMJw54Va3Ks+WlY7BY+B5voJ7KxdUywXov+mPHLKnfVve7iMA/E CnzHzdm6+2Z6sMqITHWpNEdykx87r5//7E/QJRkp/w5qNkcHVEhZ2bsjl5JsWgiVOUNK MHw6vmzueOOKsUtCtXE6BnBQNbTygmzAf8Tfirwwr8gzUBY2y6huYtRNF74uytvK1Xps xSs50xzDo1tJDH54+rI7BGVlJqyz1pEbHRNe9TX92+4NTMuuU1LmmT1wEDEoDa3WodnT QOhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Y2TplnQ9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i27si1954485ejk.580.2021.01.24.20.38.26; Sun, 24 Jan 2021 20:38:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Y2TplnQ9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726929AbhAYEgx (ORCPT + 99 others); Sun, 24 Jan 2021 23:36:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726791AbhAYEgv (ORCPT ); Sun, 24 Jan 2021 23:36:51 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE508C061574 for ; Sun, 24 Jan 2021 20:36:11 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id gx1so2112536pjb.1 for ; Sun, 24 Jan 2021 20:36:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Eqqx1gni4Q4abmvsdVexzq6eMIJu3GVUnZLPq6wIbFo=; b=Y2TplnQ9iYj65TLPlSyyE6QipJSeTh2Pj+iCGthqP1bCGfCKPVAXQAZtssww6b4Uu4 q55bCtBN04czu06KWVLIatzqCSavXLUQE7opvY/k4XIZQsJ0WoKOcZr1nYAuVXgyJbpq BIxlEAXuvk2UEBjGsc6o2kqx3qI5ByWXhUTuMGMHIQ/i0C60O157mzLjGnpmB9cFtvin iTsfY3lnwB/Z3hGYYPBV655TnZmENYxmnV+oC1Tw308HNRnNknu3RZKzJfTSi+Zu0swT hDgqgluDTyHRKyB0QR4EAHSjr+6uGIPtcvea6btppiItIs0UaN9KeKfc/C+82q6Ncm+P uM9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Eqqx1gni4Q4abmvsdVexzq6eMIJu3GVUnZLPq6wIbFo=; b=rZgx5rbq3lsvpdJzlp7R7+E3TkPVKQWzOW4WUM+o6pkkGMXzDrODXV64SdsrMHRQLc 9YvQp0AFG9svS3Ce5MF5iholKpMVtobz1soOEpqsOFTKVOHppjHMEyrzXOIC0aWcQS6k XrNHdCMkZhJm4UTSlk3qJx1eNDAPw6jFa4E+RnH//wl2qdNPflCuqC4TOy0xiqYeo+sb 10sjnoP3PYanB+UMJIlXifUBuuohXJQsoho0d9LNsd5vXCaAiCmNwr8ACyYUTOF+37kj +gvNXauvFJR2A+rIV+KheHWK6v9srqNMvy+PJdS4XtmaMQkU8E0ftvDjwaG33JydEj5k Ncnw== X-Gm-Message-State: AOAM532+xNOKK2Rg/xZhIC6MVAqDbyfMWBA2nN0ZfETFuYul2wZtu0d1 zLzilIsosE2WiaFs5+Z+GCsLt8PGSdmyPQ== X-Received: by 2002:a17:90a:dac6:: with SMTP id g6mr7759003pjx.178.1611549371102; Sun, 24 Jan 2021 20:36:11 -0800 (PST) Received: from [192.168.4.41] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id k9sm16243155pjj.8.2021.01.24.20.36.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Jan 2021 20:36:10 -0800 (PST) Subject: Re: [PATCH] block: Fix an error handling in add_partition To: Dinghao Liu , kjlu@umn.edu Cc: Jan Kara , Hannes Reinecke , Johannes Thumshirn , Ming Lei , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210117085023.24352-1-dinghao.liu@zju.edu.cn> From: Jens Axboe Message-ID: Date: Sun, 24 Jan 2021 21:36:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210117085023.24352-1-dinghao.liu@zju.edu.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/17/21 1:50 AM, Dinghao Liu wrote: > Once we have called device_initialize(), we should use put_device() to > give up the reference on error, just like what we have done on failure > of device_add(). Applied for 5.11, thanks. -- Jens Axboe