Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 24 Jan 2021 23:39:52 -0600
From:   Pete Zaitcev <zaitcev@redhat.com>
To:     Jeremy Figgins <kernel@jeremyfiggins.com>
Cc:     gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, stern@rowland.harvard.edu,
        zaitcev@redhat.com
Subject: Re: [PATCH] USB: usblp: don't call usb_set_interface if there's a
 single alt
Message-ID: <20210124233924.34d278fc@suzdal.zaitcev.lan>
In-Reply-To: <YAy9kJhM/rG8EQXC@watson>
References: <YAy9kJhM/rG8EQXC@watson>
Organization: Red Hat, Inc.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 23 Jan 2021 18:21:36 -0600
Jeremy Figgins <kernel@jeremyfiggins.com> wrote:

> Signed-off-by: Jeremy Figgins <kernel@jeremyfiggins.com>

> +++ b/drivers/usb/class/usblp.c
> +	if (usblp->intf->num_altsetting > 1) {

Acked-by: Pete Zaitcev <zaitcev@redhat.com>

I am having some misgivings about it, but let's see if it works.
At worst, someone will complain and we'll revert to quirks.

-- Pete