Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210122212229.17072-1-richard@nod.at> <20210122212229.17072-4-richard@nod.at>
 <5b51ff9c-8f5e-c348-5195-c0a0bf60b746@huawei.com> <cca6ac4f-4739-76be-9b48-b3643017a556@huawei.com>
In-Reply-To: <cca6ac4f-4739-76be-9b48-b3643017a556@huawei.com>
From:   Richard Weinberger <richard.weinberger@gmail.com>
Date:   Mon, 25 Jan 2021 08:55:34 +0100
Message-ID: <CAFLxGvyHL5AMWcfLQg2fS6Nbp255yjve5nJ83ELYHnPhKp6Wxw@mail.gmail.com>
Subject: Re: [PATCH 3/4] ubifs: Update directory size when creating whiteouts
To:     Zhihao Cheng <chengzhihao1@huawei.com>
Cc:     Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org,
        David Gstir <david@sigma-star.at>,
        LKML <linux-kernel@vger.kernel.org>,
        stable <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jan 25, 2021 at 2:12 AM Zhihao Cheng <chengzhihao1@huawei.com> wrot=
e:
>
> =E5=9C=A8 2021/1/23 10:45, Zhihao Cheng =E5=86=99=E9=81=93:
>
> >> @@ -430,6 +433,7 @@ static int do_tmpfile(struct inode *dir, struct
> >> dentry *dentry,
> >>       return 0;
> >>   out_cancel:
> Still one question:
> > Does this need a judgment? Like this,

The idea was that in the !whiteout case, sz_change is always 0.

--=20
Thanks,
//richard