Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3030993pxb; Mon, 25 Jan 2021 05:21:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJyt8K8cLdnPpgQxykfanJFvH7xzMhO9l+p7vY8JbTzlOKTra2rWjq9QvodMf0ZUmrutmwjG X-Received: by 2002:a17:906:958f:: with SMTP id r15mr347181ejx.360.1611580897012; Mon, 25 Jan 2021 05:21:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611580897; cv=none; d=google.com; s=arc-20160816; b=Ihn+GS/bORViHzNL/yQ29G8gvXRVLjjE9ak5wmc8V7ai8OutlQPsTCDdXEdxA9cw16 VTi8JnCMfyRDmRK4I7j62EX9g85x/rElf6ju+LsQg9+LCwh8oZaIqN71Xz3TtLFXFPXo MWIqpqB4avABg7G/vKFkM8a5fcr7eJ23djeXzVcfF+AtHRrlNQkXOJaMgh5s9Y9HOZwQ 3GBPT57VgcUZBL5WGWD0mVxSm0deCRqGxP3l1oVP0vF0h+Tb2BEq9Dv2AKMPQ99AIb27 3sxqduazEp5YJZXEcqpZtsf/zgaGJRwxQ6didRoiA2/+OK3X6Ne638dSYwL8N7MABApQ t5uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=YeRHqNmrouDWJP/xkxDkX2LI+peKn9k+q09qI8S2TU8=; b=iljOVcq+mFKjYrq1CxTVIjGqLgMJcRzXT9Maum5xDWb9jj/GSndm2z+SeNP1eHxlYu CkG+lTxMmhhTP8Duxg6YdKmywCVw+4JIfUgEiwbJNAALWI9hFjUa7Mj/ckd3/pFxasWm l/2o11/FI03k2DdsEELGzWPJRffS3d1aBfhteA7Us64INGxdwts22UoWjUR9r7SDKpmr f1moZbpYbWu5AHWyg/TpeVN1HhqDCKtSAkVq21qcxDzAhg6DPzf4brMLZJcqus/s8d2L o/PK7QWfND8rP3W4aFlDx0zRs1jApEZVhkLntAiWRKfR7h/q4AyW2UApGOuP7ZxyITnL MqRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dRVZmgfv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y6si7738821edp.196.2021.01.25.05.21.11; Mon, 25 Jan 2021 05:21:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dRVZmgfv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728691AbhAYNOj (ORCPT + 99 others); Mon, 25 Jan 2021 08:14:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728631AbhAYNKb (ORCPT ); Mon, 25 Jan 2021 08:10:31 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0D87C06174A for ; Mon, 25 Jan 2021 05:09:49 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id q12so17602946lfo.12 for ; Mon, 25 Jan 2021 05:09:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YeRHqNmrouDWJP/xkxDkX2LI+peKn9k+q09qI8S2TU8=; b=dRVZmgfvGhNAzk/IwBG53sc+pQ/aIk70Exr8NAd5htfE7TJ870KtfGQJ+l+P6uCCE4 /+B0cXnGctt84l20uGzfNPBJctSj8oXCYK+wGlTIm0yzims6GZ1aOY7iNP8cXqxVn5Bt jXJt0MLcwgi7Ydvx8am7ngO0e0b9WElQkR3hWotojQqRyoejRV6WtXULC3bAAdJwve1A bqiBs7ugsUPTjkQVNzh8sz7+33Nou6rMmH1/l7u8jRQJyKighLL3qfSN9b7yPSnzmrwH n+vgIoKr4txjpEO3dmQA3FAz3acdb2P/vnz+sIwaKxlc4YoW5iRw+/n4iO6+KnF5+i0b LXLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YeRHqNmrouDWJP/xkxDkX2LI+peKn9k+q09qI8S2TU8=; b=MGINLCKI0shWNWW2z/bmN7Uh74syHirHsUXWzw32Ergq7DQAi9Ze8mOc9hD93K3jit sINPO+9ftw7LzkHFj7TZT0TCV1icINYXrgcfGbOnU7593jcUNKD3tjMTZbl3NtY+MsWJ HlYcVlpo7n2mhMXR9trVlL6BaeBbMaafV2tcztrV3+aypHawLJyUdt8bWsWB/MXMfJF8 pcjNbTrx8xV+ToPf1H5G5ognxjbGfibfnvYhz5x5WtRx1gkMhUHnyQz8ERl3NUKxTYzf eGxoXCFYSJxpwyw3tglutzEgbYU2E9SJvBEVD4yVXJFlEGvTigqFen14jMdZ1oAZSsz6 9eaQ== X-Gm-Message-State: AOAM532p8MsKo4ZVXoVKmkWi2AiRocGxr7XKrEA5yBySUvJjBRCtIfQj DxRUHUS7Cgt7ln5ZQrSbkyOz3bcBc+wvackkNyX4lA== X-Received: by 2002:a19:b8e:: with SMTP id 136mr249156lfl.29.1611580188141; Mon, 25 Jan 2021 05:09:48 -0800 (PST) MIME-Version: 1.0 References: <20210125031946.1882-1-hailong.fan@mediatek.com> In-Reply-To: <20210125031946.1882-1-hailong.fan@mediatek.com> From: Linus Walleij Date: Mon, 25 Jan 2021 14:09:37 +0100 Message-ID: Subject: Re: [PATCH v2] pinctrl: mediatek: Fix trigger type setting follow for unexpected interrupt To: Hailong Fan Cc: Sean Wang , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" , Linux ARM , "linux-kernel@vger.kernel.org" , youlin.pei@mediatek.com, Nicolas Boichat , srv_heupstream@mediatek.com, chentsung@chromium.org, gtk_pangao@mediatek.com, Hanks Chen , yong.wu@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2021 at 4:19 AM Hailong Fan wrote: > When flipping the polarity will be generated interrupt under certain > circumstances, but GPIO external signal has not changed. > Then, mask the interrupt before polarity setting, and clear the > unexpected interrupt after trigger type setting completed. > > Signed-off-by: Hailong Fan > Reviewed-by: Nicolas Boichat Patch applied for fixes. Yours, Linus Walleij