Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] smackfs: restrict bytes count in smackfs write functions
To:     Sabyrzhan Tasbolatov <snovitoll@gmail.com>
Cc:     jmorris@namei.org, serge@hallyn.com, andreyknvl@google.com,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        syzbot+a71a442385a0b2815497@syzkaller.appspotmail.com,
        Casey Schaufler <casey@schaufler-ca.com>
References: <20210124143627.582115-1-snovitoll@gmail.com>
From:   Casey Schaufler <casey@schaufler-ca.com>
Message-ID: <3f33d3a2-c84c-081f-c1c4-424e5eeeb8d2@schaufler-ca.com>
Date:   Mon, 25 Jan 2021 10:08:04 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <20210124143627.582115-1-snovitoll@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
Content-Length: 2028
Precedence: bulk

On 1/24/2021 6:36 AM, Sabyrzhan Tasbolatov wrote:
> syzbot found WARNINGs in several smackfs write operations where
> bytes count is passed to memdup_user_nul which exceeds
> GFP MAX_ORDER. Check count size if bigger SMK_LONGLABEL,
> for smk_write_syslog if bigger than PAGE_SIZE - 1.
>
> Reported-by: syzbot+a71a442385a0b2815497@syzkaller.appspotmail.com
> Signed-off-by: Sabyrzhan Tasbolatov <snovitoll@gmail.com>

Thank you for the patch. Unfortunately, SMK_LONGLABEL isn't
the right value in some of these cases.=20

> ---
>  security/smack/smackfs.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 5d44b7d258ef..88678c6f1b8c 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -1167,7 +1167,7 @@ static ssize_t smk_write_net4addr(struct file *fi=
le, const char __user *buf,
>  		return -EPERM;
>  	if (*ppos !=3D 0)
>  		return -EINVAL;
> -	if (count < SMK_NETLBLADDRMIN)
> +	if (count < SMK_NETLBLADDRMIN || count > SMK_LONGLABEL)
>  		return -EINVAL;
> =20
>  	data =3D memdup_user_nul(buf, count);
> @@ -1427,7 +1427,7 @@ static ssize_t smk_write_net6addr(struct file *fi=
le, const char __user *buf,
>  		return -EPERM;
>  	if (*ppos !=3D 0)
>  		return -EINVAL;
> -	if (count < SMK_NETLBLADDRMIN)
> +	if (count < SMK_NETLBLADDRMIN || count > SMK_LONGLABEL)
>  		return -EINVAL;
> =20
>  	data =3D memdup_user_nul(buf, count);
> @@ -2647,6 +2647,8 @@ static ssize_t smk_write_syslog(struct file *file=
, const char __user *buf,
> =20
>  	if (!smack_privileged(CAP_MAC_ADMIN))
>  		return -EPERM;
> +	if (count > PAGE_SIZE - 1)
> +		return -EINVAL;
> =20
>  	data =3D memdup_user_nul(buf, count);
>  	if (IS_ERR(data))
> @@ -2744,6 +2746,8 @@ static ssize_t smk_write_relabel_self(struct file=
 *file, const char __user *buf,
>  	 */
>  	if (*ppos !=3D 0)
>  		return -EINVAL;
> +	if (count > SMK_LONGLABEL)
> +		return -EINVAL;
> =20
>  	data =3D memdup_user_nul(buf, count);
>  	if (IS_ERR(data))