Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3306568pxb; Mon, 25 Jan 2021 12:14:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJwwUEsSH/TOCnI6hC7YDX/flr9LJ5Z52xBTmy3X/5RKDL/j6g9RnKbxVnn5d3fx7MfVt5Ng X-Received: by 2002:a17:906:e09:: with SMTP id l9mr1435261eji.196.1611605679683; Mon, 25 Jan 2021 12:14:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611605679; cv=none; d=google.com; s=arc-20160816; b=WECuI8xjHeZaMJGWj0da0ZR//HKIRJPPSwaYrE2TWHnS0f3JAND3qKTyoOx0MluP13 renywoWee2K4iBQRzWNnwP1EPzgBzOOk7HflzZwY9lcbm8PVwO4HYv8qoa+b5/gG+Z/E MVbgJm5T/PUOol4ahoIlUajzsyjm3EG+/1FGhAuwm0dbn0Ms/0E9QcPb22+HJCvbk3HW 4n16fI+u7wj6Vw2Q4AEFHdWkeSdApK6cIMTLSUt6LiR6h6EjffrzXuTAnEm/6mhlbEzu 2GL83xu56X/4Z9phOvR+W5CiVvsDErBG5XnRwUiqmWFaXNvzy9iklKrrKJxe1iSTblaN 34rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:sender:dkim-signature; bh=EsmJo5oovzpiXmuqZ5cSfYBminZGw3Bg63uNHCPKszo=; b=wF10SIZr/jlD0BjGLLOf2ydpmnPypG5D8sWj3K8lcA1EXNWg53HXFRyBx3yv0wCtmm hh2gja9Tfhw6HhTyfqI7U3JlsYW2v/p1CYNJGvvij813laMm02/Q+EqDqiLe0sPbzHQR 49yU5lZFsBsMcs6PUT3fzqfeyFoBuewXIZuQ5nbN6anzmNluquDrhPX1Tt51uR+WdWuJ QCIhjOIBeudIryVyiBgWEmd8U681gCTlT+/N/ibFpZi5PK1CIBGZEaanzbqMnwUGZFhQ yaJOnZLG7QVqLswrXQLlBdWOCnMxpvWXxtOpk0tb24hQpF9Gea67wEBbAQAj3JFG3Z6m 9UCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ENSG3oZS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d4si5766326edu.106.2021.01.25.12.14.14; Mon, 25 Jan 2021 12:14:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ENSG3oZS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732250AbhAYULS (ORCPT + 99 others); Mon, 25 Jan 2021 15:11:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732240AbhAYUIq (ORCPT ); Mon, 25 Jan 2021 15:08:46 -0500 Received: from mail-qv1-xf49.google.com (mail-qv1-xf49.google.com [IPv6:2607:f8b0:4864:20::f49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DBE3C061574 for ; Mon, 25 Jan 2021 12:08:01 -0800 (PST) Received: by mail-qv1-xf49.google.com with SMTP id a12so1771074qvo.11 for ; Mon, 25 Jan 2021 12:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=EsmJo5oovzpiXmuqZ5cSfYBminZGw3Bg63uNHCPKszo=; b=ENSG3oZS14wDgHi3pz1j8HF5s1yaseO5q088aeOljcRi0mhRWG8GFqZoY64FFpGKHz Ehh0As5KPGIsykN2tP9K/cW1Mx7tYXboztSO25LumKZlfsa04jw093aDne2S45EAkTvW 8KTMdHG8I0f+yryjY1/p2OAICg5Q86DPpl9Zzax2POqYCRsqnhDlGmzNevSNqj7S8VmM 2hNb/FJX2dZ1IJUcbPSckd64Tj+kfkQsVh7+shwh6EMgI487xNNck/TbjNvLzt0itjpw a+ekZZzaLHxe8KbdSqqedb9D3a2VpLuS2sUl9v4h8Yc6QRZwZf6MHNgysvPGgTuF0hup r64Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=EsmJo5oovzpiXmuqZ5cSfYBminZGw3Bg63uNHCPKszo=; b=Zwhaof3O0yk8cvq+qG4PZDy3SA7x8liGZjvOhr0Y1MEIMf96lL5itI7aoFlMpApmWJ 4+U+gr5hVf0TY0JU/Rh+31gtK5oW2yWhUSzonRGLqYNZTOw2lAxCB1HCd9/YDtFJ2fJ8 yC17CQR1MsBujh7fLbblfu2npZ95Qw+jfbV328Glo3xfmtw3aqA+If2gAopJQrAkBuJI oHKcOp7MC8GVsStK4bY+ShLa9gBztAtrJwAmuUQbs6tnEfcw3x0JSKxb9w75o4mSOoy3 TDO+1WqYNRl1O6JYJy7iNlzcycMU++VTs7GGJLzYmxoKcNtkyEwUrRqFPOreZtrLSo2k 4lVw== X-Gm-Message-State: AOAM533dOKhCc/AeAZegI8tNl5Z/NsKYZ6hM2L1ktcDwk4jfQQiFO6Gf C8iec576rJKPWTaa283EDynZvI7MRjQ= Sender: "oupton via sendgmr" X-Received: from oupton2.c.googlers.com ([fda3:e722:ac3:10:7f:e700:c0a8:136]) (user=oupton job=sendgmr) by 2002:ad4:580f:: with SMTP id dd15mr2428478qvb.40.1611605280552; Mon, 25 Jan 2021 12:08:00 -0800 (PST) Date: Mon, 25 Jan 2021 20:07:56 +0000 In-Reply-To: <20200914133626.hlsvu5kces3wsirr@google.com> Message-Id: <20210125200756.1249239-1-oupton@google.com> Mime-Version: 1.0 References: <20200914133626.hlsvu5kces3wsirr@google.com> X-Mailer: git-send-email 2.30.0.280.ga3ce27912f-goog Subject: Re: [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe From: Oliver Upton To: dbrazdil@google.com Cc: hns@goldelico.com, linux-kernel@vger.kernel.org, maz@kernel.org, sashal@kernel.org, Oliver Upton Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > That means we have two options: > (a) define __hyp_panic_string in a different .c file in all pre-5.9 branches, or > (b) revert the backported patch. > > The patch was needed in 5.9 and should stay there. It wasn't needed in earlier > versions because the symbol was being kept alive by another user. It did "fix" > the inline asm semantics, but the problem was never triggered in pre-5.9. > > Sasha, with this and the GCC bug in mind, would you agree that (b) is the > better course of action? Sasha, Any chance we can get this patch reverted as David has suggested? It was backported to 5.4 LTS in commit 653ae33b030b ("KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe") and is causing build issues with a 4.9.4 vintage of GCC. Thanks! -- Oliver