Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 25 Jan 2021 21:26:10 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, j.neuschaefer@gmx.net
Subject: Re: [PATCH] ARM: dts: imx6sl-tolino-shine2hd: Add Netronix embedded
 controller
Message-ID: <YA8pYv1944Y7uaT0@latitude>
References: <20210124214127.3631530-8-j.neuschaefer@gmx.net>
 <20210125190804.12552-1-andreas@kemnade.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kTqtERsJ9y+2H155"
Content-Disposition: inline
In-Reply-To: <20210125190804.12552-1-andreas@kemnade.info>
Precedence: bulk


--kTqtERsJ9y+2H155
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 25, 2021 at 08:08:04PM +0100, Andreas Kemnade wrote:
> For now, the driver detects an incompatible version, but since
> that can be handled by auto-detection, add the controller to the
> devicetree now. Only PWM seems to be available, there is no RTC
> in that controller.
>=20
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---

Reviewed-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>

>  arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts b/arch/arm/boot=
/dts/imx6sl-tolino-shine2hd.dts
> index caa279608803..c26bc5e10593 100644
> --- a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
> +++ b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
> @@ -97,8 +97,11 @@ &i2c1 {
>  	pinctrl-1 =3D <&pinctrl_i2c1_sleep>;
>  	status =3D "okay";
> =20
> -	/* TODO: embedded controller at 0x43 (driver missing) */
> -
> +	ec: embedded-controller@43 {
> +		compatible =3D "netronix,ntxec";
> +		reg =3D <0x43>;
> +		#pwm-cells =3D <2>;
> +	};

Looks good.


Thanks,
Jonathan

--kTqtERsJ9y+2H155
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmAPKUoACgkQCDBEmo7z
X9u9ag//S/K5DO3ayaScrll9NlC74fZcgRkDT5nttrbR2oI2+Sek0ed+0S3jCAXJ
JkkPbjLUhIKLc3dzANimLEmmG6BNTdANoz0kHMWNMg3tqgf2MaHeIS2mGFKKs+FT
xtnfezH1ZXNUpONGIk+fp9KvDLibSsflQZyyR32F+OqWH7GpXcmi8Gaz6kk1jxmk
qsPpqRcB3RiFJjkeywnacOoS+zoRw4eOthu2KunHTQodNH/oFhQF47GD+mNUOrlT
NCvapl6RbRWB3NNvHSWmNmpoVSuMkFXwC/dShAtVpaVd0NmuxonXw+4MpP1KoBmi
K+piVAv8jmf3PMSDLZY15ShowDplIgwqmtKiVpMEqkD3uiaKu5xT245v/1yhLcr6
ja9kKuTP853VIs2zjqrC2wIWEFmd979WofnR9Oev5uE4WP/iY5dbIp7Ny3iZSyl7
3oytpKKvIaj9kRbAqvWnpA6ZoHksu3/bXWaDAMe4HbZDukfeczKnfF1Xgb0mbIhQ
PkY8kStCSXmg+91JryzEFkMP5WhgjYCqUV3ibx5vcBnUM4Bg40/lZmS7TGlZUJIM
YSPTiFY0cOyyh5ZXDCUPk2GHl9lLxuDj7/SvI4eDb/rREbcqUGwck4HNYTlh7FSH
/fitjSt+2r2ypFs16yKg3S/+Exm9iCRW+qjyK220WvBxeaiUd4o=
=Jnph
-----END PGP SIGNATURE-----

--kTqtERsJ9y+2H155--