Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3364193pxb; Mon, 25 Jan 2021 14:06:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJwM8Um3vzQAw+z3fSbVbC4NDRlGRzAfnoC2OMn5BlJbHxjypa7DggvGzG0Gba3X61tyLbxw X-Received: by 2002:a17:906:7947:: with SMTP id l7mr1652028ejo.5.1611612381115; Mon, 25 Jan 2021 14:06:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611612381; cv=none; d=google.com; s=arc-20160816; b=T0V1FsrtRVG5VLd7IXiFh2qn3aACm/0/lfkUb9n+YuMCt6H3jYqtPLZozaLYlUTV3R dmWGGYKjNN3C/e5yK8juXLTvclaBDIythFOM1Zd43Azx91h9+IkwQFHuxJr7hW2zRV5P z2ioKvzd9o7zmu3glBuAjjM+ZqYKirJp9JrAb+E2iJRS52KJhMlVkf/hG6yUs6rNJJiL aybvwFfpsZmlAgc1/ADkFJrGcY2tUnwu99qBW0g8lpCHxvhcUwAbVjhl6qp3oSsL+5dl iFeEbk4eWWR3EPYy9VJQC26Wg2EY7rY2dghO6W4ndkcOXDNn82Mp+zdk4QDEM+ux+zR2 uCvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9uTkelnkgdH1/h1qSEC3+KB2ZZOMZMIqxRYnkoanZM4=; b=T/c9qBObM+UDbGsDyEN2diuX402sXz12sW1PeTikPZ4bU/IwPq4r8wdX1tblflPAmX CcSUSMqZCjQsg2wwRrNSczEw2CKit9hSot0LZOb5ewoTOA4n3jXJKd9fW+Sys97XmuWn eNPigleNot87iPT7NZxebABDC2033COaT3PNnYI4pHR7I6YP8HFv/cTOFBKg0HzeE0gP 5wISWgLB+9Ax7EY5sgIb7sCvVk3ptTtSuEdbdssCxvd+4jBTSndgMT6mbW6yTq0eb7ge YOiyqi/c6pwchxyFKDh9LPqn2F07k+Jpj2Wt5lhQQb3MERnDBsQsCRuH2g1wM3Q3x3Wb Pp6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=e48pg2fn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r9si6363522ejb.411.2021.01.25.14.05.56; Mon, 25 Jan 2021 14:06:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=e48pg2fn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733111AbhAYWFW (ORCPT + 99 others); Mon, 25 Jan 2021 17:05:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733205AbhAYWDt (ORCPT ); Mon, 25 Jan 2021 17:03:49 -0500 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A7D3C06174A for ; Mon, 25 Jan 2021 14:03:09 -0800 (PST) Received: by mail-pf1-x429.google.com with SMTP id j12so9185917pfj.12 for ; Mon, 25 Jan 2021 14:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9uTkelnkgdH1/h1qSEC3+KB2ZZOMZMIqxRYnkoanZM4=; b=e48pg2fnQuL945QN5H8Vqv7bjX7l4CQIY5iNiZMX75XZLI2m+HxbhLqfsgNifpr/SZ qaR8nCtuU+N+h4snOkvPLNyDR8PxaMl8kXfvWPiXP/auSxLP+ru06vivV0yQ5r/mJqDh Pq1GsRCAqqvXIL7IvnbcFpPZJMU3JssEpiHKo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9uTkelnkgdH1/h1qSEC3+KB2ZZOMZMIqxRYnkoanZM4=; b=f2TYCv01wn//6ShnkZvSA/Ar4d8jYAx7dvdVEHtrcU9N8k5SXCHvZufLEimcrdvJIE aqpMQzOhWWEd6y1PHU0x9jPVlvFxK/Ka1cklTp6co5TvRSzPYb1Q7LGnJz7KOxKsPdfv Eeet9VqmwxdIk7TezoYcApOd0GuyMuFEXrhbcaiZ+vZCl8THJXzd8BP+NwyMRskNlwF/ dIOY9zrJ2VEOLLqTMUTHG3NtRTe445VCLSBz4gBaE2qYspOoqjKdVVD6dBie119xy+b4 SS218c0TS8fSR5pNdZRUFDSA8WHvEt0miDUnLJW3o2/B1/SyhEzoWpOaemv8GWWleH47 aG8g== X-Gm-Message-State: AOAM5305mM1T2p9MvR60XdJ0re+CB90vsY3UgR2pPpcLZuqc/i7l98tM XONBoLJBmPs4I56uB8RhOC53lv0VeCCWKg== X-Received: by 2002:a63:5d5f:: with SMTP id o31mr2597849pgm.295.1611612189024; Mon, 25 Jan 2021 14:03:09 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a131sm18614270pfd.171.2021.01.25.14.03.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 14:03:08 -0800 (PST) Date: Mon, 25 Jan 2021 14:03:07 -0800 From: Kees Cook To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, Masahiro Yamada , Michal Marek , linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org, Peter Zijlstra , Justin Forbes , Ondrej Mosnacek Subject: Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules Message-ID: <202101251401.F18409FDD1@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2021 at 02:42:10PM -0600, Josh Poimboeuf wrote: > When a GCC version mismatch is detected, print a warning and disable the > plugin. The only exception is the RANDSTRUCT plugin which needs all > code to see the same struct layouts. In that case print an error. I prefer this patch as-is: only randstruct needs a hard failure. The others likely work (in fact, randstruct likely works too). Masahiro, are you suggesting to be a hard-failure for all plugins? -- Kees Cook