Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3504110pxb; Mon, 25 Jan 2021 19:09:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJyXc4jhrRQF5q4DyjmyFh8MKpFIBY/jEmKmhH5M0CLfnuuMQOo1uWS53e9d2HewxaUcUled X-Received: by 2002:a17:906:a00e:: with SMTP id p14mr2160188ejy.532.1611630559759; Mon, 25 Jan 2021 19:09:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611630559; cv=none; d=google.com; s=arc-20160816; b=xh9884RsWBKp9felREx6o3bZ8dzkvjw32ghdGXZtFim/0mtb6PoG12DFKXiKS1kvjc obFqX9z+j+P4XO+RFfs3ifUqz2mdo7qg/zsD+WtQz5HqKox0zKhnUwDFDLnsiA+ElR7n jo+DxXKuelW9xYs/42wTlPpdJzZy5fm4zbMzutHckPQIAgIm6I/s4lag9zGU19ULnmR1 F9SGTbXOo3ngXC7X+btTNa7Bbraiqhh3vkSXedV5/uzYYUWbOzVqp2XyR48Lqbow7mQq eTfb0BA7sAKW7Es2bmPKhIzKvfCbJOnAvJdNZe2QzGtW4tSAqRwS++D61pPvzHw4D1Bs URwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version; bh=1ApuYaYPip8axFvjvOCCJ3+WeJ/YyKgN3HxjbvXrHno=; b=RIiUnAIVQatrrdVws5vz9tQ5fy69+Nq/psTH4gWh1rLmO3af+irf7A+d0tra9rOcME mbYlVlHgaYjTCEDWpzEmT2TzB2cGgD2QOW2T2At9iBo7lfU7xwX/cVmml6NGTacrt9ul lnNwtQ24W0MDn5zgITZbDsFAj0MqKyRhf06XzUcEpufefHQi68p1nKbVN6HuM8s/xh7h EJxzRpImk8A6tSadk3FMJu/H6TRzjIS3PR7a6ypGhUI/YL7+IOZuvPPg1z/ijBA8LnlM 9NjGdSG+GN9/sNMiJXCvEBSxS5u2YPmALO+8Ag6uTXTlDJlZ5ZraMuCkVzkTjwc+Pcq+ iYYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu13si6398990ejb.588.2021.01.25.19.08.55; Mon, 25 Jan 2021 19:09:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728525AbhAYNAA convert rfc822-to-8bit (ORCPT + 99 others); Mon, 25 Jan 2021 08:00:00 -0500 Received: from mail.fireflyinternet.com ([77.68.26.236]:58697 "EHLO fireflyinternet.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728453AbhAYMxf (ORCPT ); Mon, 25 Jan 2021 07:53:35 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 23692793-1500050 for multiple; Mon, 25 Jan 2021 12:34:39 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT In-Reply-To: <20210125122542.4144849-1-arnd@kernel.org> References: <20210125122542.4144849-1-arnd@kernel.org> Subject: Re: [PATCH] drm/i915/gem: fix non-SMP build failure From: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Arnd Bergmann , linux-kernel@vger.kernel.org To: Arnd Bergmann , Daniel Vetter , David Airlie , Jani Nikula , Joonas Lahtinen , Matthew Auld , Rodrigo Vivi Date: Mon, 25 Jan 2021 12:34:40 +0000 Message-ID: <161157808017.27462.17791510835963619576@build.alporthouse.com> User-Agent: alot/0.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Arnd Bergmann (2021-01-25 12:25:34) > From: Arnd Bergmann > > The x86-specific wbinvd_on_all_cpus() function is exported > through asm/smp.h, causing a build failure in the i915 driver > when SMP is disabled: > > drivers/gpu/drm/i915/i915_gem.c:1182:2: error: implicit declaration of function 'wbinvd_on_all_cpus' [-Werror,-Wimplicit-function-declaration] I thought the code was already in i915_gem_pm.c (which included smp.h); it is now. -Chris