Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3558389pxb; Mon, 25 Jan 2021 21:22:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJyRRPvS0wEUo85xHqkJVNU8AkZTIi9rDREcrqkU0Yb+USnSdDpWO1/V5qvtlbb7UJsCST87 X-Received: by 2002:a05:6402:212:: with SMTP id t18mr3221231edv.37.1611638523518; Mon, 25 Jan 2021 21:22:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611638523; cv=none; d=google.com; s=arc-20160816; b=FqeZSqDQlOlLxsu9wvze9qV9+BZjCzeKHafACVrn+po3aEn+DheJW/s4r+HX+mMQ0r LRfademv8o2UO6TQt82rkBr1oczOqAhyRVXjKs3G205vda9pG0oFbm6OefSMW4tjP3hS 2a2i4I6DUeBjqtvw/Et/jEzpmLGsinsastZPhU7HuLPHMMN7KelR0RGOdK/mhSw6R8b6 3BLIdoWfGOa746VpcUX7StqumhiRMHBmROq03WP/k9kBW/3STA3swElQCjgSl3dKRTIK KDKv3U17li8UHQEX2vS28zgYycMz6nw8vFCaDuW02hCY7d5ThQsKFkdroKJgxkPnkhRr c6sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=/nJSuiZAoYdH3Vop1HcyZUiGEH6an9N7F91nAI763k4=; b=0ulLSlNdkHATyL3JSGfg5WAl/On/AVoYc9wsKDaaXe4rzGhxvTFMm2OsBNzo4b1TAw vS8x/iqF0JiGq5SWSby8SrSDbIK22woE2VkUhD/4thv+Tnv0tw8u54uIH6LIKItQnfSc qnH2C8UT7h8Y72oFUQXUYC4JahlMjfNRTVy18vnQOTPieOhv4JBGzSHVhcLrNU9zbusA xxTONOUVdG/eiB3HedkLmWCMpPNa2ERmvfXaBxyO9H0C3O4cJ2k08tCNDfKiGnFszikh xrQLrtDzU9JlENNp0sW1uSnQnE2WAQcyRE85ZPmalH5sST1r+TjaiVf71FzklSv0nh0V h42A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga8si6612907ejb.614.2021.01.25.21.21.39; Mon, 25 Jan 2021 21:22:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732227AbhAZFUm (ORCPT + 99 others); Tue, 26 Jan 2021 00:20:42 -0500 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:60874 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727213AbhAYJtR (ORCPT ); Mon, 25 Jan 2021 04:49:17 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UMpfQ7-_1611568047; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMpfQ7-_1611568047) by smtp.aliyun-inc.com(127.0.0.1); Mon, 25 Jan 2021 17:47:52 +0800 From: Yang Li To: davem@davemloft.net Cc: kuba@kernel.org, rajur@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH 2/4] cxgb4: remove redundant NULL check Date: Mon, 25 Jan 2021 17:47:23 +0800 Message-Id: <1611568045-121839-2-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1611568045-121839-1-git-send-email-abaci-bugfix@linux.alibaba.com> References: <1611568045-121839-1-git-send-email-abaci-bugfix@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c:3558:2-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c index 75474f8..94eb8a6 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c @@ -3554,8 +3554,7 @@ int cudbg_collect_qdesc(struct cudbg_init *pdbg_init, } out_free: - if (data) - kvfree(data); + kvfree(data); #undef QDESC_GET_FLQ #undef QDESC_GET_RXQ -- 1.8.3.1