Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3558788pxb; Mon, 25 Jan 2021 21:23:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwWjJIVPxaw9GnPlvvid/FOlw55OWYCu4BAhfqRxS9kb0lCNTZSV1WcZBDvl1dNOV6MCkGk X-Received: by 2002:aa7:de8f:: with SMTP id j15mr3327273edv.268.1611638591944; Mon, 25 Jan 2021 21:23:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611638591; cv=none; d=google.com; s=arc-20160816; b=wmUJU/RN5oTTWk4f5YUt1Gzb3H4jokeaHccaTXhdZ8c0487Knzp8rUvT2wEpy2YefV aAZ2d+keNiip9OKsRxBUF/zRGWklC3zmf9FdC0rs8ff6BKrP0YIREeEQyAr/nhOETu3k kpllFD0ohaovmf+dEsLyNKrJxlDfJeMKQHRNvUW5TAvetBnBiaLf/5zOPzqYzOdGdcZW ypWH1CA3W98K/UyGSUhtNa4FC0EsKzPMSq4EGcEmqiZf04juVzSU1sqZfPTL0ZC3GJGw hf5n+ee0ITQUeD7FF+ju6PO3IpriFLBYuZ55FYGc8VrlUGjL5JJwqHxxsOpaE5YGUmjG QtgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=v4Sr274zDnVUru0iYaEtNVw6x9HJPzAkZx/KRhimcsw=; b=g2BoG6D4Sk4GZ8t9fecVet3gwdc0DiXLHwMNal5NDx8yLY4L5Ri4GfuAZmtuUEki4m TJizKJmmT51vE7nb8vHAOcIvfVcxxUxWcMbmYQkgzPuXNE3DL39o1qXowljLAAKYhiSd /GRVsA5D9zdp13g1YxggBtTP7ByX5UiCFNkyYpZxcYMjKBH+IeaqDfiPR9WJCjZ84ePW YejAabyoQorlkipJ3tzeCzAtgP3RvJvj7B51MEMZQFDddk2nXD8w8MFMDjYs0bWR72Gi Rjq3FupcUo/w1/bKbxbXKzNHJh3qVveTyP0JfrpEbzQL+R+JkSUJqYSFEQU5aMMA/M7V Mc7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q1si8254868edi.331.2021.01.25.21.22.48; Mon, 25 Jan 2021 21:23:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732081AbhAZFU1 (ORCPT + 99 others); Tue, 26 Jan 2021 00:20:27 -0500 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:60303 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727111AbhAYJsv (ORCPT ); Mon, 25 Jan 2021 04:48:51 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R611e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UMpfQ7-_1611568047; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMpfQ7-_1611568047) by smtp.aliyun-inc.com(127.0.0.1); Mon, 25 Jan 2021 17:47:54 +0800 From: Yang Li To: davem@davemloft.net Cc: kuba@kernel.org, rajur@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH 4/4] cxgb4: remove redundant NULL check Date: Mon, 25 Jan 2021 17:47:25 +0800 Message-Id: <1611568045-121839-4-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1611568045-121839-1-git-send-email-abaci-bugfix@linux.alibaba.com> References: <1611568045-121839-1-git-send-email-abaci-bugfix@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:533:2-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c index dede025..97a811f 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c @@ -525,12 +525,10 @@ struct cxgb4_tc_u32_table *cxgb4_init_tc_u32(struct adapter *adap) for (i = 0; i < t->size; i++) { struct cxgb4_link *link = &t->table[i]; - if (link->tid_map) - kvfree(link->tid_map); + kvfree(link->tid_map); } - if (t) - kvfree(t); + kvfree(t); return NULL; } -- 1.8.3.1