Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Saurav Kashyap <skashyap@marvell.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Nilesh Javali <njavali@marvell.com>
CC:     GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Himanshu Madhani <himanshu.madhani@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [EXT] [PATCH] scsi: qla2xxx: fix some memory corruption
Thread-Topic: [EXT] [PATCH] scsi: qla2xxx: fix some memory corruption
Thread-Index: AQHW8vZQqe0wROdeNU6MRb6tZasxpqo4GW/A
Date:   Mon, 25 Jan 2021 09:52:27 +0000
Message-ID: <DM6PR18MB303455B3BC025E7F82469A4AD2BD9@DM6PR18MB3034.namprd18.prod.outlook.com>
References: <YA6E0geUlL9Hs04A@mwanda>
In-Reply-To: <YA6E0geUlL9Hs04A@mwanda>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 207da384-2975-499b-5cc5-08d8c116ec6f
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2021 09:52:27.2168
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YQ3RtI/LiOQOGmFA1lnr6OoSe2Fy85IVXb3CrvKwGSVPHHfYfUuBeTPKV5GCyomI4favd2IJxemfDWFRExN8XA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3722
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737
 definitions=2021-01-25_03:2021-01-22,2021-01-25 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dan,
Thanks for a patch.

> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Monday, January 25, 2021 2:14 PM
> To: Nilesh Javali <njavali@marvell.com>
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@marvell.com>; James E.J. Bottomley <jejb@linux.ibm.com>;
> Martin K. Petersen <martin.petersen@oracle.com>; Himanshu Madhani
> <himanshu.madhani@oracle.com>; Saurav Kashyap
> <skashyap@marvell.com>; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [EXT] [PATCH] scsi: qla2xxx: fix some memory corruption
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> This was supposed to be "data" instead of "&data".  The current code
> will corrupt the stack.
>=20
> Fixes: dbf1f53cfd23 ("scsi: qla2xxx: Implementation to get and manage hos=
t,
> target stats and initiator port")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bs=
g.c
> index e45da05383cd..bee8cf9f8123 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -2667,7 +2667,7 @@ qla2x00_get_tgt_stats(struct bsg_job *bsg_job)
>=20
>  		bsg_reply->reply_payload_rcv_len =3D
>  			sg_copy_from_buffer(bsg_job-
> >reply_payload.sg_list,
> -					    bsg_job->reply_payload.sg_cnt,
> &data,
> +					    bsg_job->reply_payload.sg_cnt,
> data,
>  					    sizeof(struct
> ql_vnd_tgt_stats_resp));
>=20
>  		bsg_reply->result =3D DID_OK;
> --

Acked-by: Saurav Kashyap <skashyap@marvell.com>


> 2.29.2