Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 25 Jan 2021 14:19:35 +0100
From:   Michal Hocko <mhocko@suse.com>
To:     Suren Baghdasaryan <surenb@google.com>
Cc:     linux-man@vger.kernel.org, akpm@linux-foundation.org,
        jannh@google.com, keescook@chromium.org, jeffv@google.com,
        minchan@kernel.org, shakeelb@google.com, rientjes@google.com,
        edgararriaga@google.com, timmurray@google.com, linux-mm@kvack.org,
        selinux@vger.kernel.org, linux-security-module@vger.kernel.org,
        linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@android.com
Subject: Re: [PATCH 1/1] process_madvise.2: Add process_madvise man page
Message-ID: <20210125131935.GI827@dhcp22.suse.cz>
References: <20210120202337.1481402-1-surenb@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210120202337.1481402-1-surenb@google.com>
Precedence: bulk

On Wed 20-01-21 12:23:37, Suren Baghdasaryan wrote:
[...]
>     MADV_COLD (since Linux 5.4.1)
>         Deactivate a given range of pages by moving them from active to
>         inactive LRU list. This is done to accelerate the reclaim of these
>         pages. The advice might be ignored for some pages in the range when it
>         is not applicable.

I do not think we want to talk about active/inactive LRU lists here.
Wouldn't it be sufficient to say
Deactive a given range of pages which will make them a more probable
reclaim target should there be a memory pressure. This is a
non-destructive operation.

Other than that, looks good to me from the content POV.

Thanks!
-- 
Michal Hocko
SUSE Labs