Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3709570pxb; Tue, 26 Jan 2021 02:43:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJytFw2AayrxVsodWZWqFhmZKCh/ktl2VVpXK4oRriiGXRXf06ytwcXwlvK5ktCvwj2C+ozx X-Received: by 2002:a50:eacd:: with SMTP id u13mr4035245edp.382.1611657816994; Tue, 26 Jan 2021 02:43:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611657816; cv=none; d=google.com; s=arc-20160816; b=ZCpCWJDqS/kC01KbYuP6j5Zv+Z11R5gxvge763ydGpcnd3LhfIb8HCE7obON4q/RJM EDTNE5Hmj149EW1soEy7lTrhKapyojjoeV3vDwvYP2nVdDU9Top3lspwnjsQyRKYKhUQ JMjLt3hKRSW+oOHAmX5WAQyOh6/KGhslNTiS7zd3koYmQxWINFUjz98djppdTrp5i2oI 33X0EU5CLCCiY20ZeSAfjIRClLWYQwwsmZiRxv0+267nlnChFZnQTY9eRGLOsiK27NLp Z8IusXmknAqubUPzDjOLWPQOl6wGmq1oOluxmxGce/ZHA0s/yIsYRdoSl8EgNAVxagdm IoEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oP2TIidX81eGT1h2x2myyqVlxaXwQ5UVYXVVX5Ngep0=; b=d1MCz65cIb61FQOgmDJ2+MpNn+z3AreFudChyrF7U5mzfKKqLAlRNUzQ/e8aLbq0Nr rqRsUf4uKZ30B1QIL2E4b+V19Kh1Z93dbjlg06K9bmlWi0WtCi4C4T9rvOxbFCgnY4ie nW/Txn8Mj3VLWHw6+5hmewCpmiy+ENgrCcDMjFRdvwyk+HbibmHFeld0MPDe3XGiuuQi zM81gkk3LfumA1Ps9AOySlHvMWY9zqAHMfxWPujcilKrTd4426xyG5V+3GCKB1ISA8fS XcKM08DepFfaodoegtDQNEycLEZh2lFglNgRyxi+ocQP4R9eBsfNLFfuEKkf1lscrK2e Dc7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alliedtelesis.co.nz header.s=mail181024 header.b=h+YiTMWs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alliedtelesis.co.nz Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y6si8965201edp.196.2021.01.26.02.43.12; Tue, 26 Jan 2021 02:43:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alliedtelesis.co.nz header.s=mail181024 header.b=h+YiTMWs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alliedtelesis.co.nz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404278AbhAZKlf (ORCPT + 99 others); Tue, 26 Jan 2021 05:41:35 -0500 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:48945 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732031AbhAZCDd (ORCPT ); Mon, 25 Jan 2021 21:03:33 -0500 X-Greylist: delayed 637 seconds by postgrey-1.27 at vger.kernel.org; Mon, 25 Jan 2021 21:03:32 EST Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 14A1283646; Tue, 26 Jan 2021 14:52:02 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1611625922; bh=oP2TIidX81eGT1h2x2myyqVlxaXwQ5UVYXVVX5Ngep0=; h=From:To:Cc:Subject:Date; b=h+YiTMWssfTinGHD8tqDCQYgSS5axw4LFeegeYEH4pU+Ro3vr63wmG4O5Sregpto7 sqAXeHBp/7uTcONZcXDLRojaXsApegUg4n+zFkVGlMGtK2oQBj0wJrgXViOuP0OA2A oPUQsoMMqy6jbLZWdEVDGCCQqeXZ4XqE8p5YkoY/OP3AWZ+vDf0ze9LduqCv/mq+vP THoZAimk3DyIKaegsBOpHMukbNdL8oGNPGv2N+z/0hHyfLetUt+aCYKAVtD2MMJtQW KNfXSO0m39xZSV5mwOZZQE1VYA2EKVXsMOax2dA4kJjOU/Z69QXjae5bCIqJrayk+5 Nuj4Gp+joQFdA== Received: from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with Trustwave SEG (v7,5,8,10121) id ; Tue, 26 Jan 2021 14:52:01 +1300 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.20]) by smtp (Postfix) with ESMTP id E3FD013EECA; Tue, 26 Jan 2021 14:52:03 +1300 (NZDT) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id D2917288C85; Tue, 26 Jan 2021 14:52:01 +1300 (NZDT) From: Chris Packham To: robh+dt@kernel.org, frowand.list@gmail.com, arch0.zheng@gmail.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Packham Subject: [PATCH] of/fdt: Check against '/chosen' in early_init_dt_scan_chosen Date: Tue, 26 Jan 2021 14:51:59 +1300 Message-Id: <20210126015159.23923-1-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable x-atlnz-ls: pat Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_scan_flat_dt() passes the name of the visited node to the iterator. In the case of '/chosen' this includes the leading '/'. Update early_init_dt_scan_chosen() to expect this. Fixes: 7536c7e03e74 ("of/fdt: Remove redundant kbasename function call") Signed-off-by: Chris Packham --- drivers/of/fdt.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index feb0f2d67fc5..861aedf0bb7c 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -1043,7 +1043,10 @@ int __init early_init_dt_scan_chosen(unsigned long= node, const char *uname, pr_debug("search \"chosen\", depth: %d, uname: %s\n", depth, uname); =20 if (depth !=3D 1 || !data || - (strcmp(uname, "chosen") !=3D 0 && strcmp(uname, "chosen@0") !=3D 0= )) + (strcmp(uname, "chosen") !=3D 0 && + strcmp(uname, "chosen@0") !=3D 0 && + strcmp(uname, "/chosen") !=3D 0 && + strcmp(uname, "/chosen@0") !=3D 0)) return 0; =20 early_init_dt_check_for_initrd(node); --=20 2.30.0