Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: cang=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 26 Jan 2021 10:10:31 +0800
From:   Can Guo <cang@codeaurora.org>
To:     Avri Altman <Avri.Altman@wdc.com>
Cc:     Bart Van Assche <bvanassche@acm.org>, jaegeuk@kernel.org,
        asutoshd@codeaurora.org, nguyenb@codeaurora.org,
        hongwus@codeaurora.org, linux-scsi@vger.kernel.org,
        kernel-team@android.com, Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: Fix some problems in task management
 request implementation
In-Reply-To: <DM6PR04MB65754B0CF70B9A3EB036D157FCBD9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <1611199388-24668-1-git-send-email-cang@codeaurora.org>
 <DM6PR04MB65754B0CF70B9A3EB036D157FCBD9@DM6PR04MB6575.namprd04.prod.outlook.com>
Message-ID: <6362e6f2117237b934eea44f700fd13a@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-01-25 19:36, Avri Altman wrote:
>> Current task management request send/compl implementation is broken, 
>> the
>> problems and fixes are listed as below:
>> 
>> Problem: TMR completion timeout. ufshcd_tmc_handler() calls
>>          blk_mq_tagset_busy_iter(fn == ufshcd_compl_tm()), but since
>>          blk_mq_tagset_busy_iter() only iterates over all reserved 
>> tags and
>>          started requests, so ufshcd_compl_tm() never gets a chance to 
>> run.
>> Fix:     Call blk_mq_start_request() in __ufshcd_issue_tm_cmd().
>> 
>> Problem: Race condition in send/compl paths. ufshcd_compl_tm() looks 
>> for
>>          all 0 bits in the REG_UTP_TASK_REQ_DOOR_BELL and call 
>> complete()
>>          for each req who has the req->end_io_data set. There can be a 
>> race
>>          condition btw tmc send/compl, because req->end_io_data is 
>> set, in
>>          __ufshcd_issue_tm_cmd(), without host lock protection, so it 
>> is
>>          possible that when ufshcd_compl_tm() checks the 
>> req->end_io_data,
>>          req->end_io_data is set but the corresponding tag has not 
>> been set
>>          in the REG_UTP_TASK_REQ_DOOR_BELL. Thus, ufshcd_tmc_handler()
>> may
>>          wrongly complete TMRs which have not been sent.
>> Fix:     Protect req->end_io_data with host lock. And let 
>> ufshcd_compl_tm()
>>          only handle those tm cmds which have been completed instead 
>> of
>>          looking for 0 bits in the REG_UTP_TASK_REQ_DOOR_BELL.
>> 
>> Problem: In __ufshcd_issue_tm_cmd(), it is not right to use hba->nutrs 
>> +
>>          req->tag as the Task Tag in one TMR UPIU.
>> Fix:     Directly use req->tag as Task Tag.
>> 
>> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> Since you are practically reverting Bart's change (69a6c269c097),
> maybe cc him as well,
> And add a fixes tag?
> 

Hi Avri,

It is not reverting Bart's change, but making TMR work properly based
on it. I am ok with the Bart's idea of getting a tag for TMR from
blk_get_request(), and this patch respects that idea.

> Also, even though all those fixes are around the same place, but
> fixing different issues,
> You might want to consider to separate those.  Whatever you think.
> 

Thanks for the suggestion. I treat it as a whole because it is 
convenient
for me to get it ported and tested over different platforms. I may
revise it in next version after more comments come on it.

Thanks,
Can Guo.

> Thanks,
> Avri