Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3731170pxb; Tue, 26 Jan 2021 03:22:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrti13fEJY99nKHGrO2TcNGAVO5U5bX451U9Uk7R6GO9s7qdtXyEqs25K3wfTXRAEPgGuR X-Received: by 2002:a05:6402:3508:: with SMTP id b8mr4220997edd.341.1611660160794; Tue, 26 Jan 2021 03:22:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611660160; cv=none; d=google.com; s=arc-20160816; b=ERZg64iL9b5ZZWbzQop7jOAXM+6i5Q2q9rwGQQFGHqymB9IPi+pv1S6Oh47X+FD1qE LnN39nHlq3uSr3ZXu9AcY0taE7FUuC3HGsDZ48pyU3dgoK57HiAI3yNsskZ6vu+yFDVD XoTOrkv3FvYoPTua3IC5DwRHLblEj9N2UYd1XDn836DngLvaQ9/xmbkTBjgLpFcBFxpy n0phMndrTiQzd7ZP0Q4ll+WlSqynNLmzRt+7t1A4H1KnYuyGCOCN5NZg1yp1LymGDZR6 myvkhQgWY+CLdbciHxvfYCTNow5r/O7hxej+JL4qz+6R2/30Fdni1+ruZxIWhUyLAGYR YJnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=e+YjBsbE8ipQ9gl4PaPVC+krtFmUa8sFRmsHx2gxA4U=; b=G/FtTOGHzRiWnq5sxO38hWCsbWh5XiW1/EvInEgo84UBQ1DjDU6MwZvBnomSD2szOQ bNkzUC8lE4Wo836wlDGxxMcWjHPee4jbJ6Der+OXnUvidWt4gmEod1neOGw6w9mfqsQd S1l+pwGBKLR/0m9RRPXJ6z4bmFmRL6nzOJZUR2oObcdda/USMh1UNAXipUYVqDKu+OXb So6u9yorfgcwP5eNcF4KtwZKLRo9bsfA6Hri8uY0KtoogWFjStLC6XlyLmcwwinMjozu ntS+88arQHVQbq3CHGn4UORTMbZVt9UqC1yblvFt2eBALjjvpb5JA+rGB2kqhvtxnUUE i/Kg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p5si8741486edj.169.2021.01.26.03.22.15; Tue, 26 Jan 2021 03:22:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392161AbhAZLTf (ORCPT + 99 others); Tue, 26 Jan 2021 06:19:35 -0500 Received: from out30-56.freemail.mail.aliyun.com ([115.124.30.56]:51621 "EHLO out30-56.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390159AbhAZIda (ORCPT ); Tue, 26 Jan 2021 03:33:30 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UMxkBnT_1611649917; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMxkBnT_1611649917) by smtp.aliyun-inc.com(127.0.0.1); Tue, 26 Jan 2021 16:32:13 +0800 From: Jiapeng Zhong To: kvalo@codeaurora.org Cc: pkshih@realtek.com, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Zhong Subject: [PATCH v3] rtlwifi: Simplify bool comparison Date: Tue, 26 Jan 2021 16:31:56 +0800 Message-Id: <1611649916-21936-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: ./drivers/net/wireless/realtek/rtlwifi/ps.c:798:7-21: WARNING: Comparison to bool ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3848:7-17: WARNING: Comparison of 0/1 to bool variable Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- Changes in v3: -modify email address to a unique one -modify subject prefix to "rtlwifi" -merge this patch with another patch drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++-- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/ps.c b/drivers/net/wireless/realtek/rtlwifi/ps.c index f9988225..629c032 100644 --- a/drivers/net/wireless/realtek/rtlwifi/ps.c +++ b/drivers/net/wireless/realtek/rtlwifi/ps.c @@ -798,9 +798,9 @@ static void rtl_p2p_noa_ie(struct ieee80211_hw *hw, void *data, ie += 3 + noa_len; } - if (find_p2p_ie == true) { + if (find_p2p_ie) { if ((p2pinfo->p2p_ps_mode > P2P_PS_NONE) && - (find_p2p_ps_ie == false)) + (!find_p2p_ps_ie)) rtl_p2p_ps_cmd(hw, P2P_PS_DISABLE); } } diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c index 372d6f8..1fb857c 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c @@ -3848,7 +3848,7 @@ static void _rtl8821ae_iqk_tx(struct ieee80211_hw *hw, enum radio_path path) else rtl_write_dword(rtlpriv, 0xc8c, 0x00163e96); - if (vdf_enable == 1) { + if (vdf_enable) { rtl_dbg(rtlpriv, COMP_IQK, DBG_LOUD, "VDF_enable\n"); for (k = 0; k <= 2; k++) { switch (k) { -- 1.8.3.1