Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3744688pxb; Tue, 26 Jan 2021 03:44:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJxoCXSRUMn+Puwc7nOs+KPj8f97Gao61JZzizwKrLteGtiemna7o6MBhLb+JfpwtUJgAeXU X-Received: by 2002:a17:907:94c8:: with SMTP id dn8mr3265711ejc.512.1611661472997; Tue, 26 Jan 2021 03:44:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611661472; cv=none; d=google.com; s=arc-20160816; b=mUfut8nM5rRgGKUmufxjoW3YV8s7To+jxjVMAiVbGE5mTzMefKjL9s6PtQL1+E80ku pmSKAbWCgKI1kpLnlC4Y43ANzxM/E5ZUkxMU+bhQ5ACcR/Ci3+WmYeznUt/Vw9pit9hc IFC30yGK76m2NJMEK1NdEtvmdLo7QDEh5Gpc8KdXZx2lvqcBFJRCMSzYlB8WBmxI8xkt E0Nhm3zcjklpDxinHOYdtJKJqSGf2kZ1ZXdIjh3OFbS/T1iYVcNauNKCcvDcSE04hRHY eqCFrHax994xhxnv5JtjkJ9Ansr/NR1cTkjskc9M9Skfw+HbSMqj+LyBofnjFzVIv9sl nvkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zxNMCtXliQ1UV7PXH/s1fAYCtYOC1OUZ5jx5WwFzVj4=; b=xvNGXMdpbHgnuY26o6l2Np20JGB3YWXfN7CvpH/VhvMKZlzHQwtYOQCxNCQH7Oq4+9 OixHWcxu5WGmH5fpdlq/3YU9A8/RrYIR5MNSmxEq3A1w7wkTKIoIDKjn8MD6E3w5hZIT MNMH/l/LfmGBHBCd/IEB+z5j4yhx5HBL9g6hMtsMeMPRpNbXcS5jeHmUuYfU2GEnQ57X U0/da8Obol9+0fDp7CJBYE+eFdY4FgsoEUOYf7uFgZ84mFKVpp+Sm57TighwptavkM5n WXYm3nvO9LcWc0hdy6+g30fJuci8Dn3pasYrGCfnzibtCi6SM5UAwg+CeRF6WM1LbRJp ATIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=rnHi2H7K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gb7si7307877ejc.286.2021.01.26.03.44.08; Tue, 26 Jan 2021 03:44:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=rnHi2H7K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405134AbhAZLmT (ORCPT + 99 others); Tue, 26 Jan 2021 06:42:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404229AbhAZLAV (ORCPT ); Tue, 26 Jan 2021 06:00:21 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BC28C061573 for ; Tue, 26 Jan 2021 02:59:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zxNMCtXliQ1UV7PXH/s1fAYCtYOC1OUZ5jx5WwFzVj4=; b=rnHi2H7Klf6UwcFvsAH0iDxVd CKnMn/0ZlVsH8q+a7O9XUlwNqDr3ylIx9M1KWtDK46OcJZPvviWAho9kUnAtD7vnnvlIsNg3Wa2ZH PufiuchMWzjBtv92avIpkJKoNj9guDwjvmGgv8Yex5SJZo2rZImQZcqTgwFI0Scg/opMWYQf1e0lu 2COOKEH0vuv5ZUQoJty1SlKg5PfnAit72lB/fEyds2o/IwvhFMJiWmWNuUDusg0wAQTqNUmcqeRIh TjuwVdTRNu2ggFJr+vzHuVYDdYY4AurCizQ00aCD8+X0+EqEIAyBAFJtV81sx4G9fYeIh6oXBkLSb Fvs8fS1PQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52926) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l4M4P-0004Ig-0X; Tue, 26 Jan 2021 10:59:37 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l4M4K-0003jk-UC; Tue, 26 Jan 2021 10:59:32 +0000 Date: Tue, 26 Jan 2021 10:59:32 +0000 From: Russell King - ARM Linux admin To: Lecopzer Chen Cc: akpm@linux-foundation.org, bigeasy@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, marc.zyngier@arm.com, peterx@redhat.com, rppt@kernel.org, walken@google.com, yj.chiang@mediatek.com Subject: Re: [PATCH] ARM: mm: harden branch predictor before opening interrupts during fault Message-ID: <20210126105932.GG1551@shell.armlinux.org.uk> References: <20201203092738.11866-1-lecopzer.chen@mediatek.com> <20210126091708.3461-1-lecopzer.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126091708.3461-1-lecopzer.chen@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 05:17:08PM +0800, Lecopzer Chen wrote: > Hi all, > > I don't see any fix for this issue now(maybe I missed it..?), > could we fix this if there is better solution? > This issue exists almost two years. I don't think anyone provided an acceptable patch. The first patch moved the hardening out of the translation/section fault handling. Since the kernel is mapped with sections, these are above TASK_SIZE, and the whole point of the branch prediction hardening is to prevent the prediction in the kernel being exploited, missing the hardening effectively makes the mitigation useless. The discussion in February 2019 never concluded from what I can see. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!