Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3758883pxb; Tue, 26 Jan 2021 04:08:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJzZCrBwaUOElnZ5k6XfmcE4TRFnav1BMfuk6y+7gnRJwoBQMz8ZdietRZR192zgrr7jQYbk X-Received: by 2002:aa7:de10:: with SMTP id h16mr4318964edv.385.1611662919058; Tue, 26 Jan 2021 04:08:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611662919; cv=none; d=google.com; s=arc-20160816; b=s/v564vg5Q4tdhHoY3Hl7bxUjfoy9nthXx+FRRz1haXQV6bABIDjMSoM5o5JDqhCiw a8v+iwxiSj25Ei/+MEK8toh0nXFN4swtZzUxfdvrDJhcoGS2V+7ptcVNivIjVGu94QiE 9raF5gNrNC9FHwsFvvCPAQFHgEUkD4JEoherH4GjJyaGtGoAyAzHlqqmk5tkYOpBD5oO fIBpsIT8+uv3M4IPfmavkr0YRbdl8/HbZYRgGiiTsrOwUzprGAB298FvHYmVIm0ikdT6 ZR2URuZcshtnvxnzgq/oItETx3e5sMT8ihozPusDOhhvM/WrveXUO85gxMG7ISKb0bqR iGCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=J7WFOmDDo5TTVabYLcERIPWZaXDvzIw1XO9jTgQNVr8=; b=LpTcyxzF61GGjxN2RmYj4DmaunZyq1f+PIuDsGqjOoxoPVzQzhrHXvJbxSd13ema7F dnELSLZOITlJg5cU8uSbuCoY3iWgQrU4qIVfE9eDAFdcgiwq0OlPCX1AY4ICg60O3dp4 t/IKjvHcOV2s0by3dnr638Ox3aM/pr94j4CrR1bfQpI1YN8n3xghss/g+JIn/rajiOJY /kQ7UvN/nFBudfAC5bBOSvDmItzw4CA/Fg8O1eLSxYxRfFaXxlzo1aSP7HkDlOYbLN7q bybazP2LzAg+lxxUKpn2qxZyyeH0In3E7erzp61R4ulBHRUziurGgQjrdRiUVlccX8+K gUpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tKqe587t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h11si8843227edl.78.2021.01.26.04.08.14; Tue, 26 Jan 2021 04:08:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tKqe587t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392447AbhAZLY1 (ORCPT + 99 others); Tue, 26 Jan 2021 06:24:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:56294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390952AbhAZJLR (ORCPT ); Tue, 26 Jan 2021 04:11:17 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 45CB323103 for ; Tue, 26 Jan 2021 09:10:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611652233; bh=zdTPmAwairV8shigFDysbCEYxemi0qlu/sQye+3VPYM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tKqe587tHfpvaAQFSLXLgTclXh9avJ/FnPf4SgciABCZLRIAyPYS+rQ24zuAUG1sf TW31GrsV9EuW64SHttbC0/HbkMIY8/yPV3eTEILeaD2+i05kKg6XfZXc/rolPfWa/7 ES7qmfG3dVAKsIKh/xVYPwsAIk3V5GeH6tjIjiR9Tk3+sebG0j6tTtiIoMw1vJSvoP CP3VHJvgJQk+6ThvO8jcZtSJr6lvb22OAM8T6+KufWasEtb6RDb0W5gsGJF88MDq1R jdHIQLE+5ieYWrCq4gddf4LGCrMwgQA0dwMhJ765yxo9JvknH5xRJ5N5KujGe3FAes ktCC4FcJ/v2bQ== Received: by mail-ot1-f50.google.com with SMTP id d1so15540569otl.13 for ; Tue, 26 Jan 2021 01:10:33 -0800 (PST) X-Gm-Message-State: AOAM533Htwcegqapmyc7M4fDdCK5eqn4H6btvabNtJEJvlb9z+CgBg8A NQoWiSAyKnZz2ZIYkSSE57QvMy75EZT2mBkuo5o= X-Received: by 2002:a9d:3bb7:: with SMTP id k52mr3427905otc.251.1611652232487; Tue, 26 Jan 2021 01:10:32 -0800 (PST) MIME-Version: 1.0 References: <20210125113758.2430680-1-arnd@kernel.org> <20210126080827.GA26654@trex> In-Reply-To: <20210126080827.GA26654@trex> From: Arnd Bergmann Date: Tue, 26 Jan 2021 10:10:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] optee: simplify i2c access To: "Jorge Ramirez-Ortiz, Foundries" Cc: Jens Wiklander , Arnd Bergmann , op-tee@lists.trustedfirmware.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 9:08 AM Jorge Ramirez-Ortiz, Foundries wrote: > > On 25/01/21, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Storing a bogus i2c_client structure on the stack adds overhead and > > causes a compile-time warning: > > > > drivers/tee/optee/rpc.c:493:6: error: stack frame size of 1056 bytes in function 'optee_handle_rpc' [-Werror,-Wframe-larger-than=] > > void optee_handle_rpc(struct tee_context *ctx, struct optee_rpc_param *param, > > > > Change the implementation of handle_rpc_func_cmd_i2c_transfer() to > > open-code the i2c_transfer() call, which makes it easier to read > > and avoids the warning. > > > > Fixes: c05210ab9757 ("drivers: optee: allow op-tee to access devices on the i2c bus") > > does fixing stack-frame compile warnings need a 'fixes' tag? The fixes tag only describes which commit introduced the bug, it is irrelevant what type of bug this is. Arnd