Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Jan 2021 13:20:33 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Ray Chi <raychi@google.com>
Cc:     balbi@kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH] usb: dwc3: add EXPORT_SYMBOL_GPL for role init functions
Message-ID: <YBAJERMWh8V7qbiH@kroah.com>
References: <20210126094913.180945-1-raychi@google.com>
 <YA/ogYkHrbmd1Eyo@kroah.com>
 <CAPBYUsAc25n2kFD2VQVkx7oeFXU888MWKGCQeusT4HgV1JKY3w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPBYUsAc25n2kFD2VQVkx7oeFXU888MWKGCQeusT4HgV1JKY3w@mail.gmail.com>
Precedence: bulk

On Tue, Jan 26, 2021 at 08:14:02PM +0800, Ray Chi wrote:
> On Tue, Jan 26, 2021 at 6:01 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Jan 26, 2021 at 05:49:13PM +0800, Ray Chi wrote:
> > > Currently, role init functions are used in dwc3 driver but
> > > can't be called from kernel modules.
> > >   dwc3_host_init
> > >   dwc3_host_exit
> > >   dwc3_gadget_init
> > >   dwc3_gadget_exit
> > >   dwc3_event_buffers_setup
> > >   dwc3_event_buffers_cleanup
> > >
> > > If other kernel modules want to use these functions, it needs
> > > EXPORT_SYMBOL_GPL() to get compile pass.
> > >
> > > Signed-off-by: Ray Chi <raychi@google.com>
> >
> > What current kernel configuration fails without this patch applied?  I
> > don't see any in-tree users of this as a module that would break, or am
> > I missing something?
> >
> > thanks,
> >
> > greg k-h
> 
> There is no failure for current status. This patch is just used for
> any kernel modules
> which want to call these functions. I think it is an expandability of
> dwc3 core driver.

We will gladly take exports for in-kernel users, but as you well know,
we can not export symbols that no one in the kernel tree needs, that
would be foolish of us to do so.

Please submit the code that uses these symbols and include this patch as
part of that patch series and all will be good!

thanks,

greg k-h