Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3814571pxb; Tue, 26 Jan 2021 05:37:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmGZziOsCWHTQC0luOH/DMibw6ZVDLT6+SyoKpK5PhAgAgOy1G0xKVcdLUsCgoWCK590Sc X-Received: by 2002:a17:906:ae51:: with SMTP id lf17mr3543890ejb.330.1611668260772; Tue, 26 Jan 2021 05:37:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611668260; cv=none; d=google.com; s=arc-20160816; b=KCtFkMDRyL/WOo/529T6Fjg640CMUD9tJvhQpEialL+lduicPSnXwxxRVQbjp/5UwH qMU93Ei3bAH4AuRfO8YpXORFt6zeNN3teNhyuYii/M6VSfAz+sUPmuODaV8oEGPKZa0+ C6YtFrASTLysoCj2EUx4VsrvvVO7AE7b24ypR+INEAVVr8I6Bcpt8+NP7KlW0i2IXd7E 31bO8yWF3mTqjjeGxSR3hXyx7rRF4/zFitfLWHkLmvRL/Ue4b5Y8G5ORMWIe4qVUQjrH FKk79B91LgsIaJDaSlSC8tkMJ11WIcYd2zkQ/w6X9E9+Ryax54513uf/Vlo8GcQ1MxR8 4Pqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=hNVpK5PYbazM2RPl34CzSOO2mOzJfteOFgNqxDGKlCg=; b=y6qr0q6qQFbRJ62wQ82dh+cCuM2GmThzgb3wicXXaoXiGoazFCBtKllifFAUtDwWv9 LhLztm+QPfBVCYNf4uSBtZQfgFL/Krdp+uZwVa9Ze1KslV/YIdDuthzC3W8IzIwGE8XT g2TdkqBm+/Ggwa6t60bL7GraEUxDs7UBUdGvy3+8u3huEDkr4hynljUfQuSVZEtHNvM0 GH73axDEWuOoscZ/KSJqCtHUxeURsH6xJygtcZeql4Z/+qbJUcTBl5RqILvuBlZPCife 4xS8J4jUj5uqwLHOl01uMx0dwUn+N+Yl3e/3OrkcJKVf3HdUmK5/hM13wVsGCLr4o9oi MzFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b6si8867275edq.201.2021.01.26.05.37.15; Tue, 26 Jan 2021 05:37:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403911AbhAZNdt (ORCPT + 99 others); Tue, 26 Jan 2021 08:33:49 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:11510 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404592AbhAZNdF (ORCPT ); Tue, 26 Jan 2021 08:33:05 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DQ70p5v8Jzj4x4; Tue, 26 Jan 2021 21:31:06 +0800 (CST) Received: from [127.0.0.1] (10.40.192.162) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.498.0; Tue, 26 Jan 2021 21:32:09 +0800 Subject: Re: [PATCH v5] ACPI / APEI: fix the regression of synchronous external aborts occur in user-mode To: , References: <1607602177-1507-1-git-send-email-tanxiaofei@huawei.com> CC: , , , , , , , , , From: tanxiaofei Message-ID: <94a38a33-a949-3cce-d617-e1476912596e@huawei.com> Date: Tue, 26 Jan 2021 21:32:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1607602177-1507-1-git-send-email-tanxiaofei@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.192.162] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org @James Hi James, please help to review this patch. Thank you very much. :) On 2020/12/10 20:09, Xiaofei Tan wrote: > After the commit 8fcc4ae6faf8 ("arm64: acpi: Make apei_claim_sea() > synchronise with APEI's irq work") applied, do_sea() return directly > for user-mode if apei_claim_sea() handled any error record. Therefore, > each error record reported by the user-mode SEA must be effectively > processed in APEI GHES driver. > > Currently, GHES driver only processes Memory Error Section.(Ignore PCIe > Error Section, as it has nothing to do with SEA). It is not enough. > Because ARM Processor Error could also be used for SEA in some hardware > platforms, such as Kunpeng9xx series. We can't ask them to switch to > use Memory Error Section for two reasons: > 1)The server was delivered to customers, and it will introduce > compatibility issue. > 2)It make sense to use ARM Processor Error Section. Because either > cache or memory errors could generate SEA when consumed by a processor. > > Do memory failure handling for ARM Processor Error Section just like > for Memory Error Section. > > Signed-off-by: Xiaofei Tan > --- > Changes since v4: > - 1. Change the patch name from " ACPI / APEI: do memory failure on the > physical address reported by ARM processor error section" to this > more proper one. > - 2. Add a comment in the code to tell why not filter out corrected > error in an uncorrected section. > > Changes since v3: > - Print unhandled error following James Morse's advice. > > Changes since v2: > - Updated commit log > --- > drivers/acpi/apei/ghes.c | 76 +++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 59 insertions(+), 17 deletions(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index fce7ade..0893968 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -441,28 +441,35 @@ static void ghes_kick_task_work(struct callback_head *head) > gen_pool_free(ghes_estatus_pool, (unsigned long)estatus_node, node_len); > } > > -static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, > - int sev) > +static bool ghes_do_memory_failure(u64 physical_addr, int flags) > { > unsigned long pfn; > - int flags = -1; > - int sec_sev = ghes_severity(gdata->error_severity); > - struct cper_sec_mem_err *mem_err = acpi_hest_get_payload(gdata); > > if (!IS_ENABLED(CONFIG_ACPI_APEI_MEMORY_FAILURE)) > return false; > > - if (!(mem_err->validation_bits & CPER_MEM_VALID_PA)) > - return false; > - > - pfn = mem_err->physical_addr >> PAGE_SHIFT; > + pfn = PHYS_PFN(physical_addr); > if (!pfn_valid(pfn)) { > pr_warn_ratelimited(FW_WARN GHES_PFX > "Invalid address in generic error data: %#llx\n", > - mem_err->physical_addr); > + physical_addr); > return false; > } > > + memory_failure_queue(pfn, flags); > + return true; > +} > + > +static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, > + int sev) > +{ > + int flags = -1; > + int sec_sev = ghes_severity(gdata->error_severity); > + struct cper_sec_mem_err *mem_err = acpi_hest_get_payload(gdata); > + > + if (!(mem_err->validation_bits & CPER_MEM_VALID_PA)) > + return false; > + > /* iff following two events can be handled properly by now */ > if (sec_sev == GHES_SEV_CORRECTED && > (gdata->flags & CPER_SEC_ERROR_THRESHOLD_EXCEEDED)) > @@ -470,14 +477,51 @@ static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, > if (sev == GHES_SEV_RECOVERABLE && sec_sev == GHES_SEV_RECOVERABLE) > flags = 0; > > - if (flags != -1) { > - memory_failure_queue(pfn, flags); > - return true; > - } > + if (flags != -1) > + return ghes_do_memory_failure(mem_err->physical_addr, flags); > > return false; > } > > +static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata, int sev) > +{ > + struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata); > + struct cper_arm_err_info *err_info; > + bool queued = false; > + int sec_sev, i; > + > + log_arm_hw_error(err); > + > + sec_sev = ghes_severity(gdata->error_severity); > + if (sev != GHES_SEV_RECOVERABLE || sec_sev != GHES_SEV_RECOVERABLE) > + return false; > + > + err_info = (struct cper_arm_err_info *) (err + 1); > + for (i = 0; i < err->err_info_num; i++, err_info++) { > + bool is_cache = (err_info->type == CPER_ARM_CACHE_ERROR); > + bool has_pa = (err_info->validation_bits & CPER_ARM_INFO_VALID_PHYSICAL_ADDR); > + > + /* > + * The field (err_info->error_info & BIT(26)) is fixed to set to > + * 1 in some old firmware of HiSilicon Kunpeng920. We assume that > + * firmware won't mix corrected errors in an uncorrected section, > + * and don't filter out 'corrected' error here. > + */ > + if (!is_cache || !has_pa) { > + pr_warn_ratelimited(FW_WARN GHES_PFX > + "Unhandled processor error type %s\n", > + err_info->type < ARRAY_SIZE(cper_proc_error_type_strs) ? > + cper_proc_error_type_strs[err_info->type] : "unknown error"); > + continue; > + } > + > + if (ghes_do_memory_failure(err_info->physical_fault_addr, 0)) > + queued = true; > + } > + > + return queued; > +} > + > /* > * PCIe AER errors need to be sent to the AER driver for reporting and > * recovery. The GHES severities map to the following AER severities and > @@ -605,9 +649,7 @@ static bool ghes_do_proc(struct ghes *ghes, > ghes_handle_aer(gdata); > } > else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) { > - struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata); > - > - log_arm_hw_error(err); > + queued = ghes_handle_arm_hw_error(gdata, sev); > } else { > void *err = acpi_hest_get_payload(gdata); > >