Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3862528pxb; Tue, 26 Jan 2021 06:43:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzRf/bB7fhZGV02Gdhzz3unDWGUVAjJ5ZSwpQVfOqEUoDJWDNI/pGh5KVEP27CdU+8CDg4w X-Received: by 2002:a05:6402:1422:: with SMTP id c2mr4796695edx.280.1611672204009; Tue, 26 Jan 2021 06:43:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611672204; cv=none; d=google.com; s=arc-20160816; b=j+SpElR6W2N+s8sWAOYL63vamxZATmbyLVADGzuIlVVx1EVDDuggKw6siMi6yNt46W epGWeYGjmN3D3fd6V++LEtaoS5U/VsUr8o3+btp91lXmfOWEy6OU3wwxrzMR0Lo2TsMe ZXOH9HeLkmmGjj6Jp2D6kCc8w0TT5RfsZfk1JKcUqvDxBdL6Qk1ZOqjjLu9awN5iaoUj KVWhwBaYkQ2h+lSBuhLIy7S56fbrJcPUR26MKYfddk161icBf+3xYrUMiKkrw54+o8d/ u86NjqfHulwdiltmrxw9HFPXJKWaorbpswvDYZG5QjBwXpyqhknAqhZkrlrwyH7+hzah 53EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=/4qKqMpBGy/Qf3mpic0c67LL73UCmg2/8eDY2TmrXpU=; b=yRCO31rzTEG5D+CWGLdGj9bX0VJZNtcqfd/7TUWGMWHtBryK/zxGg87Rxz/pn9jBy/ Pog8wVW7423BmDK6O1S157NDWls1ZHHXlp4WkFK307IxpsK1vuBC7slU6ktccRSKNLp/ ZKg3jZT8nqbJUP9K34GFFXviBdNi3pq9hTPTtYcJfbZfm/YxYZBTKRjx6zxoju+jsFzx wLZOOJ1tWsnWQZFzcp1/gv6KKtpG21zoS/YuJuSpO55J39GKOsadgRkIuTrnf+MVbJlS m+qK4zdgVT5gvjncirjIUxNfmAzE2G6193VvCIEnwuSMjqYEUrNcBZP2Qt9B5aeWJDOD TS4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k17si8846701edr.594.2021.01.26.06.42.58; Tue, 26 Jan 2021 06:43:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405876AbhAZOiW (ORCPT + 99 others); Tue, 26 Jan 2021 09:38:22 -0500 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:48779 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391577AbhAZJwV (ORCPT ); Tue, 26 Jan 2021 04:52:21 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0UMyf0qW_1611654680; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMyf0qW_1611654680) by smtp.aliyun-inc.com(127.0.0.1); Tue, 26 Jan 2021 17:51:33 +0800 From: Jiapeng Zhong To: robdclark@gmail.com Cc: sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, sumit.semwal@linaro.org, christian.koenig@amd.com, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Jiapeng Zhong Subject: [PATCH] drm/msm: remove redundant NULL check Date: Tue, 26 Jan 2021 17:51:19 +0800 Message-Id: <1611654679-102885-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./drivers/gpu/drm/msm/msm_gem.c:991:3-9: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- drivers/gpu/drm/msm/msm_gem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index 9d10739..4f1f1a0 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -987,8 +987,7 @@ void msm_gem_free_object(struct drm_gem_object *obj) /* Don't drop the pages for imported dmabuf, as they are not * ours, just free the array we allocated: */ - if (msm_obj->pages) - kvfree(msm_obj->pages); + kvfree(msm_obj->pages); put_iova_vmas(obj); -- 1.8.3.1