Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3865342pxb; Tue, 26 Jan 2021 06:47:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnev7CLluF5TVsUtCexYdQ18/DpPyatFL9w18EX0/6BQYqnEMAqjCXhu/7yKVxTQo2PwfE X-Received: by 2002:aa7:cdcb:: with SMTP id h11mr4878453edw.237.1611672442116; Tue, 26 Jan 2021 06:47:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611672442; cv=none; d=google.com; s=arc-20160816; b=CDApmD9Fa2QPc43vIKSZfzqNLmVMKFJIK+FR2w8TGa9jgvGhclRdB0f7vTQnkXVZM5 D7frVZbNo95KmnXPyon0UZsuBqp8ekUhI7w0BjXZiMxIr5OaAS+AOQWX7FfzbUKm9VB9 m0mIm3IYjxea42RYHVm9JsiLXp9lf/lLUcYYg2xIflbBMUGbK50QsGJTpmeWmxxKIFWs mMmx1yFy2sXuMqfqSLQzmt7L9w1s3Zwepxi3ygqBQA7qVsFAHYtqNXPpkSE2nxljVPww wANpS/WZgZjGEbp8yzH+nFEeKpU0+mg2lR1MMzh1vzrZe1pFoUgbc4sVeKaDJQ4XKdJ5 8sDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=4BMx/jnRKNmSanjynRNJ0nDLfx/v1dvq2mZ8UZ0d4sc=; b=vQ3y+vyVjcjDU7iIl5mh9o/4F23QK8Ts6IM8RtdWPYLKk6rqP/xT7wHpATm4bcvyZg 4GSSrPul/tfqFnhhxUiiGyCjwmYuy/2lk5WU4wEakAHeDZ6lQtLCzC6hrMLxJxxpMupo wUN+kaSH8Zhh0XOR8yD3KkxRE+4FV9nbrfLjgAZi0Fzn0TUxsCZp5C0NtB+5cjdwJqHq 6LRkGNo+AdG7Kn1kBrY+If5KM9E+P0AS1DOetbVpQoT8TyZ6vZdvPd3dIffVk7NX2WRb 3+n/s6JXZfZpdd8KMRHfpDj535Vbo0emr9wJ4LesPbNIBrPYhPqFA7FpKroBJZ62vtdP A7TQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m24si8646947edr.215.2021.01.26.06.46.50; Tue, 26 Jan 2021 06:47:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391560AbhAZOoG (ORCPT + 99 others); Tue, 26 Jan 2021 09:44:06 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:48103 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390386AbhAZJob (ORCPT ); Tue, 26 Jan 2021 04:44:31 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0UMxz7nf_1611654189; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMxz7nf_1611654189) by smtp.aliyun-inc.com(127.0.0.1); Tue, 26 Jan 2021 17:43:16 +0800 From: Jiapeng Zhong To: l.stach@pengutronix.de Cc: airlied@linux.ie, daniel@ffwll.ch, sumit.semwal@linaro.org, christian.koenig@amd.com, linux+etnaviv@armlinux.org.uk, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Jiapeng Zhong Subject: [PATCH] drm/gem: remove redundant NULL check Date: Tue, 26 Jan 2021 17:43:07 +0800 Message-Id: <1611654187-95651-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c:80:2-8: WARNING: NULL check before some freeing functions is not needed. ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:612:2-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 +-- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++-------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c index d9bd832..c402d424 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c @@ -80,8 +80,7 @@ static void etnaviv_gem_prime_release(struct etnaviv_gem_object *etnaviv_obj) /* Don't drop the pages for imported dmabuf, as they are not * ours, just free the array we allocated: */ - if (etnaviv_obj->pages) - kvfree(etnaviv_obj->pages); + kvfree(etnaviv_obj->pages); drm_prime_gem_destroy(&etnaviv_obj->base, etnaviv_obj->sgt); } diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c index d05c359..bd0d66e 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c @@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, err_submit_cmds: if (ret && (out_fence_fd >= 0)) put_unused_fd(out_fence_fd); - if (stream) - kvfree(stream); - if (bos) - kvfree(bos); - if (relocs) - kvfree(relocs); - if (pmrs) - kvfree(pmrs); + kvfree(stream); + kvfree(bos); + kvfree(relocs); + kvfree(pmrs); return ret; } -- 1.8.3.1