Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a4ecfaf99f322c752d6422056d4ea94f9b3d962b.camel@kernel.org>
Subject: Re: [PATCH 3/4] tpm: in tpm2_del_space check if ops pointer is
 still valid
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc:     peterhuewe@gmx.de, jgg@ziepe.ca, stefanb@linux.vnet.ibm.com,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        p.rosenberger@kunbus.com, Lino Sanfilippo <l.sanfilippo@kunbus.com>
Date:   Tue, 26 Jan 2021 17:29:23 +0200
In-Reply-To: <9bb612ef-75be-f8d4-10a6-7ab5869da18f@gmx.de>
References: <1610760161-21982-1-git-send-email-LinoSanfilippo@gmx.de>
         <1610760161-21982-4-git-send-email-LinoSanfilippo@gmx.de>
         <YAR+R0c8HYsVUhZQ@kernel.org> <9bb612ef-75be-f8d4-10a6-7ab5869da18f@gmx.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.38.3 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2021-01-24 at 17:47 +0100, Lino Sanfilippo wrote:
>=20
> Hi Jarkko,
>=20
> On 17.01.21 at 19:13, Jarkko Sakkinen wrote:
> >=20
> > I have hard time to believe that any of these patches are based on
> > actual regressions.
> >=20
> > /Jarko
> >=20
>=20
> patch 1 is indeed wrong (I oversaw the action call in case of error),
> so please ignore it.
>=20
> However patches 2 and 3 are based on bugs I encountered while working wit=
h
> TPM. I am sorry if I did not make the issues clear enough in the patches
> commit messages. Let me try to explain it in more detail:
>=20
> The bugs showed up after unloading the TPM chip driver module while one
> process still had the /dev/tpmrm device open.

Please refine the patch set, and we will look into that then.

Put fixes tags and logs where appropriate. Thanks.

/Jarkko