Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= <mic@digikod.net>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Miroslav Lichvar <mlichvar@redhat.com>,
        John Stultz <john.stultz@linaro.org>,
        Prarit Bhargava <prarit@redhat.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-rtc@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [patch 1/8] rtc: mc146818: Prevent reading garbage - bug
In-Reply-To: <98cb59e8-ecb4-e29d-0b8f-73683ef2bee7@digikod.net>
References: <20201206214613.444124194@linutronix.de> <20201206220541.594826678@linutronix.de> <19a7753c-c492-42e4-241a-8a052b32bb63@digikod.net> <871re7hlsg.fsf@nanos.tec.linutronix.de> <98cb59e8-ecb4-e29d-0b8f-73683ef2bee7@digikod.net>
Date:   Tue, 26 Jan 2021 16:35:18 +0100
Message-ID: <87y2gfg18p.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jan 26 2021 at 15:17, Micka=C3=ABl Sala=C3=BCn wrote:
> Thanks for the fix! It boots now with a new message:
> rtc_cmos rtc_cmos: not accessible
>>  	spin_lock_irqsave(&rtc_lock, flags);
>> +	/* Ensure that the RTC is accessible. Bit 0-6 must be 0! */
>> +	if (WARN_ON_ONCE((CMOS_READ(RTC_VALID) & 0x7f) !=3D 0)) {
>> +		spin_unlock_irqrestore(&rtc_lock, flags);
>> +		memset(time, 0xff, sizeof(time));
>
> This should be: sizeof(*time)

Of course ....

>> +		return 0;
>> +	}
>> +
>>  	/*
>>  	 * Check whether there is an update in progress during which the
>>  	 * readout is unspecified. The maximum update time is ~2ms. Poll
>>=20
>
> Tested-by: Micka=C3=ABl Sala=C3=BCn <mic@linux.microsoft.com>